- 03 Mar, 2020 31 commits
-
-
Joyee Cheung authored
When an empty class is nested inside a class with private instance methods, like this: class Outer { constructor() {} #method() {} factory() { class Inner { constructor() { } } return Inner; } run(obj) { obj.#method(); } } The bytecode generator previously generate private brand initialization for the constructor of Inner by mistake, because during scope chain serialization/deserialization, the outer scopes of Inner and factory() are not allocated or serialized (as they are empty). In the eyes of the bytecode generator, it then appeared as if Outer is the direct outer scope of Inner's constructor. In order to work around this information loss, in this patch we rely on SharedFunctionInfo instead of the Context/ScopeInfo chain to maintain the information about private brand initialization. This is done by shrinking expected_nof_properties to 8 bits and freeing 8 bits for a second bitfield on the SFI. Design doc: https://docs.google.com/document/d/14maU596YbHcWR7XR-_iXM_ANhAAmiuRlJZysM61lqaE/edit# Bug: v8:9839, v8:8330, v8:10098 Change-Id: I4370a0459bfc0da388052ad5a91aac59582d811d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056889 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#66575}
-
Leszek Swirski authored
Remove Isolate parameters from some dictionary methods, and change others to use ReadOnlyRoots instead, to prepare for Isolate templatization in a future patch. One small side-effect is that the global dictionary's property cell's dependent code deoptimization has to dynamically get the Isolate when it needs to actually mark code for deoptimization, for method signature consistency. Given that this is the slow path anyway, it shouldn't matter. Bug: chromium:1011762 Change-Id: I707de9a74ca3b30423a1e5830a10729d6a404786 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080369 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Z Nguyen-Huu authored
Add tier up to existing recompilation logic. This is a part of Tier up to Turbofan on Debugger.disable Bug: v8:10290 Change-Id: I44731df520201ac254f2d1bfbfb5c49d8bb50117 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080658 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66573}
-
Z Nguyen-Huu authored
Example can be inspector tests. Bug: v8:10264 Change-Id: I996bb68d0f36920568a04f93cd8c1256a4f41a96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2070912 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66572}
-
Leszek Swirski authored
Rather than walking SharedFunctionInfos recursively via bytecode constant pools to ensure they have source positions, walk the script's shared function info list. Bug: chromium:1011762 Change-Id: I19ab0f3355dc8169f7a0170b4198075bd3823c04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2084816 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#66571}
-
Victor Gomes authored
Bug: v8:10201 Change-Id: I5cae5d5c30f42427995c2380d906ade0f117fcd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083011 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Make Hashtable Shapes return Map Handles (from the read-only roots) instead of the root index of the Map, so that they can be used off the main thread. Bug: chromium:1011762 Change-Id: I4c0a8518dc1c6d490b5c04da05b5319081a6fae5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083298 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Move the recently introduced extra check for 32-bit platforms so that it covers all code paths that would be hit by custom/future memory limit settings. Bug: chromium:1057094 Change-Id: I5e2217a24578ee82c7bfa753b7d5dcd3d00e1b7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083300Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66568}
-
Ambroise Vincent authored
Vectors are being sorted multiple times in EmitBinarySearchSwitch(). Change-Id: I8c1053b8a5371904475a3f8c909041835e441d9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2077683Reviewed-by:
Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#66567}
-
Leszek Swirski authored
Add the remaining missing templatizations to allow an initial wiring in of the off-thread factory into streaming compilation finalization. The off-thread finalization is behind a flag, disabled by default: --finalize-streaming-on-background When the flag is enabled, background tasks will perform perform the finalization during their background execution, and will release the parser and compilation jobs once they are no longer needed. The implementation is complete enough for performance testing, but not enough for launch. Notably, there is no support for: * Class boilerplates (the code is marked unreachable), * Exceptions during finalization, i.e. parse/compile warnings/errors, * Allocation sampling, * Logging, * Asm.js, * Parallel complication tasks * Forced source positions (for "NeedsDetailedOptimizedCodeLineInfo()") This patch also adds some tracing events for the various stages of the off-thread finalization (including the main-thread merge) for further performance improvements. Bug: chromium:1011762 Change-Id: Ia44fa56975dd689f0d92c1543b294cdb063eb199 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066965 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: -
Milad Farazmand authored
Port 34f9bcdb Original Commit Message: Implements i8x16.abs, i16x8.abs, and i32x4.abs. R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ib32356532965a2187a8e8d9ec2cff44585020f0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2084641Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#66565}
-
Milad Farazmand authored
Port 9245e3b4 R=zhiguo.zhou@intel.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I9a6358dfd2bfd69e421c85fe3bbf343e7aee3b8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081575Reviewed-by:
-
Leszek Swirski authored
Although AccessorInfos are technically mutable, in practice they are not mutated after initialization, and they are guaranteed to be immortal and immovable. So, we can safely make them accessible from the off-thread factory, as long as the user promises to not try to mutate them. This is necessary for off-thread class boilerplate creation. Bug: v8:10218 Bug: chromium:1011762 Change-Id: Id3108a2324a000ea0616b472dd77aed65b1f908e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080351 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#66563}
-
Dominik Inführ authored
Report the total size of global handles in GetHeapStatistics as well. This size includes used and free global handles. Change-Id: I08c0647d993a810a37ae9f332732de9551b5ea8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083020 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Change-Id: Iecfa43f02287d8a540663ed65ad26cdf31e0a19a No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2082567Reviewed-by:
-
Victor Gomes authored
Bug: v8:10201 Change-Id: Ia7e964df89ac134c01a3fd94ce4b15f1afd0cbff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083295Reviewed-by:
-
Camillo Bruni authored
Change-Id: I213587414aaa4d159dc0c6fd9b5986d7bfcaa3ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2082562Reviewed-by:
-
Camillo Bruni authored
Call the @@hasInstance trap only when required by the spec. Bug: chromium:1052647 Change-Id: I7a0a3133c7b6280c6a3215e379bf02e9c22ffe55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2082560 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#66558}
-
Ulan Degenbaev authored
The scope disables garbage collection and should be only used in heap, deserializer, isolate bootstrap, and testing. Change-Id: Ide95926ef32fd9362cd9134e883e1bd626cc3b11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083292Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#66557}
-
Michael Achenbach authored
TBR=santa Change-Id: Ie318314abb2384df22deee4e3e33e2a7139e8d7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083482Reviewed-by:
-
Shu-yu Guo authored
Bug: v8:10293 Change-Id: If585e7860721cb2de37a0de5bf135e7a4e226190 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081338 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66555}
-
Camillo Bruni authored
Newer gdb versions require the return type to be specified. Change-Id: Ia9c160858036e9cbbe1ced123bbcc79d9efb78b4 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2082561Reviewed-by:
-
Clemens Backes authored
The histograms were removed from chrome. This CL cleans up the V8 code to stop reporting samples. R=ahaas@chromium.org Bug: chromium:1053285 Change-Id: I7c6ff36ac9bb5d86e81e5f36849903a95a8ed618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083478Reviewed-by:
-
Zhou, Zhiguo authored
Bug: v8:9909 Change-Id: Id89ddb429c90f3f454a581d75b783ff56775b01e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049247 Commit-Queue: Zhiguo Zhou <zhiguo.zhou@intel.com> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Matheus Marchini authored
Improve postmortem metadata generated by gen-postmortem-metadata by also including weak and synchronous accessors, as well as CHECKED and CHECKED2 variants of all accessors currently considered by gen-postmortem-metadata. Also improve type collection by parsing TORQUE_INSTANCE_CHECKERS_SINGLE_FULLY_DEFINED, as we were missing several types with the previous heuristic (like StackTraceFrame, PromiseReaction, and many others). This will include 96 new v8dbg constants which can be used by debuggers like llnode. R=hpayer@google.com, verwaest@google.com, victorgomes@google.com Change-Id: Ia9bea21eec38b92d255c3636c6a284eb27e9ed9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056126Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66551}
-
Jakob Gruber authored
This is a reland of c6c9d4bf Original change's description: > Update unicode-regexp-ignore-case-noi18n expectations > > There appear to be one or several bugs in noi18n mode such that > expectations in this test are no longer met. This CL updates > expectations to the current behavior and re-enables the test so we at > least preserve coverage in the other cases. > > The behavior in question should be investigated in the future > (low priority). > > Bug: v8:10120 > Change-Id: Ib7c9a18133a386e6e39ee54d68ce4106d9b28c84 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081815 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66524} Bug: v8:10120 Change-Id: Ib2ee68e26c2aebe2eeab3ec9f7bc263fd79f3773 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083291 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
Port d303f4fb https://crrev.com/c/2081816 Original Commit Message: In the past we've used the isolate argument to signal whether we were in unicode mode (nullptr) or not (the real isolate). This is no longer needed, and in fact breaks no-i18n mode which always expects to have a real isolate. Change-Id: I90a69a38cb4e74da46b3030843bc84d6d53571c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2082932 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
Ng Zhi An authored
Implements i8x16.abs, i16x8.abs, and i32x4.abs. Bug: v8:10233 Change-Id: I32391e8f895fea808180561d89a4fd24fbead3bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067845 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#66548}
-
Ng Zhi An authored
Bug: v8:9561 Change-Id: Ia9d1c263f4dc382f8b772e3cba57a4f14235b310 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069402Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b03644a..c6ac51f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9ca9c52..4576851 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I93e5506a0a4f9f8830ccdd11623d6bac88584556 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083667Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#66546}
-
Ng Zhi An authored
Bug: v8:9561 Change-Id: I733df8856ad8266a637794a9401118937e6bf006 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069401Reviewed-by:
-
- 02 Mar, 2020 9 commits
-
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10108 Change-Id: I3bdb4c2abe0b1db1babec370921463dbdfcd0a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074403 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
The spec was changed in February TC39 to make ToInteger always normalize -0 to +0. This only observably affects Atomics.store. Bug: v8:10271 Change-Id: I0e8f6c35cef982eae242cf6619f6f24fa75b1759 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2076509Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
Some opcodes are introduced in V8 for prototyping, and performance measurements that are not officially a part of the current SIMD proposal but may be included in future, gate these by a separate flag. Change-Id: Icc6a9e89c6196c8ff144d2e0193d707e1f60c38b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2079539 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10108 Change-Id: I72294ae6fa62209e078b3d00151207524b32e67e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074401 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Negating 1 << 31 as a signed integer overflows and causes undefined behaviour hence SetS390OverflowCode may never get set. Change-Id: I91379a53752de322cee4541cf44fb65338a614e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081335Reviewed-by:
-
Milad Farazmand authored
Also adding to and modifying some of the F32x4 operations. Change-Id: Ia57dcd70a3bad2f1ec4ccc64ff2cb02b9c83aa22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081832Reviewed-by:
-
Leszek Swirski authored
During class boilerplate allocation, we were overestimating the number of computed properties before allocating the computed property array, and the array after. But, we can reasonably easily get an exact size for the computed properties array, and avoid the right trimming entirely. This will simplify off-thread class boilerplate allocation, where the off-thread heap doesn't currently implement right trimming. Bug: chromium:1011762 Change-Id: Icf450340aa4e215c2063f4dd964ca7b80ef033c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083029 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Andreas Haas authored
Implements AtomicWait on 64-bit platforms. Note that this implementation does not use {PrepareCall}, as planned originally. This will be done in a separate CL, to prepare the implementation for 32-bit platforms. This CL for now unblocks the implementation on x64. R=clemensb@chromium.org Bug: v8:10108 Change-Id: I52eb752364b231043975f62913c2ef9579321038 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074400 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: -
Toon Verwaest authored
This reverts commit 90b39673. Reason for revert: These functions are in use by d8-js.cc Original change's description: > [cleanup] Remove three unused proxy runtime functions > > R=jgruber@chromium.org > > Bug: v8:9183 > Change-Id: I789295e5bbea682b2e46ccf5a55c69dc74f0ed72 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617669 > Auto-Submit: Simon Zünd <szuend@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61632} TBR=jgruber@chromium.org,szuend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9183, v8:10289 Change-Id: Ibd8566151f036efe73c869dcfd2cfee2a559489b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083299Reviewed-by:
-
