- 31 May, 2017 3 commits
-
-
Marja Hölttä authored
- Enable aggressive lazy inner funcs (make non-declaration funcs lazy, ie let f = function() { ... } when --experimental-preparser-scope-analysis is on. - Turn on variable tracking for lazy top level functions: this makes their inner functions skippable. - Test fix for an testing bug uncovered by this work: when restoring the data for the relevant scope, don't assume it's the outermost scope for which we have data. - Fix: if we abort lazy parsing a function, we shouldn't produce any data for it. BUG=v8:5516 Change-Id: I0606fbabb5886dc57dbb53ab5f3fb894ff5d032e Reviewed-on: https://chromium-review.googlesource.com/518165Reviewed-by:Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#45615}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e840a06..0312f98 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/ea7d9cf..32a3f0b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/34e6d43..7474c16 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: I30259bb2e7399419ee7f258e15edd9488efa7f16 Reviewed-on: https://chromium-review.googlesource.com/518722Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#45614}
-
dgozman authored
- introduced session id, which fixes an issue of reconnect while evaluating; - forEachContext provides a safe way to iterate over contexts in a group. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2905543004 Cr-Commit-Position: refs/heads/master@{#45613}
-
- 30 May, 2017 33 commits
-
-
Jochen Eisinger authored
Use the appropriate ENTER_V8* macros instead BUG=v8:5830 R=marja@chromium.org Change-Id: I85d7ae69830f6bad4f7057c4a646906846a1baa0 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/517793 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#45612}
-
Michael Lippautz authored
Retrieve length from the buffer instead of storing in as value in the map. This reverts commit a73323d3. Bug: Change-Id: I2f17b1b121380ec3d70f42d7cd0015720d6dc7d1 Reviewed-on: https://chromium-review.googlesource.com/518132Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#45611}
-
Ali Ijaz Sheikh authored
Bug: Change-Id: If8c9db5ad4114f9ce3ca925d85a776fdb7da8fed Reviewed-on: https://chromium-review.googlesource.com/513525Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#45610}
-
sampsong authored
BUG= R=jyan@ca.ibm.com, bjaideep@ca.ibm.com, joransiu@ca.ibm.com Review-Url: https://codereview.chromium.org/2905453002 Cr-Commit-Position: refs/heads/master@{#45609}
-
rodolph.perfetta authored
In TurboFan the ArchDebugBreak opcode is not used for debugging but to force a crash in unreachable or unimplemented code path. The opcode was marked as having no side effects allowing the scheduler to bring it "up" with unfortunate consequences. This patch also update the behaviour of assembler::debug when not using the simulator. Review-Url: https://codereview.chromium.org/2901383004 Cr-Commit-Position: refs/heads/master@{#45608}
-
jgruber authored
This adds a bunch of assertions to CSA, mostly about documenting and checking parameter types. Drive-by-change: Removed unused function. BUG=v8:6325 Review-Url: https://codereview.chromium.org/2847923003 Cr-Original-Original-Commit-Position: refs/heads/master@{#45398} Committed: https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d6b4bd Review-Url: https://codereview.chromium.org/2847923003 Cr-Original-Commit-Position: refs/heads/master@{#45443} Committed: https://chromium.googlesource.com/v8/v8/+/62b0de1ef53816d6dae3fa519a846f942b701dda Review-Url: https://codereview.chromium.org/2847923003 Cr-Commit-Position: refs/heads/master@{#45607}
-
Michael Achenbach authored
This reverts commit a402dd63. Reason for revert: Breaks msan: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/15197 Original change's description: > [heap] Simplify array buffer tracker > > Retrieve length from the buffer instead of storing in as value in the > map. > > Change-Id: Icdc87bb46c29fff779bf6e98139324662ced5bf6 > Reviewed-on: https://chromium-review.googlesource.com/518171 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45600} NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true TBR=mlippautz@chromium.org,jochen@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I22e3590528beb911d366b9d93ec302857a631971 Reviewed-on: https://chromium-review.googlesource.com/518117 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45606}
-
jgruber authored
Passing --print-builtin-size will print the size of all builtins on isolate creation. BUG=v8:5737 Review-Url: https://codereview.chromium.org/2895163002 Cr-Commit-Position: refs/heads/master@{#45605}
-
Camillo Bruni authored
Bug: chromium:726836 Change-Id: I2eaec8550e7ba038646a1f7834d4514a8d4009ea Reviewed-on: https://chromium-review.googlesource.com/517954Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#45604}
-
Marja Hölttä authored
It's extremely difficult to get right: there have been several bugs related to this feature, especially when combined with non-simple parameter lists in arrow functions. BUG=chromium:727218 Change-Id: I97dfbc57a7650199964c5fe99de69143c8e537c2 Reviewed-on: https://chromium-review.googlesource.com/518145 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=ahaas@chromium.org Change-Id: I69867a9595e7276ebf30fa3239620585d2cef568 Reviewed-on: https://chromium-review.googlesource.com/518186Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#45602}
-
Michael Achenbach authored
The old logic made the cfi build fail on each clang update. Bug: chromium:726584 Change-Id: Ia24181d3bc92eb18116c2ac2b42ac2c68f02ce25 Reviewed-on: https://chromium-review.googlesource.com/518185Reviewed-by:
-
Michael Lippautz authored
Retrieve length from the buffer instead of storing in as value in the map. Change-Id: Icdc87bb46c29fff779bf6e98139324662ced5bf6 Reviewed-on: https://chromium-review.googlesource.com/518171 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
hpayer authored
BUG=chromium:727569 Review-Url: https://codereview.chromium.org/2910203002 Cr-Commit-Position: refs/heads/master@{#45599}
-
Aleksey Kozyatinskiy authored
This CL improves break locations for expressions like 'var a = <expr>'. Without CL we use <expr> position as break location for initialization statement, with this CL we use position of first character after '=' as position. Benefits (see test for details): - only one break in expressions which includes mix of property lookup and calls, e.g. var p = Promise.resolve().then(x => x * 2), - removed redundant break location for expressions like: let { x, y } = { x: 1, y: 2}. TBR=dgozman@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org,marja@chromium.org,kozyatinskiy@chromium.org,devtools-reviews@chromium.org,v8-reviews@googlegroups.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:5909 Change-Id: Ie84fa79afeed09e28cf8478ba610a0cfbfdfc294 Reviewed-on: https://chromium-review.googlesource.com/518116 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45598}
-
Marja Hölttä authored
BUG=v8:5402 Change-Id: Ia6639d69a31accf46c10e8d49ea72422225cc8ff Reviewed-on: https://chromium-review.googlesource.com/517788Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
BUG=chromium:723600 Change-Id: I7fbc9cbeac2bd3d826d81808c0f3c2c24a21a562 Reviewed-on: https://chromium-review.googlesource.com/518013Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#45596}
-
Jochen Eisinger authored
Also document them. BUG=v8:5830 R=marja@chromium.org Change-Id: I86e71c8e24e4b7f3032e0f2365cf72575b1eb413 Reviewed-on: https://chromium-review.googlesource.com/518155Reviewed-by:
-
Jochen Eisinger authored
We add the bot via the post-upload step, that's good enough R=machenbach@chromium.org,tandrii@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I8d582d101b4d2f308829da75df56e04a3dabadbf Reviewed-on: https://chromium-review.googlesource.com/518114Reviewed-by:
-
Clemens Hammacher authored
The problem with enums is that neither is_integral, nor is_signed or is_unsigned is true for them. Thus, comparison with our CHECK/DCHECK macros always just uses the default comparison, which fails if the signedness of the underlying integer types does not match. This CL fixes this by considering the underlying integer type of an enum to choose the right comparison operator. R=ishell@chromium.org CC=ahaas@chromium.org Change-Id: I5ef56d1b86228e879f5866967ab7e709f1e97f0b Reviewed-on: https://chromium-review.googlesource.com/518123 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Igor Sheludko authored
This may happen in KeyedStoreIC when the last store via setter deprecates the receiver map. Bug: chromium:723366 Change-Id: Iff19e50c3761584401340d276ab4eead111883c3 Reviewed-on: https://chromium-review.googlesource.com/517952Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#45592}
-
Clemens Hammacher authored
This CL replaces the last usages of std::vector in the AsmJsParser by ZoneVector. This allows to also measure the memory consumption of these vectors, since it is now contained in the zone memory. ZoneVectors are reused to avoid accumulating lots of unused memory. This also saves 2.6% performance (avg over 1000 runs) on my local workstation. R=mstarzinger@chromium.org Change-Id: I04c96db558d9c362b1494ddd9e975edf2783403c Reviewed-on: https://chromium-review.googlesource.com/516985Reviewed-by:
-
Jochen Eisinger authored
Also enable post-upload-hooks R=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I8001394454f5d71d48a5e6261c891d6c7c2c3825 Reviewed-on: https://chromium-review.googlesource.com/518167Reviewed-by:
-
Clemens Hammacher authored
Both lazy initialization and static initialization (via static initializer) are bad. Fortunately, the arrays we are constructing are constant anyway, so we can just compute them at compile time. This is enforced by making them constexpr. This also saves all code needed for the initialization, and makes accesses to the tables faster, as they don't need any atomic operations (via LazyInstance). R=ahaas@chromium.org Change-Id: I7d3ba9b0f2602f596a6c71c8c567e0d1bc306268 Reviewed-on: https://chromium-review.googlesource.com/517083 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Achenbach authored
V8-part of: https://chromium-review.googlesource.com/c/517791 NOTRY=true NOTREECHECKS=true TBR=kjellander@chromium.org,tandrii@chromium.org,mstarzinger@chromium.org Bug: chromium:726584 Change-Id: I0e8b6adf6938dce02c84f5d5cbde6ff828dcbb08 Reviewed-on: https://chromium-review.googlesource.com/518152 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This time for the current memory size. This call also used to use the context object stored in the instance, hence it required the instance to be set. This is no longer the case, so the DCHECKs can just be removed. R=ahaas@chromium.org BUG=chromium:727222 Change-Id: I72a7e3e80c3beb15ecad00c5be068e803456797e Reviewed-on: https://chromium-review.googlesource.com/517947Reviewed-by:
-
Wiktor Garbacz authored
Non-printable characters will are printed as escapes. NUL won't terminate error message prematurely now. Change-Id: Ie24b34e377221e9b99d2268f8dfb5ce26d064cc2 Reviewed-on: https://chromium-review.googlesource.com/509490Reviewed-by:
-
Wiktor Garbacz authored
Change-Id: Icf4d67700bae4338ecf66411f2a5f57c5351f688 Reviewed-on: https://chromium-review.googlesource.com/504867Reviewed-by:
-
ulan authored
This is consistent with C++ memory model and avoids confusion with GC write barrier. BUG= Review-Url: https://codereview.chromium.org/2912773002 Cr-Commit-Position: refs/heads/master@{#45584}
-
Jochen Eisinger authored
This reverts commit 75843f4f. Reason for revert: Shouldn't affect test Original change's description: > Revert "Remove ENTER_V8_DO_NOT_USE usage from other macros" > > This reverts commit 2ba1fcda. > > Reason for revert: Speculative for: > https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/8413 > > Original change's description: > > Remove ENTER_V8_DO_NOT_USE usage from other macros > > > > Eventually I want to delete that macro, so just inline it at the places > > where we'll need to keep it. > > > > BUG=v8:5830 > > R=marja@chromium.org > > > > Change-Id: I904a1dd3555c23c69e457e078faaaa86a9514932 > > Reviewed-on: https://chromium-review.googlesource.com/518043 > > Reviewed-by: Marja Hölttä <marja@chromium.org> > > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45561} > > NOTRY=true > NOTREECHECKS=true > NOPRESUBMIT=true > > TBR=marja@chromium.org,jochen@chromium.org > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > BUG=v8:5830 > > Change-Id: I7097597d2695980f71fc93a79999d59956dd76c9 > Reviewed-on: https://chromium-review.googlesource.com/518107 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45578} TBR=machenbach@chromium.org,marja@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=v8:5830 Change-Id: I148f2415249c4f2a554229f814ae46688acc3918 Reviewed-on: https://chromium-review.googlesource.com/518111Reviewed-by:
-
Jochen Eisinger authored
Original change's description: > Get rid of PREPARE_FOR_EXECUTION_WITH_ISOLATE > > Replace the macro with more generic macros expanding to the same > code. > > BUG=v8:5830 > R=marja@chromium.org > > Change-Id: Ibf31fa4d89960a025af859198e190910c5608a20 > Reviewed-on: https://chromium-review.googlesource.com/518006 > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45560} TBR=marja@chromium.org BUG=v8:5830 Change-Id: I5492286bde4532ad092ac36bd54d99583844ada1 Reviewed-on: https://chromium-review.googlesource.com/518110 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Michael Achenbach authored
V8-side for https://chromium-review.googlesource.com/c/517949/ NOTRY=true NOTREECHECKS=true Bug: chromium:724486 Change-Id: Id778b5b0483bf917cf903d86289c1637ab9edda4 Reviewed-on: https://chromium-review.googlesource.com/518164 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#45581}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ff6a082..e840a06 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Ie172612a3753a11ef85b4762b0e3f12891e040ad Reviewed-on: https://chromium-review.googlesource.com/517727Reviewed-by:
-
- 29 May, 2017 4 commits
-
-
Michael Achenbach authored
This reverts commit 5031f608. Reason for revert: Speculative for: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/8413 Original change's description: > Get rid of PREPARE_FOR_EXECUTION_WITH_ISOLATE > > Replace the macro with more generic macros expanding to the same > code. > > BUG=v8:5830 > R=marja@chromium.org > > Change-Id: Ibf31fa4d89960a025af859198e190910c5608a20 > Reviewed-on: https://chromium-review.googlesource.com/518006 > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45560} NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true TBR=marja@chromium.org,jochen@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=v8:5830 Change-Id: I1135da755ec78d756edcf3dd6da9e94f1768bfb7 Reviewed-on: https://chromium-review.googlesource.com/518108Reviewed-by:
-
Michael Achenbach authored
This reverts commit 2ba1fcda. Reason for revert: Speculative for: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/8413 Original change's description: > Remove ENTER_V8_DO_NOT_USE usage from other macros > > Eventually I want to delete that macro, so just inline it at the places > where we'll need to keep it. > > BUG=v8:5830 > R=marja@chromium.org > > Change-Id: I904a1dd3555c23c69e457e078faaaa86a9514932 > Reviewed-on: https://chromium-review.googlesource.com/518043 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45561} NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true TBR=marja@chromium.org,jochen@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=v8:5830 Change-Id: I7097597d2695980f71fc93a79999d59956dd76c9 Reviewed-on: https://chromium-review.googlesource.com/518107 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
kschimpf authored
Add histogram to track sizes of share array buffers in Wasm/Js. Associated with Chrome CL: https://codereview.chromium.org/2898953003 BUG=chromium:725309 Review-Url: https://codereview.chromium.org/2902773002 Cr-Commit-Position: refs/heads/master@{#45577}
-
kschimpf authored
By moving StatsTable from class Isolate to class Counters, it make the class StatsTable thead safe. This is needed because these two classes call each other, and for background compilation, instances of the Counters class can persist longer that the corresponding Isolate it came from. It also removes unnecessary hops to the the Isolate, and checks if the StatsTable has been created, for these communications. BUG=v8:6361 Review-Url: https://codereview.chromium.org/2906063002 Cr-Commit-Position: refs/heads/master@{#45576}
-
