- 22 May, 2018 5 commits
-
-
Sigurd Schneider authored
This CL re-uses pipeline naming for --trace-turbo phase naming. Bug: v8:7327 Change-Id: I87efb01170ed5d3add7a79c9f38542e9cba6c493 Reviewed-on: https://chromium-review.googlesource.com/1064237 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53276}
-
Michael Achenbach authored
This migrates test configs for all remaining trybots. All migrated builders are not on CQ, hence, they don't run regularly. Therefore, some shard configs are too low by now and are also upgraded in this CL to match their CI counterparts. This also sets the --gc-stress flag for all tests on gc stress builders explicitly, since the infra-side configuration (which sets it per builder) will be deleted soon. NOTRY=true Bug: chromium:830557 Change-Id: Id8a9505fcd2c848ec659c7401cbbe9224feaf5d2 Reviewed-on: https://chromium-review.googlesource.com/1065674Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53275}
-
Michael Lippautz authored
This is to allow testing object stats collection. No-try: true Bug: v8:7760 Change-Id: I1e5318f18bfb3799b90c0ee0aec6df87a794b32c Reviewed-on: https://chromium-review.googlesource.com/1065478 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53274}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d28bd70..b5df251 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1d08c64..49edbd3 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/679372d..c893c7e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I37f185f145ee138d152758376da38fd12d322673 Reviewed-on: https://chromium-review.googlesource.com/1067992 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#53273}
-
Jakob Kummerow authored
ToDirectStringAssembler::PointerToData returns a raw pointer, which is invalidated when GC moves the original string and hence must not be accessed after any allocations. This fixes the bug introduced in b4ebbc57 / r53260. Bug: chromium:845060 Tbr: jgruber@chromium.org Change-Id: I248d0dd2a275bf9308269b3f65d00c4c4c3d4292 Reviewed-on: https://chromium-review.googlesource.com/1068213 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#53272}
-
- 21 May, 2018 3 commits
-
-
Mathias Bynens authored
The ECMAScript ⊃ JSON proposal shipped in V8 v6.6 and Chrome 66. Bug: v8:7418 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id8979d0cec6d61ef4a7e9982142a3f3dcf7c326b Reviewed-on: https://chromium-review.googlesource.com/1067857Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53271}
-
Mathias Bynens authored
The ECMAScript ⊃ JSON proposal doesn’t affect LineContinuation grammar. These tests verify that the behavior remains the same when the --harmony-subsume-json feature flag is enabled. Bug: v8:7418 Change-Id: Iec5cb1bc112f278481ba1202f0c2b8693917843a Reviewed-on: https://chromium-review.googlesource.com/1067463Reviewed-by:
-
Peter Marshall authored
It seems that the output on snapshot failure has changed, so failed snapshots were no longer being automatically re-run in gdb. Change-Id: I321a6055b5683db31d215b9c30827f4badca3df7 Reviewed-on: https://chromium-review.googlesource.com/1066058Reviewed-by:
-
- 20 May, 2018 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a071784..d28bd70 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/669dcb1..1d08c64 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I270b86ba6f048eeaa8e77658c0b1a14b7fd1621a Reviewed-on: https://chromium-review.googlesource.com/1067123Reviewed-by:
-
- 19 May, 2018 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0676f76..a071784 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/78fd930..669dcb1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3f0591d..083eb25 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/b0e0b84..f61e46d Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a67a084..679372d Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/8822987..833f5eb TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I46b469b09b81ad3106ae4526d2996d2babec080a Reviewed-on: https://chromium-review.googlesource.com/1066895Reviewed-by:
-
- 18 May, 2018 26 commits
-
-
Aseem Garg authored
R=gdeepti@chromium.org,bbudge@chromium.org,clemensh@chromium.org,titzer@chromium.org BUG=v8:6020 Change-Id: I25676d4f8a7ea7b1e02a54abe009faec0eb2c6db Reviewed-on: https://chromium-review.googlesource.com/1018840 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53266}
-
Vincent Belliard authored
Bug: v8:6600 Change-Id: I64ab212badf1b54d3e50466b74b30eb2866fbc9e Reviewed-on: https://chromium-review.googlesource.com/1060345Reviewed-by:
-
Sathya Gunasekaran authored
This is not web compatible, so let's delete the code. Bug: v8:5536 Change-Id: I50506d37dcdff1f7f95577c47adcec653cc1f06e Reviewed-on: https://chromium-review.googlesource.com/1064740 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53264}
-
Vincent Belliard authored
For AArch64, clean correctly the pools when the compilation is aborted Bug: v8:6600 Change-Id: I4bacdbeae49290ece0ce1bf47319bf7076fec37c Reviewed-on: https://chromium-review.googlesource.com/1066151 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
This requires changing the way stubs and builtins are encoded in tags, as for arm64 we only have 26 bits to encode a PC-relative offset. With the previous encoding scheme the builtin ids were shifted by 16 bits and ended up exceeding this range. Change-Id: I0f396390a622ea67b890d2dd47ca12e00092e204 Reviewed-on: https://chromium-review.googlesource.com/1059209 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Georg Neis authored
Command-line flags can be parsed in two modes. In the mode used by Chrome, an unrecognized flag causes the remaining arguments to be ignored. This is different from how d8 parses flags. Example: 1) d8 --enable-slow-asserts --trace-ic 2) content_shell --js-flags='--enable-slow-asserts --trace-ic' Assuming we compiled without ENABLE_SLOW_DCHECKS, in (1) we get a warning that --enable-slow-asserts is unknown. Nevertheless, --trace-ic will be enabled. In (2), we get an error that --enable-slow-asserts is unknown but --trace-ic will NOT be enabled (and neither does content_shell abort). This inconsistency is obviously very confusing. With this CL, we will at least print any flags that got ignored. Change-Id: I22bdb06d2b0accc234b3f5d596458809de364bce Reviewed-on: https://chromium-review.googlesource.com/1066010 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53261}
-
Choongwoo Han authored
Optimize String.p.split for the case when the separator is empty and the subject is a direct one-byte string. Bug: v8:7103 Change-Id: Ica277d2c426679a1f77a1ef8ecb523bd596f65fb Reviewed-on: https://chromium-review.googlesource.com/1045950 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Shortcuts e and c select (and make visible) the next effect/control node downwards in the chain; ALT+e/c moves upward. Additionally, the graph bounding box is redetermined every time the graph is redrawn (instead of only when relayouted). Bug: v8:7327 Change-Id: If01b16fc25273703e25e429bdc36753a2fa87f7c Reviewed-on: https://chromium-review.googlesource.com/1064210 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This also includes the precise reducer name. Currently the information is available in the node tooltip in turbolizer. The new shortcut 's' in the graph view selects the nodes the currently selected nodes were created from. Bug: v8:7327 Change-Id: I7ca7327d0cfa112972e3567df6e4a223c8eff3c0 Reviewed-on: https://chromium-review.googlesource.com/1064059 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Georg Neis authored
R=sigurds@chromium.org Change-Id: Ieb73e6b573f2721e62b1c2bc216c26f8b9d38837 Reviewed-on: https://chromium-review.googlesource.com/1065970Reviewed-by:
-
Clemens Hammacher authored
When processing imports of an instance, we were storing pointers to exported (and re-imported) wasm functions in the code table of the importing module. This is dangerous since imports are instance specific. Avoid ever storing call targets for imports in the NativeModule. Instead, read the call targets from the imports table of the instance. R=mstarzinger@chromium.org Bug: chromium:843563 Change-Id: Id9f43a6c127025a5feaa81b2be75c001bc0bea81 Reviewed-on: https://chromium-review.googlesource.com/1065774 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53256}
-
Ivica Bogosavljevic authored
Change-Id: Ie52c6793736f38d1ab1f323b856f36587c46e7f9 Reviewed-on: https://chromium-review.googlesource.com/1059773Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#53255}
-
Clemens Hammacher authored
The js-to-wasm wrappers are shared across instances, so we cannot directly call the instance-specific wasm-to-js wrappers. Instead, we need to call via the import table. R=titzer@chromium.org Bug: chromium:843563 Change-Id: Ia882604f6769472fe2eb69176cbed728215ced29 Reviewed-on: https://chromium-review.googlesource.com/1064610Reviewed-by:
-
Michael Achenbach authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/03f39fd..0676f76 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/e754647..94288c2 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d8600cc..78fd930 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8de3800..ed1bb34 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/045e7f9..08d5b1f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I2d370b3e6c8601d104e7a34d6a68d489092fa2db Reviewed-on: https://chromium-review.googlesource.com/1062816Reviewed-by:
-
Daniel Clifford authored
Fixes known issue that specialization doesn't rigorously checked to verify that specialization signature precisely matches generic declaration. Change-Id: I884f7f16a467ab716d2b0c553485f4b1c55ed806 Reviewed-on: https://chromium-review.googlesource.com/1063613Reviewed-by:
-
Jungshik Shin authored
ICU 61.1 was released in late March with CLDR 33. Arabic number format change in CLDR 33 requires a small adjustment in the test result. See https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1041578 for details on ICU 61.1. NOTREECHECKS=true Bug: chromium:838383, chromium:843073 Test: test262/intl402/*, intl/* Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I3778423b7dc67891767c95ea503e003013ae5b69 Reviewed-on: https://chromium-review.googlesource.com/1038230 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53251}
-
Clemens Hammacher authored
Drive-by: Fix some accessor definitions. R=mstarzinger@chromium.org Change-Id: I2457ac76c376d1e6ffcc19255e669cc7a9732883 Reviewed-on: https://chromium-review.googlesource.com/1063972Reviewed-by:
-
Igor Sheludko authored
Bug: v8:6949, v8:7754, chromium:844200 Change-Id: I0d0d0d7931ac2d560c219ab22ff3df93007f6dad Reviewed-on: https://chromium-review.googlesource.com/1065876Reviewed-by:
-
Michael Achenbach authored
TBR=yangguo@chromium.org Bug: v8:7771 Change-Id: I81f1bdf2b4fffceef9cc4cb3ad9f3713a873e38e Reviewed-on: https://chromium-review.googlesource.com/1065874Reviewed-by:
-
Clemens Hammacher authored
R=vogelheim@chromium.org Bug: v8:6600 Change-Id: I7e8abdbbde312a42898486b88791ba8f7558cfc4 Reviewed-on: https://chromium-review.googlesource.com/1065770Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53247}
-
Mike Stanton authored
Making it into more "idiomatic" Torque code (we are still defining what that means). Template specialization on double and fast fixed arrays allowed me to cut down on the boilerplate. Bug: v8:7672 Change-Id: Ia35706993a9e2ea087ecc3ef93b3a5864ec97827 Reviewed-on: https://chromium-review.googlesource.com/1064054 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#53246}
-
Théotime Grohens authored
Change-Id: I79e4ad1cf41ea8888bf6288690203d746a7b7864 Reviewed-on: https://chromium-review.googlesource.com/1065811Reviewed-by:
-
Peter Marshall authored
This was set very regularly in FillFunctionInfo, but it was almost always set to kNoReason, because the associated SFI had no bailout reason. Given that having a bailout reason is the rare case, we just assume an empty bailout reason, and use the rare_data_ struct to store the string pointer if we do need it. This saves another pointer of space on the CodeEntry object (approx 1.4 MiB on the node server example). Bug: v8:7719 Change-Id: I8e2272b572285ddf353ba0b303e6da095b7d5272 Reviewed-on: https://chromium-review.googlesource.com/1064370 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#53244}
-
jgruber authored
Long timezone names overflowed the timezone cache which had a static length of 100. This uses dynamically allocated std::strings as backing stores instead. Bug: chromium:842085 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I3da474c8b7c530b0933018c6239021979c320043 Reviewed-on: https://chromium-review.googlesource.com/1064111Reviewed-by:
-
Ivica Bogosavljevic authored
TEST=mjsunit/es6/math-fround,mjsunit/unicodelctest Change-Id: I0558772bcb72122c8b58a71ec20f6894b3468d60 Reviewed-on: https://chromium-review.googlesource.com/1064119Reviewed-by:
Miran Karić <miran.karic@mips.com> Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Cr-Commit-Position: refs/heads/master@{#53242}
-
Marja Hölttä authored
This reverts commit c063e3f0. Reason for revert: https://bugs.chromium.org/p/v8/issues/detail?id=7768 Original change's description: > [in-place weak refs] Replace WeakCells in FeedbackVector. > > BUG=v8:7308 > > Change-Id: I08b97f7f47e2d96e313b70a66cd890fedd46e9fb > Reviewed-on: https://chromium-review.googlesource.com/1049606 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53233} TBR=ulan@chromium.org,marja@chromium.org,leszeks@chromium.org,tebbi@chromium.org,ishell@chromium.org Change-Id: I68c068883884f9311ff166306245d0f21693bb6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Reviewed-on: https://chromium-review.googlesource.com/1065631Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#53241}
-
- 17 May, 2018 4 commits
-
-
Vasili Skurydzin authored
Change-Id: Ide53d314da54fa8b88d2b182627fa4c406250906 Reviewed-on: https://chromium-review.googlesource.com/1062410Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53240}
-
Clemens Hammacher authored
We need to change WasmExportedFunction to call imported functions via the import table, so there will be no embedded call target. This also removes the necessity to generate an unreachable call after the runtime call for js-incompatible signatures. R=titzer@chromium.org Bug: chromium:843563,v8:6668 Change-Id: I82cb31930f6b61ad59fde63a8c5ae631da3d1a14 Reviewed-on: https://chromium-review.googlesource.com/1063771 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit d169622f. Reason for revert: setdep bug should be fixed Original change's description: > Revert "[release] Switch auto-roller to gclient setdep" > > This reverts commit a9f5dd30. > > Reason for revert: > Temporarily use legacy method until https://crbug.com/843917 is fixed. > > Original change's description: > > [release] Switch auto-roller to gclient setdep > > > > NOTRY=true > > > > Bug: chromium:828745 > > Change-Id: I051f57893937796e01f0b823f1050dd36e0fbfd9 > > Reviewed-on: https://chromium-review.googlesource.com/997556 > > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#52385} > > TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > NOTRY=true > > Bug: chromium:843917 > Change-Id: I69978ba55ffa5996101e1d31bdf10364b7ef273f > Reviewed-on: https://chromium-review.googlesource.com/1064130 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53230} TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia70dc1df7e25e0c8ffd3fafeb97830b5d5f87336 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:843917 Reviewed-on: https://chromium-review.googlesource.com/1064413Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7490 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I83061dac1b255b239738f900b5149828bd2203ec Reviewed-on: https://chromium-review.googlesource.com/1061496Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#53237}
-
