1. 30 Jan, 2019 1 commit
  2. 28 Aug, 2018 1 commit
    • Michael Starzinger's avatar
      [wasm] Fix crash during exception stack unwinding. · dd40b333
      Michael Starzinger authored
      This fixes a crash with a predicate used during stack unwinding of
      WebAssembly frames during exception handling. The predicate caused an
      observable side-effect in JavaScript during unwinding, code that is
      inherently unhandlified and is not allowed to be observable.
      
      The fix actually just removes the entire predicate. This is because the
      updated proposal causes all JavaScript exceptions to participate in
      WebAssembly exception handling, allowing modelling of "finally" language
      constructs to perform cleanup independent of the embedders exception
      details.
      
      R=ahaas@chromium.org
      TEST=mjsunit/regress/wasm/regress-8095
      BUG=v8:8095
      
      Change-Id: Ic03bc45e7b7f4562a431ccf910ee9ddcf558aa48
      Reviewed-on: https://chromium-review.googlesource.com/1193445Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55457}
      dd40b333