- 10 Jul, 2020 36 commits
-
-
Ng Zhi An authored
- was missing an import sys - check for long - check for xrange This file is now flake8 warning free, and should work on both Py2 and Py3. $ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics Bug: v8:8594 Change-Id: Iae857f4686bcad509fa700954b7f30f86150739f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288177Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68809}
-
Igor Sheludko authored
... by migrating old-style code MyObject* obj = new (zone) MyObject(...) to the new style MyObject* obj = zone->New<MyObject>(...) Bug: v8:10689 Change-Id: I55c686bbedfa1fd1955a5927df3f72b366312fd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288867 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68808}
-
Leszek Swirski authored
Rather than marking deleted GlobalDictionary entries with a "The Hole" valued PropertyCell, we now remove those PropertyCells entirely and use the standard HashTable deleted item marker (also the Hole). This comes with several simplifications: 1) We no longer need a customizable IsKey method on HastTable shapes, which was only used by GlobalDictionary to mark "The Hole" cells as not real keys, 2) We can get rid of IsLive/IsKey from the Shape entirely, and define it directly in the HashTable, which will also allow us (in the future) to encourage caching of "undefined" and "Hole" where used for IsKey checks, 3) PropertyCell invalidation doesn't necessarily have to allocate a new replacement cell (specifically, on deletion), nor does it have to deal with cells that contain the Hole, 4) kNeedsHoleCheck is renamed to kMatchNeedsHoleCheck (to be explicit that this is only needed to guard IsMatch, which may do an indentity comparison and thus not need the HoleCheck guard). It's also moved out of BaseShape and into the various shapes that define IsMatch, to make them more explicitly think about the value, 5) Modified some while loops into for loops to allow clearer use of "continue" on successful hole checks. Change-Id: If591cbb6b49d59726bdc615413aba4f78fd64632 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2292230 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#68807}
-
Ng Zhi An authored
This implements v128.const for ia32, x64, arm, and arm64. Moves one of the test case under the correct header. Bug: v8:9909 Change-Id: I93eb179ac5fd0bc22e3dd5277f7d73699ac8b452 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290623 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68806}
-
Leszek Swirski authored
The map of the HashTable is more a property of the HashTable than part of its shape, so we can move its static map getter (for construction) to to HashTable class itself. Change-Id: I73f4aa7260d6ce749ef51961767fd37d1ab520e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289782 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: I43384d10805b62745a4bc19fa0a4174e6ee94f0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289777 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... by migrating old-style code MyObject* obj = new (zone) MyObject(...) to the new style MyObject* obj = zone->New<MyObject>(...) Bug: v8:10689 Change-Id: Iec2b3102bd35ad7e50b90882ade78d27999a71f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288866Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#68803}
-
Victor Gomes authored
The CallWithSpread builtin actually receives a variable number of arguments. This is necessary when running with the arguments reversed in the stack (v8_enable_reverse_jsargs). Change-Id: I57f67cbef4f2eb7dbb7c245b9a070c3b44d1bfce Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2292233 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Gus Caplan authored
This allows `new (Pretenured) X{}` to force a pretenured allocation. Bug: v8:7793 Change-Id: Ib09f186b3b503b9b23291c39c1390f120d25eebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288409 Commit-Queue: Gus Caplan <me@gus.host> Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68801}
-
Clemens Backes authored
This removes a loop that runs exactly one or two times by straight-line code for the two cases. This should make it more readable and easier to maintain. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I242bc4a7f7333b04ec39e79dc530625fb5e2305f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287505Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68800}
-
Clemens Backes authored
We often want to pass a list of moves of fixed length. Instead of constructing an array on the caller's stack and passing it via {ArrayVector}, we should just pass it via {std::initializer_list}. This also avoids to spell out the internal name {LiftoffAssembler::ParallelRegisterMoveTuple}. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: Ibe7ac5a5a02686533333cb45652cbb2b99ad9c60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287498 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Victor Gomes authored
This change has no impact. It only changes the order of the arguments when using v8_enable_reverse_jsargs. Change-Id: I6063da3703f0fa4a2b790e4291727dd7ff460dfa Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2292232Reviewed-by:
-
Santiago Aboy Solanes authored
Since we are not using CodeAssemblerVariables anymore, we can properly scope the class so that the only way to instance one is through the typed version (i.e TypedCodeAssemblerVariable). Bug: v8:6949 Change-Id: I3ee99bcbb9421aadd0944af57f6452e832719758 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290858 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#68797}
-
Omer Katz authored
This will be needed later for concurrent marking Bug: chromium:1056170 Change-Id: Iab7812d7ac8a30e3a54bd7c4b739077b293db775 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287869 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68796}
-
Zeynep Cankara authored
This CL attempts to change change content and change format to increase accessibility. Bug: v8:10664 Change-Id: Ic80e00310884ac64dc99fe053354250671cabfdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290859Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#68795}
-
Zeynep Cankara authored
This CL attempts to encapsulate Statistics gathered to a separate custom web component. Screenshots: https://imgur.com/a/xlffxDE Bug: v8:10667 Change-Id: I37816a4fe3d37f2b042d05a7110eda04af303fbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287506Reviewed-by:
-
Milad Farazmand authored
Port 34871edd Original Commit Message: Partial implementation of v128.const, only the optimized case for all 0s and all 1s. The other cases bailout to TurboFan for now, and will be added in subsequent patches. R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I948380f0859b49bcc5a55d239b24a93b1cd5fd04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2292113Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68793}
-
Igor Sheludko authored
... by migrating old-style code MyObject* obj = new (zone) MyObject(...) to the new style MyObject* obj = zone->New<MyObject>(...) Bug: v8:10689 Change-Id: I79fc4f9793a0c7a3bd38230ca4e23d33344fc1b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288863Reviewed-by:
-
Igor Sheludko authored
... by migrating old-style code MyObject* obj = new (zone) MyObject(...) to the new style MyObject* obj = zone->New<MyObject>(...) Bug: v8:10689 Change-Id: I8293cc1854e39726eb9e4e5f9d2a34d38fa54859 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288861Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:6949 Change-Id: I8bd989ffce16b05e7cc37a35da9c2912090f60ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290857Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68790}
-
Igor Sheludko authored
... by migrating old-style code MyObject* obj = new (zone) MyObject(...) to the new style MyObject* obj = zone->New<MyObject>(...) Bug: v8:10689 Change-Id: I2fc4a44ea05e4d087565811f343893f0e97dc660 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288857 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... by migrating old-style code MyObject* obj = new (zone) MyObject(...) to the new style MyObject* obj = zone->New<MyObject>(...) Bug: v8:10689 Change-Id: Iea6c1225ee672035763d8141292a40874658d270 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288864 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#68788}
-
Omer Katz authored
This CL removes the GetTraceDescriptor virtual call from garbage collected mixins and replaces it with querying the object start bitmap. The CL also removes the mixin macros which are now no longer needed. Bug: chromium:1056170 Change-Id: I27ed299f93025d09a3bb3f0d17b14bed3c200565 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287508Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68787}
-
Igor Sheludko authored
... by migrating old-style code MyObject* obj = new (zone) MyObject(...) to the new style MyObject* obj = zone->New<MyObject>(...) Bug: v8:10689 Change-Id: Ic7d893b8d6772bd923c37c3d1e7cff5cc6667192 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288868 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This is a reland of bebb2bdc Original change's description: > [heap] Allow LocalHeap on the main thread > > This changes the safepoint scope to skip LocalHeap that is active > for the current thread to avoid deadlocking. > > Bug: v8:10315 > Change-Id: I45e80ae66d0dbbe768107aa9cf0603204c644d9f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289983 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68769} Bug: v8:10315 Tbr: dinfuehr@chromium.org Change-Id: I1974d8b6ffffbf3244e7ede2d20d9b2d623df150 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290851 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68785}
-
Igor Sheludko authored
... by migrating old-style code MyObject* obj = new (zone) MyObject(...) to the new style MyObject* obj = zone->New<MyObject>(...) Bug: v8:10689 Change-Id: Icc60fdbf247ec05f9b5688b3d2d73d4fed06ea89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289770 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68784}
-
Ulan Degenbaev authored
Instead allocating the bitmap with malloc, we now reserve a block at the start of the memory chunk. This CL is a partial revert of https://chromium-review.googlesource.com/c/v8/v8/+/1254125 Additionally it refactors field offset computation and moves them to MemoryChunkLayout. Having the bitmap in the memory chunk simplifies sharing of RO pages and also solves the malloc fragmentation issues. Bug: chromium:1073140 Change-Id: Ibc04f48921fc9496370858ce4c25c56b31c93c89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289979 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Clemens Backes authored
Saturating conversions are implemented on all platforms now, so remove the (unreachable) bailout. Also, move the new cases up to the other macros, such that the indentation (by clang-format) makes more sense. R=rstz@chromium.org, thibaudm@chromium.org Bug: v8:10520 Change-Id: Ia44a4852a087b0a2c19b3d62aebd73c834fa9af9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289982Reviewed-by:
-
Igor Sheludko authored
This will allow implementing per-type allocation stats. Also migrate old-style zone allocations ... = new (zone) MyObject(...) to the new style: ... = zone->New<MyObject>(...) in several source files. Bug: v8:10689 Change-Id: I1b044c9eccb4ac7e1b627276691f3c1fbad52137 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288232 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68781}
-
Peter Marshall authored
Change-Id: Iceaba4dcb9f3bc457e03735a94b615764757a635 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290854 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#68780}
-
Ulan Degenbaev authored
PersistentHandles::NewHandle/LocalHeap::NewPersistentHandle currently erase the type of the object. This patch templatizes them to preserve the type and introduces versions that take Handle<T> Bug: v8:10315 Change-Id: I899179a5b842b7b16144b340f6cd2b91e1db228f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287501 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#68779}
-
Omer Katz authored
This CL ports the atomic object start bitmap from blink. Using the bitmap for mixin tracing is left as a followup. Bug: chromium:1056170 Change-Id: I4998a0d9d76708a7bab0634e04354809dfc8c78f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287504Reviewed-by:
-
Ulan Degenbaev authored
The test creates a mock platform. The bug was that the lifetime of the mock platform was shoter than the lifetime of the isolate. Even though the mock platform restores the old platfrom, a background thread may still have a pointer to the mock platform leading to UAF. Bug: v8:10690 Tbr: dinfuehr@chromium.rg Change-Id: Ic14bf408e5e3e9e7d07e01af545bb88c21462300 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290850Reviewed-by:
-
Igor Sheludko authored
... and introduce a bottleneck for collecting reusable zone memory statistics. Tbr: jgruber@chromium.org Bug: v8:10572 Change-Id: I418f8b495c0d89c0eb73f4e19bc4315acfadb480 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287500Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#68776}
-
Jakob Kummerow authored
This reverts commit 8ba517e1. Reason for revert: causing Chromium test failures on external/wpt/wasm/jsapi/functions/entry-different-function-realm.html, e.g. here: https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Mac/3045 Original change's description: > [wasm] Make an "incumbent context" available for module instantiation > > A Wasm module's start function might be imported from JavaScript, and > as such might contain calls to Blink. For such a case, we must make > sure that an "incumbent context" is available. > See microtask queue handling for a similar example. > > Bug: chromium:1096558 > Change-Id: I2e3c0fc20d4e3581e490822c3ac63ce2c5e1e990 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284982 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68760} TBR=jkummerow@chromium.org,verwaest@chromium.org Change-Id: Ib36d2198cf686f561a2a64034faf0479686f3500 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1096558 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290853Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2f694ac..3fd005e Rolling v8/third_party/aemu-linux-x64: Y1_xyAnxWY49mUT2otmospCKTrX01gsjJxt9x-qV0RsC..s9pb0zCLuc3Aj9A3n8IG3qBVpc2wOmQ1A32bDtG1idwC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5d5af4e..e4221b4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6402141..9af33fa Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/77b632f..21dcb28 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3836af60d3bd8673de45d391815fc02aaa6980e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290712Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68774}
-
- 09 Jul, 2020 4 commits
-
-
Frank Tang authored
Bug: v8:10686 Change-Id: I5a7b47dd4ed10142a795de56c4739ab072e63421 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2286814 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Partial implementation of v128.const, only the optimized case for all 0s and all 1s. The other cases bailout to TurboFan for now, and will be added in subsequent patches. Bug: v8:9909 Change-Id: I3240c1c5f4259c45d51edca00fec37047bc1b3a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284212 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
Change-Id: I256c351bea62fede28f6cfaa0be149729abffbd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2271132Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Bill Budge authored
This reverts commit bebb2bdc. Reason for revert: Breaks GarbageCollectionWithLocalHeap test. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/31107 Original change's description: > [heap] Allow LocalHeap on the main thread > > This changes the safepoint scope to skip LocalHeap that is active > for the current thread to avoid deadlocking. > > Bug: v8:10315 > Change-Id: I45e80ae66d0dbbe768107aa9cf0603204c644d9f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289983 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68769} TBR=ulan@chromium.org,dinfuehr@chromium.org Change-Id: Ifba8218f9104afed3f2d92258296067f8f424062 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290573Reviewed-by:
-
