- 24 May, 2016 9 commits
-
-
danno authored
BUG=chromium:608675 LOG=n Review-Url: https://codereview.chromium.org/1987183002 Cr-Commit-Position: refs/heads/master@{#36463}
-
ahaas authored
The {force_promotion} flag causes the scavenger to move an object to the old generation instead of to the other semi-space. We use the flag to force the promotion of objects which are referenced by code objects. R=ulan@chromium.org Committed: https://crrev.com/f2a7ba6449406d0b11a245aa1f5b4981265b6f20 Cr-Commit-Position: refs/heads/master@{#36443} Review-Url: https://codereview.chromium.org/2002013002 Cr-Commit-Position: refs/heads/master@{#36462}
-
mlippautz authored
Revert of [heap] Fine-grained JSArrayBuffer tracking (patchset #19 id:770001 of https://codereview.chromium.org/1964023002/ ) Reason for revert: Revert it. Original issue's description: > [heap] Fine-grained JSArrayBuffer tracking > > Track based on JSArrayBuffer addresses instead of the attached backing store. > This way we can later on iterate buffers on a single page. The reland also > switches to a page-based implementation where a page contains the set of its > contained (live and dead) buffers. > > Details of tracking: > - Scavenge: New space pages are processes in bulk on the main thread > - MC: Unswept pages are processed in bulk in parallel. All other pages > are processed by the sweeper concurrently. > > BUG=chromium:611688 > LOG=N > CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel > > Committed: https://crrev.com/b2d8bfc7931eef49d527605ba485950dea41cde3 > Cr-Commit-Position: refs/heads/master@{#36437} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:611688 Review-Url: https://codereview.chromium.org/2006183003 Cr-Commit-Position: refs/heads/master@{#36461}
-
mlippautz authored
Revert of [heap] Pass a force_promotion flag to the evacuation routine in the scavenger. (patchset #3 id:40001 of https://codereview.chromium.org/2002013002/ ) Reason for revert: Need to revert JSArrayBuffer change. Please rebase and reland. Original issue's description: > [heap] Pass a force_promotion flag to the evacuation routine in the scavenger. > > The {force_promotion} flag causes the scavenger to move an object to the > old generation instead of to the other semi-space. We use the flag to force > the promotion of objects which are referenced by code objects. > > R=ulan@chromium.org > > Committed: https://crrev.com/f2a7ba6449406d0b11a245aa1f5b4981265b6f20 > Cr-Commit-Position: refs/heads/master@{#36443} TBR=ulan@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2007563004 Cr-Commit-Position: refs/heads/master@{#36460}
-
ishell authored
BUG=chromium:612076 LOG=N Review-Url: https://codereview.chromium.org/2005763002 Cr-Commit-Position: refs/heads/master@{#36459}
-
jgruber authored
Script position calculation logic (i.e. line & column numbers for a given code position) is now based on a single method Script::GetPositionInfo(). Refactored related code in isolate.cc and js/messages.js to use the new method. The line_ends accessor is still in use by chromium and thus cannot be removed yet. R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2002993002 Cr-Commit-Position: refs/heads/master@{#36458}
-
bmeurer authored
R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2004933003 Cr-Commit-Position: refs/heads/master@{#36457}
-
zhengxing.li authored
X87: Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. (patchset #1 id:1 of https://codereview.chromium.org/1968453002/ ). port 767c34df (r36413) original commit message: Reason for revert: Breaks a KCS demo: BUG=chromium:611976 Original issue's description: > [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. > > Trying to re-land http://crrev.com/1948453002 after fixing assembler-x64.cc in http://crrev.com/1962563003. > > Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use > > Committed: https://crrev.com/2da70f853d7f680d491c37c72d5ef04a85497ba9 > Cr-Commit-Position: refs/heads/master@{#36136} Review-Url: https://codereview.chromium.org/2003273002 Cr-Commit-Position: refs/heads/master@{#36456}
-
v8-autoroll authored
Rolling v8/build to 012e6582ccd1302ef1e4553d678bf2771f72aaca TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2007473003 Cr-Commit-Position: refs/heads/master@{#36455}
-
- 23 May, 2016 26 commits
-
-
adamk authored
TBR=yangguo@chromium.org BUG=v8:5036 NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2006133002 Cr-Commit-Position: refs/heads/master@{#36454}
-
yangguo authored
R=littledan@chromium.org BUG=v8:5036 Review-Url: https://codereview.chromium.org/2005753003 Cr-Commit-Position: refs/heads/master@{#36453}
-
Adam Klein authored
It seems to fail in nosnap mode, and runs very slowly with snapshot, so skipping for now to get the tree green. TBR=neis@chromium.org BUG=v8:4907 Review URL: https://codereview.chromium.org/2000313002 . Cr-Commit-Position: refs/heads/master@{#36452}
-
gsathya authored
Previously, certain calls to DebugPushPromise and DebugPopPromise happened always, without any check to see if we were in a debugging environment. This patch adds a conditional check before making these debug calls to make sure they aren't called when not needed. Before the patch, running --prof over the bluebird benchmarks, brings up these unprotected debug calls -- ticks cpp total name 16 6.7% 2.0% v8::internal::Runtime_DebugPushPromise(int, v8::internal::Object**, v8::internal::Isolate*) 7 2.9% 0.9% v8::internal::Runtime_DebugPopPromise(int, v8::internal::Object**, v8::internal::Isolate*) This patch removes the above calls and provides a 4% improvement (with a 2% variance over 10 runs) in the bluebird benchmark. Review-Url: https://codereview.chromium.org/1985293002 Cr-Commit-Position: refs/heads/master@{#36451}
-
adamk authored
Instead of having two lists of harmony flags, one with i18n and one without, use a bit more macro programming. Review-Url: https://codereview.chromium.org/2001753003 Cr-Commit-Position: refs/heads/master@{#36450}
-
yangguo authored
This is in preparation of fully porting JSON.stringify to C++. R=cbruni@chromium.org Review-Url: https://codereview.chromium.org/2006663002 Cr-Commit-Position: refs/heads/master@{#36449}
-
danno authored
BUG=chromium:612412 LOG=N Review-Url: https://codereview.chromium.org/1999783004 Cr-Commit-Position: refs/heads/master@{#36448}
-
ssanfilippo authored
Changes to the Object prototype may cause getIgnitionDispatchCounters() to fail when building the counters table object. Using DefineOwnProperty instead of Set solves the issue by ignoring the prototype chain. BUG=chromium:613567 LOG=N Review-Url: https://codereview.chromium.org/2000203002 Cr-Commit-Position: refs/heads/master@{#36447}
-
danno authored
Previously, split-edge blocks inserted into CodeStubAssembler schedules inherited the "deferredness" of their predecessor block. This tended to inline newly inserted blocks that preceeded deferred code inline with non-deferred code. The stack frame elider sometimes inserted stack construction into these blocks, code which was actually was only needed in the deferred case. This CL marks inserted split edge blocks with the deferredness of their successors, e.g. they are defererred if their predecessor is deferrred. This moves stack building code that logically belongs to deferred code into the deferred code area rather than inlining it in non-deferred code. Review-Url: https://codereview.chromium.org/2003663002 Cr-Commit-Position: refs/heads/master@{#36446}
-
jkummerow authored
This flag has been on by default for a while, along with FLAG_track_prototype_users which provides the prerequisite infrastructure. We are now sure that this is the direction we want to go in, so in order to simplify the code, this CL drops the respective flag-off code paths. Review-Url: https://codereview.chromium.org/1993913002 Cr-Commit-Position: refs/heads/master@{#36445}
-
neis authored
Also use the inlined version of CreateIterResultObject in Ignition's VisitYield. BUG=v8:4907 TBR=littledan@chromium.org Review-Url: https://codereview.chromium.org/2006613002 Cr-Commit-Position: refs/heads/master@{#36444}
-
ahaas authored
The {force_promotion} flag causes the scavenger to move an object to the old generation instead of to the other semi-space. We use the flag to force the promotion of objects which are referenced by code objects. R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2002013002 Cr-Commit-Position: refs/heads/master@{#36443}
-
neis authored
Instead of changing existing nodes in a very fragile (and in one case expensive) way, just create new ones instead. Also properly chain effects, which was not done quite right before. BUG=v8:4907 Review-Url: https://codereview.chromium.org/1997373002 Cr-Commit-Position: refs/heads/master@{#36442}
-
neis authored
Duplicate mjsunit/harmony/generators.js but explicitly require --turbo-from-bytecode such that Clusterfuzz can thoroughly test the new generators implementation. BUG=v8:4907 Review-Url: https://codereview.chromium.org/2002983002 Cr-Commit-Position: refs/heads/master@{#36441}
-
mstarzinger authored
This makes sure the deoptimizer can materialize sloppy arguments objects with the FAST_SLOPPY_ARGUMENTS_ELEMENTS elements kind. TurboFan's escape analysis treates those as normal JSObject types and hence materializes them differently than Crankshaft does. R=verwaest@chromium.org TEST=mjsunit/regress/regress-crbug-613919 BUG=chromium:613919 Review-Url: https://codereview.chromium.org/2001133002 Cr-Commit-Position: refs/heads/master@{#36440}
-
oth authored
The original peephole optimizer logic in the BytecodeArrayBuilder did not respect source positions as it was written before there were bytecode source positions. This led to some minor differences to FCG and was problematic when combined with pending bytecode optimizations. This change makes the new peephole optimizer fully respect source positions. BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/1998203002 Cr-Commit-Position: refs/heads/master@{#36439}
-
oth authored
Add a method to emit abort for code which should not be reachable. BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/2002833005 Cr-Commit-Position: refs/heads/master@{#36438}
-
mlippautz authored
Track based on JSArrayBuffer addresses instead of the attached backing store. This way we can later on iterate buffers on a single page. The reland also switches to a page-based implementation where a page contains the set of its contained (live and dead) buffers. Details of tracking: - Scavenge: New space pages are processes in bulk on the main thread - MC: Unswept pages are processed in bulk in parallel. All other pages are processed by the sweeper concurrently. BUG=chromium:611688 LOG=N CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel Review-Url: https://codereview.chromium.org/1964023002 Cr-Commit-Position: refs/heads/master@{#36437}
-
mstarzinger authored
This makes escape analysis skip analyzing the code entry field within JSFunction objects. Said field is an untagged pointer field and hence cannot be tracked by an ObjectState node. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-613494 BUG=chromium:613494 Review-Url: https://codereview.chromium.org/1997353002 Cr-Commit-Position: refs/heads/master@{#36436}
-
yangguo authored
This is a pure refactoring. R=cbruni@chromium.org Review-Url: https://codereview.chromium.org/2002933002 Cr-Commit-Position: refs/heads/master@{#36435}
-
nexus226 authored
This fixes a syntax error in plot-timer-events script. Before: $ out/x64.release/d8 --prof --log-timer-events script.js $ tools/plot-timer-events v8.log tools/plot-timer-events: 75: tools/plot-timer-events: options+=1343: not found --distortion= Cmdline args: [options] [log-file-name] Default log file name is "v8.log". ... After: $ out/x64.release/d8 --prof --log-timer-events script.js $ tools/plot-timer-events v8.log $ ls timer-events.png timer-events.png BUG= Review-Url: https://codereview.chromium.org/1961873002 Cr-Commit-Position: refs/heads/master@{#36434}
-
yangguo authored
R=mstarzinger@chromium.org BUG=chromium:613570 Review-Url: https://codereview.chromium.org/1997003002 Cr-Commit-Position: refs/heads/master@{#36433}
-
mstarzinger authored
This fixes the Python include path after the GYP files have been relocated into another directory. It only affects 'make native', other targets have been fixed in previous changes already. R=jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2001053003 Cr-Commit-Position: refs/heads/master@{#36432}
-
ahaas authored
R=ulan@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2003553002 Cr-Commit-Position: refs/heads/master@{#36431}
-
ishell authored
... but hit the runtime assert instead. | | Runtime error in ../src/runtime/runtime-internal.cc, line 409 | | call_site.IsJavaScript() || call_site.IsWasm() | BUG=chromium:613905 LOG=N Review-Url: https://codereview.chromium.org/2006603002 Cr-Commit-Position: refs/heads/master@{#36430}
-
Ilija.Pavlovic authored
Port for https://codereview.chromium.org/1409123003 In function Fast_ArrayConcat is added comparation between result_len and FixedDoubleArray::kMaxLength. This change enables successful execution of the test regress-599414-array-concat-fast-path. Original commit message: [runtime] Avoid @@isConcatSpreadable lookup for fast path Array.prototype.concat Currently we do not check for @@isConcatSpreadable properly. If the Symbol is set on the Array.prototype or Object.prototype the current fast paths fail. This CL adds a fix to globally invalidate a isConcatSpreadable_protector. Drive-by-fix: use named accessors for context variables TEST=mjsunit/regress/regress-599414-array-concat-fast-path BUG= Review-Url: https://codereview.chromium.org/1995313002 Cr-Commit-Position: refs/heads/master@{#36429}
-
- 21 May, 2016 5 commits
-
-
bmeurer authored
Address computation on 64-bit platforms must be done in Word64, mixing Word32 here is unsound. TBR=danno@chromium.org Review-Url: https://codereview.chromium.org/1997223002 Cr-Commit-Position: refs/heads/master@{#36428}
-
bmeurer authored
The previous JavaScript version created way too many ConsStrings for longer strings, i.e. when using String.fromCharCode together with Function.prototype.apply and arrays of char codes. This version now always allocates sequential strings and therefore uses way less memory when turning longer character sequences into strings, and therefore fixes the memory regression on Google Maps. BUG=chromium:609831 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2004733002 Cr-Commit-Position: refs/heads/master@{#36427}
-
pierre.langlois authored
This patch changes the disassembly output for ARM64 when tracing compiled code. We used to omit printing the encoding as opposed to what ARM and X64 do. The new turbolizer tool assumes the encoding is printed and gets confused otherwise. This could have been fixed in the tool instead but making disassembly output consistent across architecture seems like a better solution. BUG= Review-Url: https://codereview.chromium.org/1996983003 Cr-Commit-Position: refs/heads/master@{#36426}
-
danno authored
BUG=chromium:613796 LOG=N Review-Url: https://codereview.chromium.org/2002813002 Cr-Commit-Position: refs/heads/master@{#36425}
-
v8-autoroll authored
Rolling v8/build to 298aeabfe2aa544f7be8cab05a133428bca7dea3 Rolling v8/third_party/icu to 54f86bb1d1d02968576d21c16d7134ec35c30fbc TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2005633002 Cr-Commit-Position: refs/heads/master@{#36424}
-