1. 30 Jan, 2019 1 commit
  2. 13 Jul, 2016 1 commit
    • bakkot's avatar
      Reland of Add errors for declarations which conflict with catch parameters.... · 819fe046
      bakkot authored
      Reland of Add errors for declarations which conflict with catch parameters. (patchset #1 id:1 of https://codereview.chromium.org/2112223002/ )
      
      Reason for revert:
      Correcting issue.
      
      Original issue's description:
      > Revert of Add errors for declarations which conflict with catch parameters. (patchset #6 id:100001 of https://codereview.chromium.org/2109733003/ )
      >
      > Reason for revert:
      > Fuzzer claims `try {  \"\" ; } catch(x) { let x1 = [1,,], x = x; }` causes a crash.
      >
      > Original issue's description:
      > > Add errors for declarations which conflict with catch parameters.
      > >
      > > Catch parameters are largely treated as lexical declarations in the
      > > block which contains their body for the purposes of early syntax errors,
      > > with some exceptions outlined in B.3.5. This patch introduces most of
      > > those errors, except those from `eval('for (var e of ...);')` inside of
      > > a catch with a simple parameter named 'e'.
      > >
      > > Note that annex B.3.5 allows var declarations to conflict with simple
      > > catch parameters, except when the variable declaration is the init of a
      > > for-of statement.
      > >
      > > BUG=v8:5112,v8:4231
      > >
      > > Committed: https://crrev.com/2907c726b2bb5cf20b2bec639ca9e6a521585406
      > > Cr-Commit-Position: refs/heads/master@{#37462}
      >
      > TBR=littledan@chromium.org
      > # Skipping CQ checks because original CL landed less than 1 days ago.
      > NOPRESUBMIT=true
      > NOTREECHECKS=true
      > NOTRY=true
      > BUG=v8:5112,v8:4231
      >
      > Committed: https://crrev.com/8834d5ecb559001c87c42322969471da60574a8c
      > Cr-Commit-Position: refs/heads/master@{#37464}
      
      R=littledan@chromium.org
      BUG=v8:5112,v8:4231
      
      Review-Url: https://codereview.chromium.org/2119933002
      Cr-Commit-Position: refs/heads/master@{#37728}
      819fe046
  3. 01 Jul, 2016 2 commits
    • bakkot's avatar
      Revert of Add errors for declarations which conflict with catch parameters.... · 8834d5ec
      bakkot authored
      Revert of Add errors for declarations which conflict with catch parameters. (patchset #6 id:100001 of https://codereview.chromium.org/2109733003/ )
      
      Reason for revert:
      Fuzzer claims `try {  \"\" ; } catch(x) { let x1 = [1,,], x = x; }` causes a crash.
      
      Original issue's description:
      > Add errors for declarations which conflict with catch parameters.
      >
      > Catch parameters are largely treated as lexical declarations in the
      > block which contains their body for the purposes of early syntax errors,
      > with some exceptions outlined in B.3.5. This patch introduces most of
      > those errors, except those from `eval('for (var e of ...);')` inside of
      > a catch with a simple parameter named 'e'.
      >
      > Note that annex B.3.5 allows var declarations to conflict with simple
      > catch parameters, except when the variable declaration is the init of a
      > for-of statement.
      >
      > BUG=v8:5112,v8:4231
      >
      > Committed: https://crrev.com/2907c726b2bb5cf20b2bec639ca9e6a521585406
      > Cr-Commit-Position: refs/heads/master@{#37462}
      
      TBR=littledan@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:5112,v8:4231
      
      Review-Url: https://codereview.chromium.org/2112223002
      Cr-Commit-Position: refs/heads/master@{#37464}
      8834d5ec
    • bakkot's avatar
      Add errors for declarations which conflict with catch parameters. · 2907c726
      bakkot authored
      Catch parameters are largely treated as lexical declarations in the
      block which contains their body for the purposes of early syntax errors,
      with some exceptions outlined in B.3.5. This patch introduces most of
      those errors, except those from `eval('for (var e of ...);')` inside of
      a catch with a simple parameter named 'e'.
      
      Note that annex B.3.5 allows var declarations to conflict with simple
      catch parameters, except when the variable declaration is the init of a
      for-of statement.
      
      BUG=v8:5112,v8:4231
      
      Review-Url: https://codereview.chromium.org/2109733003
      Cr-Commit-Position: refs/heads/master@{#37462}
      2907c726