- 24 Jul, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7e2f4d2..bdbc779 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8bd1a6c205ca1edae9040e1b3a2fca7efed2fc81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315053Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#69029}
-
- 23 Jul, 2020 16 commits
-
-
Michael Lippautz authored
The following adds support for JSMember through the existing GlobalHandles implementation also used for TracedReference. In addition, JSMember now supports set, clear, copy, move, comparison and interaction with Local. Bug: chromium:1056170 Change-Id: Ia50218bcfe4c056b3533a5b14eea954ade1da243 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310357Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#69028}
-
Clemens Backes authored
cmov is often much faster than branches (in particular if the branches cannot be predicted). It also has a much more predictable performance, and is shorter. This CL uses cmov on x64 for now. Other platforms (maybe using other instructions than cmov) can be added later. R=thibaudm@chromium.org Bug: v8:10740 Change-Id: Ifab3d570b8eea784376e1f768d6ba3828efcc01a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315978Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#69027}
-
Dominik Inführ authored
Bug: v8:10315 Change-Id: Ie36035db0a1a2fa32bfec17eca7cf3ed0c91ca29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315991Reviewed-by:
-
Leszek Swirski authored
This is a reland of 6af09b1b Relanding without changes after fixing the root cause in https://crrev.com/c/2315987 Original change's description: > [offthread] Add a write lock to the string table > > Adds an initial implementation of a concurrency support for the string > table, allowing it to be read without holding a lock, and written to > while holding a lock. > > This is an initial prototype of _roughly_ how the concurrency would > work; there are still a few holes (e.g. around deserialization). This > is predominantly to assess the main-thread runtime impact of the more > complex string table access. > > Bug: v8:10729 > Change-Id: I5c6c35e6fca309efd6ee79804c16972aae1ab3ab > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2306804 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68985} Tbr: verwaest@chromium.org,ishell@chromium.org,ulan@chromium.org Bug: v8:10729 Change-Id: I9ce8882cfbdd40fbe1c7478e171c0785bf2e64d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315989 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#69025}
-
Leszek Swirski authored
When an external string matches and internalized external string, we want to deduplicate them. As part of that de-duplication, we check if either a) the internalized string's resource is null (it's freshly created because the original string was in new space) or b) they point to the same data (in which case we don't want to dispose of the data). However, when doing these checks we cast both the initial and the internalized external string to the same type (one or two byte). So, if a two-byte string finds a one-byte internalized string with equivalent data, this cast will fail. Since we only care about the external string resource being null or equal to another during the above deduplication, the solution is casting first to the more general ExternalString type, comparing resources by address, and only casting to the more specific type when needed (and we know that the types have to match by other construction). Change-Id: Id34a02eb1900d8aa492c030488afaffd0d035454 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315987 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit ab7e89f1. Reason for revert: Breaks GCC build - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20gcc%20-%20debug/8442? Original change's description: > [TurboProp] Add PendingOperand for use by fast register allocator. > > Adds a pending operand type for use with the fast register allocator. > These operands chain together multiple operands together, enabling > the allocator to keep track of multiple pending operands, then > replace them all with the allocated operand in one go. > > BUG=v8:9684 > > Change-Id: I5d8150f3f26549a747a2e89e32e31135e89dff9c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2292302 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69019} TBR=rmcilroy@chromium.org,tebbi@chromium.org Change-Id: If689956f873f05bcd920090143769a0d4686d804 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9684 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315992Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#69023}
-
Manos Koukoutos authored
This is to mitigate a binary size increase caused by https://chromium-review.googlesource.com/c/v8/v8/+/2243215. This CL reduces binary size by 102kB. Change-Id: Idd106efab0c2b974b4f90bf6ca3e1c321de06aea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315984Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69022}
-
Clemens Backes authored
The default implementation just returns {nullptr}, which is not a correct implementation. Since we rely on the implementation of {PostJob} since https://crrev.com/c/2301933, and embedders can just use {NewDefaultJobHandle} since https://crrev.com/c/2304812 (backported to 8.5), we should stop providing this dangerous default. R=ulan@chromium.org Bug: v8:10723, v8:10740, chromium:1101340 Change-Id: I6e34c584cbed186ddf6cfa4a9c5a7e8caa3b61c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315981 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Clemens Backes authored
PostJob is used for wasm compilation since https://crrev.com/c/2301933, so all platforms need to implement it. R=ulan@chromium.org Bug: v8:10745, chromium:1101340 Change-Id: Idf88a1305ab3f33ce3980ca7f82d4fc02b0e2443 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315980 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Adds a pending operand type for use with the fast register allocator. These operands chain together multiple operands together, enabling the allocator to keep track of multiple pending operands, then replace them all with the allocated operand in one go. BUG=v8:9684 Change-Id: I5d8150f3f26549a747a2e89e32e31135e89dff9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2292302 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#69019}
-
Jakob Gruber authored
A small step for a JSFunction, one giant leap for V8. Tbr: clemensb@chromium.org Bug: v8:8888 Change-Id: I968bb819763994ec611cde7e502adea30339a387 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315979 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#69018}
-
Anton Bikineev authored
The parser is capable of processing full GN grammar. The generator uses the visitor and the builder patterns. The visitor handles call expressions (e.g. target declarations), GN expressions (e.g. is_clang && !is_win), conditional and assignment statements. Builder is used to generate a particular output. For example, this CL brings in CMakeBuilder for cmake generation, but same infrastructure can be reused for generation of amalgamated sources. Things that are not yet automatically generated: 1) Automatic generation of config variables (from declare_args). 2) Dependency scanning. Since we only have limited number of targets, this is not a big issue at the moment. Followup CLs will include: - test targets; - sample targets. Bug: v8:10724 Change-Id: I0b31910aca67f0e02ab142b2d35f4338345e7f29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2306790 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Anton Bikineev authored
Standalone sample doesn't use libplatform for default platform implementation. This is needed for Oilpan GitHub mirror, which won't contain libplatform. Bug: v8:10724 Change-Id: I2e20ad157263a5073d0ba9ae8a2e211b2fcb35ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310362Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Zeynep Cankara authored
This CL enables the hide panel functionality upon uploading a new file. File reader emits fileuploadstart event when it receives a new file which hides the panels. Bug: v8:10644 Change-Id: Ic26cce1a92559efd494f2ef1e32b514897a73324 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305892 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69015}
-
Zeynep Cankara authored
This CL decouples the timeline panel view handling from map panel view handling. Having separate panel view handling for each panel aims to encapsulate panel behaviours force panels to emit events rather than depending on other panels. Bug: v8:10644, v8:10735 Change-Id: Icd6e8ee8a0e8d1fdbbaaf2754f272300e0499bf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305894 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/87bba5b..7e2f4d2 Rolling v8/third_party/aemu-linux-x64: z8GNdg7f5KxXikavCn-MhfAAg7LXnterp9s7Cgr5_BoC..-zGqW99um_GNQKURMgzhK855VvGi_CfraQRvXhNduEQC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8af044e..b2282fe Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6081b23..cebfb4e TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4ff787b8713bdb8d58613682a63146a5d56b09df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315041Reviewed-by:
-
- 22 Jul, 2020 23 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e2b8e15..87bba5b Rolling v8/third_party/aemu-linux-x64: 53Ps2Qo0mizBNjRI9qS90a_RTYhxglcY6H9yccc0ckcC..z8GNdg7f5KxXikavCn-MhfAAg7LXnterp9s7Cgr5_BoC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a30bbb6..8af044e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9949ab7..6081b23 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6412135..2eaa59d TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2fac70741b4b951b4451720ed3908e081b3cfd0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2314082Reviewed-by:
-
Michael Achenbach authored
This summarizes more dupes of https://crbug.com/1042556 TBR=mslekova@chromium.org No-Try: true Bug: chromium:1108048,chromium:1108322 Change-Id: If572b5eeeac9c2750eb1a630dd76490529e60d4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2314476Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#69011}
-
Ross McIlroy authored
Adds the first phase of the fast register allocator, which runs through the instruction stream and defines a VirtualRegisterData for each virtual register based on how that virtual register is produced. Also adds logic to pipeline.cc to allocate and use FastRegistorAllocatorData for use throughout the fast register allocation phases. BUG=v8:9684 Change-Id: I2f4533467346d5f3fdf50a0a1fedd7e4082f0187 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2295364 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#69010}
-
Frank Tang authored
Bug: chromium:1107661 Change-Id: I6c55fb74bc009d2af2ae00e34fee9e1ee709a805 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2311352 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69009}
-
Seth Brenith authored
Design doc: https://docs.google.com/document/d/1szInbXZfaErWW70d30hJsOLL0Es-l5_g8d2rXm1ZBqI/edit?usp=sharing V8 can already collect data about how many times each basic block in the builtins is run. This change enables using that data for profile-guided optimization. New comments in BUILD.gn describe how to use this feature. A few implementation details worth mentioning, which aren't covered in the design doc: - BasicBlockProfilerData currently contains an array of RPO numbers. However, this array is always just [0, 1, 2, 3, ...], so this change removes that array. A new DCHECK in BasicBlockInstrumentor::Instrument ensures that the removal is valid. - RPO numbers, while useful for printing data that matches with the stringified schedule, are not useful for matching profiling data with blocks that haven't been scheduled yet. This change adds a new array of block IDs in BasicBlockProfilerData, so that block counters can be used for PGO. - Basic block counters need to be written to a file so that they can be provided to a subsequent run of mksnapshot, but the design doc doesn't specify the transfer format or what file is used. In this change, I propose using the existing v8.log file for that purpose. Block count records look like this: block,TestLessThanHandler,37,29405 This line indicates that block ID 37 in TestLessThanHandler was run 29405 times. If multiple lines refer to the same block, the reader adds them all together. I like this format because it's easy to use: - V8 already has robust logic for creating the log file, naming it to avoid conflicts in multi-process situations, etc. - Line order doesn't matter, and interleaved writes from various logging sources are fine, given that V8 writes each line atomically. - Combining multiple sources of profiling data is as simple as concatenating their v8.log files together. - It is a good idea to avoid making any changes based on profiling data if the function being compiled doesn't match the one that was profiled, since it is common to use profiling data downloaded from a central lab which is updated only periodically. To check whether a function matches, I propose using a hash of the Graph state right before scheduling. This might be stricter than necessary, as some changes to the function might be small enough that the profile data is still relevant, but I'd rather err on the side of not making incorrect changes. This hash is also written to the v8.log file, in a line that looks like this: builtin_hash,LdaZeroHandler,3387822046 Bug: v8:10470 Change-Id: I429e5ce5efa94e01e7489deb3996012cf860cf13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2220765 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Frank Tang authored
DateTimeFormat's fractionalSecondDigits shipped in M84, so we can drop the --harmony_intl_dateformat_fractional_second_digits flag now. Bug: v8:10485 Change-Id: If7a1a8599722073d7382635219a6fb46cdc47474 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2311410Reviewed-by:
-
Zeynep Cankara authored
This CL redesigns the IC Panel to emit events upon time range selection. IC entry time range specified from the input fields and entries falling into the selected time range bubbled up to the App controller. The IC panel emits events upon selection of a map or a source file location. Bug: v8:10644 Change-Id: I468dc52b7a6c62dbdee096e80cc6110ceb994f69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305893 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69006}
-
Maya Lekova authored
This CL fixes passing the receiver of a fast call as an effect input only in cases where the opcode supports it. It also introduces a test for callbacks without fallback support and a test where ConvertReceiver is not introduced. Bug: chromium:1052746 Change-Id: I6f396f4c9cbaab7ae915c908a9f805d9770f8946 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312777 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Zeynep Cankara authored
This CL encapsulates map panel behaviour with custom web components map-details for displaying information and map-transitions to show map transition tree. The web components emit/receive events to interact with the app. Bug: v8:10644 Change-Id: Ic61c2794ed7ab854ee61fa1e7c8fe9b1c3c31b7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305889 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
-
Maya Lekova authored
This reverts commit 06bdd8d6. Reason for revert: Speculative revert for arm64 sim CFI - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/1474? Original change's description: > [liftoff][tail-call] Add indirect tail calls > > R=clemensb@chromium.org > > Bug: v8:10693 > Change-Id: Ic71d873bf7099ba671b9db1e87392d54aeebd7cf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312096 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68996} TBR=clemensb@chromium.org,thibaudm@chromium.org Change-Id: Ibdc64e20247758fb6bc96b4e5d13406adab968a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10693 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312786Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: I6e226888d84a790efc36ac6e7c2a32bc3426bd84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308341 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Richard Stotz authored
Bug: v8:10720 Change-Id: I7a05bfb3c87c4f0f5516608da5d42fdaff466536 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304572 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#69001}
-
Nico Weber authored
Bug: chromium:1107945 Change-Id: I0f721ccaf06c7ddaf0213448c29f48f5c57ccc6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310575 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Georg Neis authored
It makes no sense to allow calling into V8 but at the same time insist that there must be no exception, as potentially any such call can result in a stack overflow. This CL only removes a comment from v8.h, the code changes were part of https://chromium-review.googlesource.com/c/v8/v8/+/2299375. Bug: v8:7044 Change-Id: I57769fa0f109219d07a7bdb979b46ca98cd0cec7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2306792 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#68999}
-
Milad Farazmand authored
Port b64cede5 R=thibaudm@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I5aad17e2818d9d3ac6ab76b90c5242dd6593557c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312497Reviewed-by:
-
Sathya Gunasekaran authored
This is used by the DynamicCheckMaps operator to indicate that the optimized code should not be thrown away, but instead should be re-run again, after healing the feedback. Bug: v8:10582, v8:9684 Change-Id: Ib2408ba0d1d1a6bf50b2031a5312c7a8cca08730 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308334 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:10693 Change-Id: Ic71d873bf7099ba671b9db1e87392d54aeebd7cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312096Reviewed-by:
-
Georg Neis authored
Make ArrayBuiltinsAssembler::GenerateConstructor use the JSArray::kInitialMaxFastElementArray constant instead of trying to manually compute it and end up with a different result depending on the build. This brings the code in sync with CodeStubAssembler::CreateArray and with Turbofan's JSCallReducer. Change-Id: I7fcc955166484a91f8982b359b94d9a586fdb50a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312780 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Richard Stotz authored
The design of this change was discussed here: https://docs.google.com/document/d/12otOj6SyXMXj0Dnnx9B6MGLMRwHPhg6RIZRazVw3tFA/ Bug: v8:10720 Change-Id: I8292dcf7272bdf4526a2d630b49fc374cdb01bdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304570 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Change-Id: I7989934f7f8a1332045a6ed708b02fbc3424c829 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310911Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68993}
-
Maya Lekova authored
This reverts commit d8f8a7e2. Reason for revert: Breaks code_serializer variant - https://cr-buildbucket.appspot.com/build/8874070652992164976 Original change's description: > Reland "[flags] warn about contradictory flags" > > This is a reland of b8f91666 > Difference to previous CL: Additional functionality to specify > incompatible flags based on GN variables and extra-flags, used > to fix the issues that came up on the waterfall. > > This also changes the rules regarding repeated flags: While > explicitly repeated flags are allowed for boolean values as long > as they are identical, repeated flags or explicit flags in the > presence of an active implication are disallowed for non-boolean > flags. The latter simplifies specifying conflict rules in > variants.py. Otherwise a rule like > > INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = { > "--gc-interval=*": ["--gc-interval=*"], > } > > wouldn't work because specifying the same GC interval twice > wouldn't actually count as a conflict. This was an issue with > test/mjsunit/wasm/gc-buffer.js, which specifies > --gc-interval=500 exactly like the extra flag by the stress bot. > > Also, this now expands contradictory flags checking to d8 flags > for consistency. > > Original change's description: > > [flags] warn about contradictory flags > > > > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/ > > > > Bug: v8:10577 > > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792 > > Reviewed-by: Clemens Backes <clemensb@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Tamer Tas <tmrts@chromium.org> > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#68168} > > Bug: v8:10577 > Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68989} TBR=machenbach@chromium.org,neis@chromium.org,clemensb@chromium.org,tebbi@chromium.org,tmrts@chromium.org Change-Id: I7969065b0edbc463a94e530485bc2ab623d77b62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10577 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312782Reviewed-by:
-
Maya Lekova authored
The object is passed now as an v8::ApiObject instead of unwrapped C++ pointer and the embedder should do the unwrapping. Bug: chromium:1052746 Change-Id: If5671c5fdbbe8d58435c7bd9aceccf5e17f8ea21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304571Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:10693 Change-Id: I2ffc99bfb9e96afd740fc1a095ccca61b7c5ce19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289970 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
