- 07 Nov, 2018 23 commits
-
-
Frank Tang authored
Bug: v8:8414 Change-Id: If7fa7aff80066f8f0073f563af4a3b3f60ae3ebf Reviewed-on: https://chromium-review.googlesource.com/c/1317825Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57325}
-
Frank Tang authored
This is a reland of 007c0034 In the original commit below, the permutation of testing combinatino test/intl/regress-8413.js take too long to complete in the TSAN and fail by TIMEOUT. Therefore we fix it by splitting up the test to smaller tests, one for each property type in Table 5 of ECMA402. Original change's description: > [Intl] Handle 'c' pattern for DateTimeFormat > > Handle the pattern 'c' return by ICU in Intl.DateTimeFormat > for weekday standalone form. > Add regression test to ensure all the standalone pattern return > option are in the expected list. > > Bug: v8:8413 > Change-Id: I9ab42383e3882ef1720606830624775e2748fccb > Reviewed-on: https://chromium-review.googlesource.com/c/1318092 > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57299} Bug: v8:8413 Change-Id: I7a4bfd0876e4afd3eddaf3cb3d9027db075a1e3c Reviewed-on: https://chromium-review.googlesource.com/c/1321893Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57324}
-
Frank Tang authored
This is a bit of a performance bottleneck currently and we're planning on improving performance by adding caching. These benchmarks will allow us to measure the improvements Add benchmark tests for String.prototype.localeCompare() Date.prototype.toLocaleString() Date.prototype.toLocaleDateString() Date.prototype.toLocaleTimeString() Number.prototype.toLocaleString() Run with python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Strings/StringLocaleCompare" \ test/js-perf-test/JSTests.json python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Dates" \ test/js-perf-test/JSTests.json python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Numbers" \ test/js-perf-test/JSTests.json Before the landing of dffaff77 git reset --hard 474a6d63 got StringLocaleCompare-Strings(Score): 13240000 toLocaleDateString-Dates(Score): 1877000 toLocaleString-Dates(Score): 1197000 toLocaleTimeString-Dates(Score): 2147000 toLocaleDateString-Dates(Score): 1908000 After the landing of dffaff77 git reset --hard dffaff77 got StringLocaleCompare-Strings(Score): 97182 toLocaleDateString-Dates(Score): 10436 toLocaleString-Dates(Score): 10436 toLocaleTimeString-Dates(Score): 10669 toLocaleString-Numbers(Score): 2876 Bug: chromium:901748 Change-Id: Ibfea85fe668f1bfaacb2dfe08368cd920d2bbfc6 Reviewed-on: https://chromium-review.googlesource.com/c/1318099Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57323}
-
Toon Verwaest authored
Instead we can typically check whether the expression or statement we just parsed indicate failure. Bug: v8:8363, v8:7926 Change-Id: I477511f9f2f0e615a07285db858a237af8478edc Reviewed-on: https://chromium-review.googlesource.com/c/1323553Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57322}
-
Dan Elphick authored
Change-Id: I10f64ce7c1692e46b3a4b1511936f3dd4e5b983a Reviewed-on: https://chromium-review.googlesource.com/c/1323554Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#57321}
-
Clemens Hammacher authored
Bug: v8:6600 Change-Id: I4982a7bb9f93bd2dced65ef9a7d3aa7711bc93b5 Reviewed-on: https://chromium-review.googlesource.com/c/1323730 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57320}
-
Toon Verwaest authored
That allows us to keep on running further without explicit RETURN_IF Bug: v8:8363, v8:7926 Change-Id: If1424a1dae656ac725a8443b09ea1b8cc25dfcb1 Reviewed-on: https://chromium-review.googlesource.com/c/1322953Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57319}
-
Toon Verwaest authored
Change-Id: I3f2f6f82af84489f0563fa74c315e46b9c746325 Reviewed-on: https://chromium-review.googlesource.com/c/1322950 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57318}
-
Clemens Hammacher authored
Compilation units currently contain pointers into allocated space that contains the code of the respective function. This requires us to keep the StreamingDecoder alive as long as compilation is still running (including tiering). This CL refactors this by having an additional redirection (WireBytesStorage) which can point to either the StreamingDecoder or the NativeModule. We only keep the code section buffer alive as long as the StreamingWireBytesStorage is still in use. I will further refactor memory ownership in a follow-up CL to not make the AsyncCompileJob keep the StreamingDecoder alive. R=ahaas@chromium.org Bug: v8:8343,v8:7921,v8:8050 Change-Id: I780582c3217abf64000454f2c9c108b9ac9fbff1 Reviewed-on: https://chromium-review.googlesource.com/c/1319588Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57317}
-
Toon Verwaest authored
Recursion is really only useful for sloppy eval and with scopes, which are uncommon. Change-Id: I2560b600cab9b00a82d5837a3daa28c8d38c2959 Reviewed-on: https://chromium-review.googlesource.com/c/1322451Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57316}
-
Igor Sheludko authored
because otherwise cleared weak references require special treatment during decompression. Bug: v8:7703 Change-Id: I38761d656c606e7ba7fc3075dffbd855a9f72302 Reviewed-on: https://chromium-review.googlesource.com/c/1322909 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57315}
-
Igor Sheludko authored
This is a reland of b8e8b0de Original change's description: > [ptr-compr] Fix incorrectly used machine types > > in TurboFan, CSA, Wasm and compiler tests. Tagged values decompression > logic will depend on the machine type of the value being loaded so it must > be correct. > > Bug: v8:7703 > Change-Id: Ia9e7cc1e273e5a458d9de8aaa4adb0c970413b8b > Reviewed-on: https://chromium-review.googlesource.com/c/1319573 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57280} Bug: v8:7703 Change-Id: I2c740bab9a800520ebfb83334345bd5641b7e408 Reviewed-on: https://chromium-review.googlesource.com/c/1320850Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57314}
-
Predrag Rudic authored
Change-Id: I18300c788d1a0eecb280e4cac72e52db81dd681d Reviewed-on: https://chromium-review.googlesource.com/c/1322452Reviewed-by: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#57313}
-
Dan Elphick authored
If builtins are embedded and we're not generating the snapshot, then completely skip iterating over the dispatch table, since off-heap bytecode handlers can never move or be collected. Additionally the dispatch table is initialized elsewhere so skip iterating over the table completely when serializing/deserializing. Bug: chromium:902230 Change-Id: I2cfe5b4b325d100145d5759ff97e0c8dde7ed7a3 Reviewed-on: https://chromium-review.googlesource.com/c/1319750 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57312}
-
Sathya Gunasekaran authored
This is currently dead code as intl no longer uses this to reset the cache. Intl will use a different caching strategy in the future. Bug: v8:5751 Change-Id: I343fa8afe5069cb7228106b3cd355d004aed199f Reviewed-on: https://chromium-review.googlesource.com/c/1319766Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#57311}
-
Igor Sheludko authored
in order to make the test compatible with the pointer compression friendly heap layout. Bug: v8:8182 Change-Id: I34a0c597b70687f7ae7dad19df60c94520fa349f Reviewed-on: https://chromium-review.googlesource.com/c/1317818 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57310}
-
Predrag Rudic authored
After commit 6d706ae3, MIPS builders started to fail. This CL completes that commit. Change-Id: Ib3fef6771f7878c8760b4820e54b06e853d6be3d Reviewed-on: https://chromium-review.googlesource.com/c/1320489Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#57309}
-
Clemens Hammacher authored
R=adamk@chromium.org Change-Id: I1299b91df21f20120c74405d3b995981368380e8 Reviewed-on: https://chromium-review.googlesource.com/c/1319762Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57308}
-
peterwmwong authored
This is to enable switching from throwing a JS exception (RangeError) to an abort when the --abort_on_stack_or_string_length_overflow flag is set. Bug: chromium:901652 Change-Id: Ia3ff2ec55e77a4f60d715f0bc767e6180a5e001a Reviewed-on: https://chromium-review.googlesource.com/c/1322312 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57307}
-
Jakob Kummerow authored
as part of the ongoing quest to get rid of Object*/Object** entirely. Design overview: https://goo.gl/Ph4CGz Bug: v8:3770 Change-Id: Ie79a461a61203ea5a6efcd7b2a31bff1834169dd Reviewed-on: https://chromium-review.googlesource.com/c/1316607 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57306}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/47ccdba..9f8abf9 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9a5dbc6..2e722b0 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/459aaba..6d6e0a8 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/42d5027..834113a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b2235ed..7798243 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ibcbc016a94cf4e22180dc6b9b78f14fb42a6bacc Reviewed-on: https://chromium-review.googlesource.com/c/1321896 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57305}
-
Caitlin Potter authored
Adds a helper macro "CloneIfMutablePrimitive", which tests if the operand is a MutableHeapNumber, and if so, clones it, otherwise returning the original value. Also modifies the signature of "CopyPropertyArrayValues" to take a "DestroySource" enum, indicating whether or not the resulting object is supplanting the source object or not, and removes all default parameters from that macro (which were not used anyways). This corrects the issue reported in chromium:901301, where StaNamedOwnProperty was replacing the value of a MutableHeapNumber referenced by both the cloned object and the source object. BUG=chromium:901301, v8:7611 R=cbruni@chromium.org, jkummerow@chromium.org Change-Id: I43df1ddc84dfa4840e680b6affeba452ce0b6629 Reviewed-on: https://chromium-review.googlesource.com/c/1318096 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#57304}
-
Adam Klein authored
This test takes over 8 minutes to run on arm64 debug. Also removed redundant skips for another DFG test. Change-Id: I9c66c90fb3dc5c42ca04010e2d0245626a867ebd Reviewed-on: https://chromium-review.googlesource.com/c/1321037Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57303}
-
- 06 Nov, 2018 17 commits
-
-
Aseem Garg authored
This CL only clears the wasm translations that correspond to the context group being reset instead of clearing all. R=clemensh@chromium.org,kozyatinskiy@chromium.org BUG=chromium:892864 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib5af0489cbdb7c9b1571cb9cf935fda3bee14015 Reviewed-on: https://chromium-review.googlesource.com/c/1292676Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#57302}
-
Adam Klein authored
This reverts commit 007c0034. Reason for revert: fails on TSAN bots (e.g., https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/23395) Original change's description: > [Intl] Handle 'c' pattern for DateTimeFormat > > Handle the pattern 'c' return by ICU in Intl.DateTimeFormat > for weekday standalone form. > Add regression test to ensure all the standalone pattern return > option are in the expected list. > > Bug: v8:8413 > Change-Id: I9ab42383e3882ef1720606830624775e2748fccb > Reviewed-on: https://chromium-review.googlesource.com/c/1318092 > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57299} TBR=jshin@chromium.org,gsathya@chromium.org,ftang@chromium.org Change-Id: Iff0afbcd4527428e16b779d84dc7b8b70eb1fe16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8413 Reviewed-on: https://chromium-review.googlesource.com/c/1320891Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57301}
-
Adam Klein authored
'simulator_run' is now used exclusively in test/*/*.status. Change-Id: I501b7ffd19e2476f4c803ed3d25cba69d67039fa Reviewed-on: https://chromium-review.googlesource.com/c/1318610Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57300}
-
Frank Tang authored
Handle the pattern 'c' return by ICU in Intl.DateTimeFormat for weekday standalone form. Add regression test to ensure all the standalone pattern return option are in the expected list. Bug: v8:8413 Change-Id: I9ab42383e3882ef1720606830624775e2748fccb Reviewed-on: https://chromium-review.googlesource.com/c/1318092Reviewed-by: Jungshik Shin <jshin@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57299}
-
Adam Klein authored
This test currently takes nearly 10 minutes on the arm64 debug builder. Bug: v8:7783 Change-Id: I500fc026b01873e666f32062d790eca3f34455b9 Reviewed-on: https://chromium-review.googlesource.com/c/1318495 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57298}
-
Junliang Yan authored
Bug: v8:8420 Change-Id: Ie3ca4cbee01a1b19c82630ec205915ff6a00b303 Reviewed-on: https://chromium-review.googlesource.com/c/1320449Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57297}
-
Junliang Yan authored
simulator takes too long to run. Change-Id: I77f6e932129bfed7d1cdb7e9ccf78a4608554ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1320389Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57296}
-
Junliang Yan authored
Port 6d706ae3 Original Commit Message: and split Smi out of objects.h into smi.h. R=jkummerow@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Id876a65c3e0af550caa246090b60580645faedc5 Reviewed-on: https://chromium-review.googlesource.com/c/1320032Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57295}
-
Michael Achenbach authored
This reverts commit b8e8b0de. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm%20-%20debug/8276 Original change's description: > [ptr-compr] Fix incorrectly used machine types > > in TurboFan, CSA, Wasm and compiler tests. Tagged values decompression > logic will depend on the machine type of the value being loaded so it must > be correct. > > Bug: v8:7703 > Change-Id: Ia9e7cc1e273e5a458d9de8aaa4adb0c970413b8b > Reviewed-on: https://chromium-review.googlesource.com/c/1319573 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57280} TBR=mstarzinger@chromium.org,ishell@chromium.org Change-Id: Ia97d5bfebf8d8fe1b2b7607f63024b60cf2c584f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7703 Reviewed-on: https://chromium-review.googlesource.com/c/1320349Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57294}
-
Sigurd Schneider authored
Change-Id: Ibe96234f101ce1e3a8fd61ccf387aa4bb6da6067 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1319870Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#57293}
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: I6e2782a7f8589c466b54987c850d41d4ff5f6489 Reviewed-on: https://chromium-review.googlesource.com/c/1316618Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57292}
-
Clemens Hammacher authored
The CompileStep is only invoked via the {AsyncCompileJob} that owns it, so we can just pass a pointer to the AsyncCompileJob instead of storing it in the step itself. R=ahaas@chromium.org Bug: v8:8238, v8:7921 Change-Id: I92eda222ace2d5fef5af7663175c62fa7601810c Reviewed-on: https://chromium-review.googlesource.com/c/1319759 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57291}
-
Jaroslav Sevcik authored
This introduces a utility function on code stub assembler to check that a map has given prototype object map. In addition, if constant field tracking is active, it will check that a given field is still constant (typically a function that is assumed not to be patched). This also fixes a fast path check in regexp C++ code to properly detect that "exec" function was modified on RegExp's prototype when constant field tracking is on. Bug: v8:5495, v8:8361 Change-Id: I98476db46ba4633124cf1437be90aea3585ce978 Reviewed-on: https://chromium-review.googlesource.com/c/1297954 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57290}
-
Joyee Cheung authored
Rename variables and flag names so that the classes can be reused by private methods implementation. In particular: Rename "fields" to "members" in the initializer so that we can initialize both fields and private methods/accessors there, for example: instance_fields_initializer -> instance_members_initializer InitializeClassFieldsStatement -> InitializeClassMembersStatement Rename "private field" to "private name" for the private symbols used to implement private fields so that we can use them to store private methods/accessors later as well, for example: private_field_name_var -> private_name_var NewPrivateFieldSymbol -> NewPrivateNameSymbol The follow-on is in https://chromium-review.googlesource.com/c/v8/v8/+/1301018 The design doc is in https://docs.google.com/document/d/1T-Ql6HOIH2U_8YjWkwK2rTfywwb7b3Qe8d3jkz72KwA/edit?usp=sharing Bug: v8:8330 Change-Id: I1cdca8def711da879b6e4d67c5ff0a5a4a36abbe Reviewed-on: https://chromium-review.googlesource.com/c/1312597Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#57289}
-
Clemens Hammacher authored
The order is: inner classes, friend classes, fields, methods. Before, fields and methods were mixed up. R=ahaas@chromium.org Bug: v8:8238 Change-Id: I4a6834785f2285e62e24c073611885378046b88b Reviewed-on: https://chromium-review.googlesource.com/c/1319756Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57288}
-
Sigurd Schneider authored
Change-Id: I1fe4454e3c0f2ec5cc044e36c311012d41e896a7 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1319768 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#57287}
-
Sigurd Schneider authored
Change-Id: If8faa3c7c0324fc9d0a2704533278828c62d5b91 Notry: true Bug: v8:8128, v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1319765Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#57286}
-