Skip to content

V
V8
Commit fff4301f authored by hablich's avatar hablich Committed by Commit bot
Browse files
Options

Revert of Add V8.Execute histogram to measure time spent executing JS code.... 

Revert of Add V8.Execute histogram to measure time spent executing JS code. (patchset #1 id:1 of https://codereview.chromium.org/1974003002/ )

Reason for revert:
Blocks roll https://codereview.chromium.org/1972303002/

Repro:
- build chromium with this CL
- out/Default/content_browsertests --gtest_filter=AccessibilityHitTestingBrowserTest.HitTestingInIframes

Original issue's description:
> Add V8.Execute histogram to measure time spent executing JS code.
>
> Adds a V8.Execute histogram to measure the amount of time spent executing
> JS code.
>
> BUG=v8:4865
> LOG=N
>
> Committed: https://crrev.com/e8f5a2723cf54576b84322ac2ee6ef7abc9df056
> Cr-Commit-Position: refs/heads/master@{#36217}

TBR=cbruni@chromium.org,rmcilroy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4865

Review-Url: https://codereview.chromium.org/1970193003
Cr-Commit-Position: refs/heads/master@{#36234}
parent 4505b54a
Hide whitespace changes
Inline Side-by-side
Showing with 40 additions and 47 deletions
src/api.cc
View file @ fff4301f
...@@ -1783,7 +1783,6 @@ Local<Value> UnboundScript::GetSourceMappingURL() { ...@@ -1783,7 +1783,6 @@ Local<Value> UnboundScript::GetSourceMappingURL() {
MaybeLocal<Value> Script::Run(Local<Context> context) { MaybeLocal<Value> Script::Run(Local<Context> context) {
PREPARE_FOR_EXECUTION_WITH_CALLBACK(context, "v8::Script::Run()", Value) PREPARE_FOR_EXECUTION_WITH_CALLBACK(context, "v8::Script::Run()", Value)
i::HistogramTimerScope execute_timer(isolate->counters()->execute());
i::AggregatingHistogramTimerScope timer(isolate->counters()->compile_lazy()); i::AggregatingHistogramTimerScope timer(isolate->counters()->compile_lazy());
i::TimerEventScope<i::TimerEventExecute> timer_scope(isolate); i::TimerEventScope<i::TimerEventExecute> timer_scope(isolate);
TRACE_EVENT0("v8", "V8.Execute"); TRACE_EVENT0("v8", "V8.Execute");
...@@ -4380,7 +4379,6 @@ MaybeLocal<Value> Object::CallAsFunction(Local<Context> context, ...@@ -4380,7 +4379,6 @@ MaybeLocal<Value> Object::CallAsFunction(Local<Context> context,
Local<Value> argv[]) { Local<Value> argv[]) {
PREPARE_FOR_EXECUTION_WITH_CALLBACK(context, "v8::Object::CallAsFunction()", PREPARE_FOR_EXECUTION_WITH_CALLBACK(context, "v8::Object::CallAsFunction()",
Value); Value);
i::HistogramTimerScope execute_timer(isolate->counters()->execute());
i::TimerEventScope<i::TimerEventExecute> timer_scope(isolate); i::TimerEventScope<i::TimerEventExecute> timer_scope(isolate);
TRACE_EVENT0("v8", "V8.Execute"); TRACE_EVENT0("v8", "V8.Execute");
auto self = Utils::OpenHandle(this); auto self = Utils::OpenHandle(this);
...@@ -4408,7 +4406,6 @@ MaybeLocal<Value> Object::CallAsConstructor(Local<Context> context, int argc, ...@@ -4408,7 +4406,6 @@ MaybeLocal<Value> Object::CallAsConstructor(Local<Context> context, int argc,
Local<Value> argv[]) { Local<Value> argv[]) {
PREPARE_FOR_EXECUTION_WITH_CALLBACK(context, PREPARE_FOR_EXECUTION_WITH_CALLBACK(context,
"v8::Object::CallAsConstructor()", Value); "v8::Object::CallAsConstructor()", Value);
i::HistogramTimerScope execute_timer(isolate->counters()->execute());
i::TimerEventScope<i::TimerEventExecute> timer_scope(isolate); i::TimerEventScope<i::TimerEventExecute> timer_scope(isolate);
TRACE_EVENT0("v8", "V8.Execute"); TRACE_EVENT0("v8", "V8.Execute");
auto self = Utils::OpenHandle(this); auto self = Utils::OpenHandle(this);
...@@ -4459,7 +4456,6 @@ MaybeLocal<Object> Function::NewInstance(Local<Context> context, int argc, ...@@ -4459,7 +4456,6 @@ MaybeLocal<Object> Function::NewInstance(Local<Context> context, int argc,
v8::Local<v8::Value> argv[]) const { v8::Local<v8::Value> argv[]) const {
PREPARE_FOR_EXECUTION_WITH_CALLBACK(context, "v8::Function::NewInstance()", PREPARE_FOR_EXECUTION_WITH_CALLBACK(context, "v8::Function::NewInstance()",
Object); Object);
i::HistogramTimerScope execute_timer(isolate->counters()->execute());
i::TimerEventScope<i::TimerEventExecute> timer_scope(isolate); i::TimerEventScope<i::TimerEventExecute> timer_scope(isolate);
TRACE_EVENT0("v8", "V8.Execute"); TRACE_EVENT0("v8", "V8.Execute");
auto self = Utils::OpenHandle(this); auto self = Utils::OpenHandle(this);
...@@ -4484,7 +4480,6 @@ MaybeLocal<v8::Value> Function::Call(Local<Context> context, ...@@ -4484,7 +4480,6 @@ MaybeLocal<v8::Value> Function::Call(Local<Context> context,
v8::Local<v8::Value> recv, int argc, v8::Local<v8::Value> recv, int argc,
v8::Local<v8::Value> argv[]) { v8::Local<v8::Value> argv[]) {
PREPARE_FOR_EXECUTION_WITH_CALLBACK(context, "v8::Function::Call()", Value); PREPARE_FOR_EXECUTION_WITH_CALLBACK(context, "v8::Function::Call()", Value);
i::HistogramTimerScope execute_timer(isolate->counters()->execute());
i::TimerEventScope<i::TimerEventExecute> timer_scope(isolate); i::TimerEventScope<i::TimerEventExecute> timer_scope(isolate);
TRACE_EVENT0("v8", "V8.Execute"); TRACE_EVENT0("v8", "V8.Execute");
auto self = Utils::OpenHandle(this); auto self = Utils::OpenHandle(this);
......
src/counters.h
View file @ fff4301f
...@@ -670,48 +670,46 @@ class RuntimeCallTimerScope { ...@@ -670,48 +670,46 @@ class RuntimeCallTimerScope {
/* Asm/Wasm. */ \ /* Asm/Wasm. */ \
HR(wasm_functions_per_module, V8.WasmFunctionsPerModule, 1, 10000, 51) HR(wasm_functions_per_module, V8.WasmFunctionsPerModule, 1, 10000, 51)
#define HISTOGRAM_TIMER_LIST(HT) \ #define HISTOGRAM_TIMER_LIST(HT) \
/* Garbage collection timers. */ \ /* Garbage collection timers. */ \
HT(gc_compactor, V8.GCCompactor, 10000, MILLISECOND) \ HT(gc_compactor, V8.GCCompactor, 10000, MILLISECOND) \
HT(gc_finalize, V8.GCFinalizeMC, 10000, MILLISECOND) \ HT(gc_finalize, V8.GCFinalizeMC, 10000, MILLISECOND) \
HT(gc_finalize_reduce_memory, V8.GCFinalizeMCReduceMemory, 10000, \ HT(gc_finalize_reduce_memory, V8.GCFinalizeMCReduceMemory, 10000, \
MILLISECOND) \ MILLISECOND) \
HT(gc_scavenger, V8.GCScavenger, 10000, MILLISECOND) \ HT(gc_scavenger, V8.GCScavenger, 10000, MILLISECOND) \
HT(gc_context, V8.GCContext, 10000, \ HT(gc_context, V8.GCContext, 10000, \
MILLISECOND) /* GC context cleanup time */ \ MILLISECOND) /* GC context cleanup time */ \
HT(gc_idle_notification, V8.GCIdleNotification, 10000, MILLISECOND) \ HT(gc_idle_notification, V8.GCIdleNotification, 10000, MILLISECOND) \
HT(gc_incremental_marking, V8.GCIncrementalMarking, 10000, MILLISECOND) \ HT(gc_incremental_marking, V8.GCIncrementalMarking, 10000, MILLISECOND) \
HT(gc_incremental_marking_start, V8.GCIncrementalMarkingStart, 10000, \ HT(gc_incremental_marking_start, V8.GCIncrementalMarkingStart, 10000, \
MILLISECOND) \ MILLISECOND) \
HT(gc_incremental_marking_finalize, V8.GCIncrementalMarkingFinalize, 10000, \ HT(gc_incremental_marking_finalize, V8.GCIncrementalMarkingFinalize, 10000, \
MILLISECOND) \ MILLISECOND) \
HT(gc_low_memory_notification, V8.GCLowMemoryNotification, 10000, \ HT(gc_low_memory_notification, V8.GCLowMemoryNotification, 10000, \
MILLISECOND) \ MILLISECOND) \
/* Parsing timers. */ \ /* Parsing timers. */ \
HT(parse, V8.ParseMicroSeconds, 1000000, MICROSECOND) \ HT(parse, V8.ParseMicroSeconds, 1000000, MICROSECOND) \
HT(parse_lazy, V8.ParseLazyMicroSeconds, 1000000, MICROSECOND) \ HT(parse_lazy, V8.ParseLazyMicroSeconds, 1000000, MICROSECOND) \
HT(pre_parse, V8.PreParseMicroSeconds, 1000000, MICROSECOND) \ HT(pre_parse, V8.PreParseMicroSeconds, 1000000, MICROSECOND) \
/* Compilation times. */ \ /* Compilation times. */ \
HT(compile, V8.CompileMicroSeconds, 1000000, MICROSECOND) \ HT(compile, V8.CompileMicroSeconds, 1000000, MICROSECOND) \
HT(compile_eval, V8.CompileEvalMicroSeconds, 1000000, MICROSECOND) \ HT(compile_eval, V8.CompileEvalMicroSeconds, 1000000, MICROSECOND) \
/* Serialization as part of compilation (code caching) */ \ /* Serialization as part of compilation (code caching) */ \
HT(compile_serialize, V8.CompileSerializeMicroSeconds, 100000, MICROSECOND) \ HT(compile_serialize, V8.CompileSerializeMicroSeconds, 100000, MICROSECOND) \
HT(compile_deserialize, V8.CompileDeserializeMicroSeconds, 1000000, \ HT(compile_deserialize, V8.CompileDeserializeMicroSeconds, 1000000, \
MICROSECOND) \ MICROSECOND) \
/* Total compilation time incl. caching/parsing */ \ /* Total compilation time incl. caching/parsing */ \
HT(compile_script, V8.CompileScriptMicroSeconds, 1000000, MICROSECOND) \ HT(compile_script, V8.CompileScriptMicroSeconds, 1000000, MICROSECOND) \
/* Total JavaScript execution time (including callbacks and runtime calls */ \ /* Asm/Wasm */ \
HT(execute, V8.Execute, 1000000, MICROSECOND) \ HT(wasm_instantiate_module_time, V8.WasmInstantiateModuleMicroSeconds, \
/* Asm/Wasm */ \ 1000000, MICROSECOND) \
HT(wasm_instantiate_module_time, V8.WasmInstantiateModuleMicroSeconds, \ HT(wasm_decode_module_time, V8.WasmDecodeModuleMicroSeconds, 1000000, \
1000000, MICROSECOND) \ MICROSECOND) \
HT(wasm_decode_module_time, V8.WasmDecodeModuleMicroSeconds, 1000000, \ HT(wasm_decode_function_time, V8.WasmDecodeFunctionMicroSeconds, 1000000, \
MICROSECOND) \ MICROSECOND) \
HT(wasm_decode_function_time, V8.WasmDecodeFunctionMicroSeconds, 1000000, \ HT(wasm_compile_module_time, V8.WasmCompileModuleMicroSeconds, 1000000, \
MICROSECOND) \ MICROSECOND) \
HT(wasm_compile_module_time, V8.WasmCompileModuleMicroSeconds, 1000000, \ HT(wasm_compile_function_time, V8.WasmCompileFunctionMicroSeconds, 1000000, \
MICROSECOND) \
HT(wasm_compile_function_time, V8.WasmCompileFunctionMicroSeconds, 1000000, \
MICROSECOND) MICROSECOND)
#define AGGREGATABLE_HISTOGRAM_TIMER_LIST(AHT) \ #define AGGREGATABLE_HISTOGRAM_TIMER_LIST(AHT) \
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment