Commit ffb2a642 authored by Francis McCabe's avatar Francis McCabe Committed by Commit Bot

Revert "[atomics] Missing detach check in Atomics.store on MIPS"

This reverts commit 8358094d.

Reason for revert: Closed the tree on arm pointer compression:
https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20arm64%20-%20sim%20-%20pointer%20compression/6256?


Original change's description:
> [atomics] Missing detach check in Atomics.store on MIPS
> 
> There was a missing detach check in the runtime implementation of
> Atomics.store on BigInt TypedArrays. This runtime function is only used
> on MIPS.
> 
> Bug: v8:10687
> Change-Id: I77946d2ab0abf70c583af514ddaba0d384a21309
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2369663
> Auto-Submit: Shu-yu Guo <syg@chromium.org>
> Commit-Queue: Ben Smith <binji@chromium.org>
> Reviewed-by: Ben Smith <binji@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#69525}

TBR=binji@chromium.org,syg@chromium.org

Change-Id: I955cdbf5d83674b8acb5b67bbe8754f3d39261aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:10687
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2369973Reviewed-by: 's avatarFrancis McCabe <fgm@chromium.org>
Commit-Queue: Francis McCabe <fgm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69526}
parent 8358094d
...@@ -437,10 +437,9 @@ RUNTIME_FUNCTION(Runtime_AtomicsStore64) { ...@@ -437,10 +437,9 @@ RUNTIME_FUNCTION(Runtime_AtomicsStore64) {
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, bigint, ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, bigint,
BigInt::FromObject(isolate, value_obj)); BigInt::FromObject(isolate, value_obj));
THROW_ERROR_RETURN_FAILURE_ON_DETACHED(isolate, sta, "Atomics.store");
DCHECK(sta->type() == kExternalBigInt64Array || DCHECK(sta->type() == kExternalBigInt64Array ||
sta->type() == kExternalBigUint64Array); sta->type() == kExternalBigUint64Array);
DCHECK(!sta->WasDetached());
CHECK_LT(index, sta->length()); CHECK_LT(index, sta->length());
if (sta->type() == kExternalBigInt64Array) { if (sta->type() == kExternalBigInt64Array) {
Store<int64_t>::Do(isolate, source, index, bigint); Store<int64_t>::Do(isolate, source, index, bigint);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment