Commit ffa4d2b7 authored by Leszek Swirski's avatar Leszek Swirski Committed by Commit Bot

[profiler] Don't include tag in CodeEntry hash

maintain hash table invariants (that equality implies matching hashes),
the CodeEntry hash shouldn't include the tag either.

CodeEntry: :IsSameFunctionAs does not consider the CodeEntry's tag, so to
Change-Id: I1e06707b72d49ad9e88368ae68e7ccb16c2483ca
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712786
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72949}
parent 655ae222
......@@ -134,7 +134,7 @@ CodeEntry* CodeEntry::root_entry() {
}
uint32_t CodeEntry::GetHash() const {
uint32_t hash = ComputeUnseededHash(tag());
uint32_t hash = 0;
if (script_id_ != v8::UnboundScript::kNoScriptId) {
hash ^= ComputeUnseededHash(static_cast<uint32_t>(script_id_));
hash ^= ComputeUnseededHash(static_cast<uint32_t>(position_));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment