Commit ff412919 authored by Dominik Inführ's avatar Dominik Inführ Committed by Commit Bot

[heap] Remove unused scopes in GCTracer::BackgroundScope

Scopes aren't used anymore.

Change-Id: Id233974e3b9760560deb85d822218efe9ab9f896
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560199
Auto-Submit: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71415}
parent d5bafd81
...@@ -40,9 +40,9 @@ RuntimeCallCounterId GCTracer::RCSCounterFromScope(Scope::ScopeId id) { ...@@ -40,9 +40,9 @@ RuntimeCallCounterId GCTracer::RCSCounterFromScope(Scope::ScopeId id) {
RuntimeCallCounterId GCTracer::RCSCounterFromBackgroundScope( RuntimeCallCounterId GCTracer::RCSCounterFromBackgroundScope(
BackgroundScope::ScopeId id) { BackgroundScope::ScopeId id) {
STATIC_ASSERT(Scope::FIRST_BACKGROUND_SCOPE == STATIC_ASSERT(Scope::FIRST_BACKGROUND_SCOPE ==
Scope::BACKGROUND_ARRAY_BUFFER_FREE); Scope::BACKGROUND_ARRAY_BUFFER_SWEEP);
STATIC_ASSERT( STATIC_ASSERT(
0 == static_cast<int>(BackgroundScope::BACKGROUND_ARRAY_BUFFER_FREE)); 0 == static_cast<int>(BackgroundScope::BACKGROUND_ARRAY_BUFFER_SWEEP));
return static_cast<RuntimeCallCounterId>( return static_cast<RuntimeCallCounterId>(
static_cast<int>(RCSCounterFromScope(Scope::FIRST_BACKGROUND_SCOPE)) + static_cast<int>(RCSCounterFromScope(Scope::FIRST_BACKGROUND_SCOPE)) +
static_cast<int>(id)); static_cast<int>(id));
...@@ -585,8 +585,6 @@ void GCTracer::PrintNVP() const { ...@@ -585,8 +585,6 @@ void GCTracer::PrintNVP() const {
"scavenge.update_refs=%.2f " "scavenge.update_refs=%.2f "
"scavenge.sweep_array_buffers=%.2f " "scavenge.sweep_array_buffers=%.2f "
"background.scavenge.parallel=%.2f " "background.scavenge.parallel=%.2f "
"background.array_buffer_free=%.2f "
"background.store_buffer=%.2f "
"background.unmapper=%.2f " "background.unmapper=%.2f "
"incremental.steps_count=%d " "incremental.steps_count=%d "
"incremental.steps_took=%.1f " "incremental.steps_took=%.1f "
...@@ -630,8 +628,6 @@ void GCTracer::PrintNVP() const { ...@@ -630,8 +628,6 @@ void GCTracer::PrintNVP() const {
current_.scopes[Scope::SCAVENGER_SCAVENGE_UPDATE_REFS], current_.scopes[Scope::SCAVENGER_SCAVENGE_UPDATE_REFS],
current_.scopes[Scope::SCAVENGER_SWEEP_ARRAY_BUFFERS], current_.scopes[Scope::SCAVENGER_SWEEP_ARRAY_BUFFERS],
current_.scopes[Scope::SCAVENGER_BACKGROUND_SCAVENGE_PARALLEL], current_.scopes[Scope::SCAVENGER_BACKGROUND_SCAVENGE_PARALLEL],
current_.scopes[Scope::BACKGROUND_ARRAY_BUFFER_FREE],
current_.scopes[Scope::BACKGROUND_STORE_BUFFER],
current_.scopes[Scope::BACKGROUND_UNMAPPER], current_.scopes[Scope::BACKGROUND_UNMAPPER],
current_.incremental_marking_scopes[GCTracer::Scope::MC_INCREMENTAL] current_.incremental_marking_scopes[GCTracer::Scope::MC_INCREMENTAL]
.steps, .steps,
...@@ -674,8 +670,6 @@ void GCTracer::PrintNVP() const { ...@@ -674,8 +670,6 @@ void GCTracer::PrintNVP() const {
"background.mark=%.2f " "background.mark=%.2f "
"background.evacuate.copy=%.2f " "background.evacuate.copy=%.2f "
"background.evacuate.update_pointers=%.2f " "background.evacuate.update_pointers=%.2f "
"background.array_buffer_free=%.2f "
"background.store_buffer=%.2f "
"background.unmapper=%.2f " "background.unmapper=%.2f "
"update_marking_deque=%.2f " "update_marking_deque=%.2f "
"reset_liveness=%.2f\n", "reset_liveness=%.2f\n",
...@@ -700,8 +694,6 @@ void GCTracer::PrintNVP() const { ...@@ -700,8 +694,6 @@ void GCTracer::PrintNVP() const {
current_.scopes[Scope::MINOR_MC_BACKGROUND_MARKING], current_.scopes[Scope::MINOR_MC_BACKGROUND_MARKING],
current_.scopes[Scope::MINOR_MC_BACKGROUND_EVACUATE_COPY], current_.scopes[Scope::MINOR_MC_BACKGROUND_EVACUATE_COPY],
current_.scopes[Scope::MINOR_MC_BACKGROUND_EVACUATE_UPDATE_POINTERS], current_.scopes[Scope::MINOR_MC_BACKGROUND_EVACUATE_UPDATE_POINTERS],
current_.scopes[Scope::BACKGROUND_ARRAY_BUFFER_FREE],
current_.scopes[Scope::BACKGROUND_STORE_BUFFER],
current_.scopes[Scope::BACKGROUND_UNMAPPER], current_.scopes[Scope::BACKGROUND_UNMAPPER],
current_.scopes[Scope::MINOR_MC_MARKING_DEQUE], current_.scopes[Scope::MINOR_MC_MARKING_DEQUE],
current_.scopes[Scope::MINOR_MC_RESET_LIVENESS]); current_.scopes[Scope::MINOR_MC_RESET_LIVENESS]);
...@@ -725,7 +717,6 @@ void GCTracer::PrintNVP() const { ...@@ -725,7 +717,6 @@ void GCTracer::PrintNVP() const {
"clear.dependent_code=%.1f " "clear.dependent_code=%.1f "
"clear.maps=%.1f " "clear.maps=%.1f "
"clear.slots_buffer=%.1f " "clear.slots_buffer=%.1f "
"clear.store_buffer=%.1f "
"clear.string_table=%.1f " "clear.string_table=%.1f "
"clear.weak_collections=%.1f " "clear.weak_collections=%.1f "
"clear.weak_lists=%.1f " "clear.weak_lists=%.1f "
...@@ -786,8 +777,6 @@ void GCTracer::PrintNVP() const { ...@@ -786,8 +777,6 @@ void GCTracer::PrintNVP() const {
"background.sweep=%.1f " "background.sweep=%.1f "
"background.evacuate.copy=%.1f " "background.evacuate.copy=%.1f "
"background.evacuate.update_pointers=%.1f " "background.evacuate.update_pointers=%.1f "
"background.array_buffer_free=%.2f "
"background.store_buffer=%.2f "
"background.unmapper=%.1f " "background.unmapper=%.1f "
"total_size_before=%zu " "total_size_before=%zu "
"total_size_after=%zu " "total_size_after=%zu "
...@@ -820,7 +809,6 @@ void GCTracer::PrintNVP() const { ...@@ -820,7 +809,6 @@ void GCTracer::PrintNVP() const {
current_.scopes[Scope::MC_CLEAR_DEPENDENT_CODE], current_.scopes[Scope::MC_CLEAR_DEPENDENT_CODE],
current_.scopes[Scope::MC_CLEAR_MAPS], current_.scopes[Scope::MC_CLEAR_MAPS],
current_.scopes[Scope::MC_CLEAR_SLOTS_BUFFER], current_.scopes[Scope::MC_CLEAR_SLOTS_BUFFER],
current_.scopes[Scope::MC_CLEAR_STORE_BUFFER],
current_.scopes[Scope::MC_CLEAR_STRING_TABLE], current_.scopes[Scope::MC_CLEAR_STRING_TABLE],
current_.scopes[Scope::MC_CLEAR_WEAK_COLLECTIONS], current_.scopes[Scope::MC_CLEAR_WEAK_COLLECTIONS],
current_.scopes[Scope::MC_CLEAR_WEAK_LISTS], current_.scopes[Scope::MC_CLEAR_WEAK_LISTS],
...@@ -888,8 +876,6 @@ void GCTracer::PrintNVP() const { ...@@ -888,8 +876,6 @@ void GCTracer::PrintNVP() const {
current_.scopes[Scope::MC_BACKGROUND_SWEEPING], current_.scopes[Scope::MC_BACKGROUND_SWEEPING],
current_.scopes[Scope::MC_BACKGROUND_EVACUATE_COPY], current_.scopes[Scope::MC_BACKGROUND_EVACUATE_COPY],
current_.scopes[Scope::MC_BACKGROUND_EVACUATE_UPDATE_POINTERS], current_.scopes[Scope::MC_BACKGROUND_EVACUATE_UPDATE_POINTERS],
current_.scopes[Scope::BACKGROUND_ARRAY_BUFFER_FREE],
current_.scopes[Scope::BACKGROUND_STORE_BUFFER],
current_.scopes[Scope::BACKGROUND_UNMAPPER], current_.scopes[Scope::BACKGROUND_UNMAPPER],
current_.start_object_size, current_.end_object_size, current_.start_object_size, current_.end_object_size,
current_.start_holes_size, current_.end_holes_size, current_.start_holes_size, current_.end_holes_size,
......
...@@ -79,7 +79,7 @@ class V8_EXPORT_PRIVATE GCTracer { ...@@ -79,7 +79,7 @@ class V8_EXPORT_PRIVATE GCTracer {
FIRST_SCOPE = MC_INCREMENTAL, FIRST_SCOPE = MC_INCREMENTAL,
NUMBER_OF_INCREMENTAL_SCOPES = NUMBER_OF_INCREMENTAL_SCOPES =
LAST_INCREMENTAL_SCOPE - FIRST_INCREMENTAL_SCOPE + 1, LAST_INCREMENTAL_SCOPE - FIRST_INCREMENTAL_SCOPE + 1,
FIRST_GENERAL_BACKGROUND_SCOPE = BACKGROUND_ARRAY_BUFFER_FREE, FIRST_GENERAL_BACKGROUND_SCOPE = BACKGROUND_ARRAY_BUFFER_SWEEP,
LAST_GENERAL_BACKGROUND_SCOPE = BACKGROUND_UNMAPPER, LAST_GENERAL_BACKGROUND_SCOPE = BACKGROUND_UNMAPPER,
FIRST_MC_BACKGROUND_SCOPE = MC_BACKGROUND_EVACUATE_COPY, FIRST_MC_BACKGROUND_SCOPE = MC_BACKGROUND_EVACUATE_COPY,
LAST_MC_BACKGROUND_SCOPE = MC_BACKGROUND_SWEEPING, LAST_MC_BACKGROUND_SCOPE = MC_BACKGROUND_SWEEPING,
...@@ -111,7 +111,7 @@ class V8_EXPORT_PRIVATE GCTracer { ...@@ -111,7 +111,7 @@ class V8_EXPORT_PRIVATE GCTracer {
TRACER_BACKGROUND_SCOPES(DEFINE_SCOPE) TRACER_BACKGROUND_SCOPES(DEFINE_SCOPE)
#undef DEFINE_SCOPE #undef DEFINE_SCOPE
NUMBER_OF_SCOPES, NUMBER_OF_SCOPES,
FIRST_GENERAL_BACKGROUND_SCOPE = BACKGROUND_ARRAY_BUFFER_FREE, FIRST_GENERAL_BACKGROUND_SCOPE = BACKGROUND_ARRAY_BUFFER_SWEEP,
LAST_GENERAL_BACKGROUND_SCOPE = BACKGROUND_UNMAPPER, LAST_GENERAL_BACKGROUND_SCOPE = BACKGROUND_UNMAPPER,
FIRST_MC_BACKGROUND_SCOPE = MC_BACKGROUND_EVACUATE_COPY, FIRST_MC_BACKGROUND_SCOPE = MC_BACKGROUND_EVACUATE_COPY,
LAST_MC_BACKGROUND_SCOPE = MC_BACKGROUND_SWEEPING, LAST_MC_BACKGROUND_SCOPE = MC_BACKGROUND_SWEEPING,
......
...@@ -431,7 +431,6 @@ ...@@ -431,7 +431,6 @@
F(MC_CLEAR_FLUSHED_JS_FUNCTIONS) \ F(MC_CLEAR_FLUSHED_JS_FUNCTIONS) \
F(MC_CLEAR_MAPS) \ F(MC_CLEAR_MAPS) \
F(MC_CLEAR_SLOTS_BUFFER) \ F(MC_CLEAR_SLOTS_BUFFER) \
F(MC_CLEAR_STORE_BUFFER) \
F(MC_CLEAR_STRING_TABLE) \ F(MC_CLEAR_STRING_TABLE) \
F(MC_CLEAR_WEAK_COLLECTIONS) \ F(MC_CLEAR_WEAK_COLLECTIONS) \
F(MC_CLEAR_WEAK_LISTS) \ F(MC_CLEAR_WEAK_LISTS) \
...@@ -508,10 +507,8 @@ ...@@ -508,10 +507,8 @@
F(STOP_THE_WORLD) F(STOP_THE_WORLD)
#define TRACER_BACKGROUND_SCOPES(F) \ #define TRACER_BACKGROUND_SCOPES(F) \
F(BACKGROUND_ARRAY_BUFFER_FREE) \
F(BACKGROUND_ARRAY_BUFFER_SWEEP) \ F(BACKGROUND_ARRAY_BUFFER_SWEEP) \
F(BACKGROUND_COLLECTION) \ F(BACKGROUND_COLLECTION) \
F(BACKGROUND_STORE_BUFFER) \
F(BACKGROUND_UNMAPPER) \ F(BACKGROUND_UNMAPPER) \
F(MC_BACKGROUND_EVACUATE_COPY) \ F(MC_BACKGROUND_EVACUATE_COPY) \
F(MC_BACKGROUND_EVACUATE_UPDATE_POINTERS) \ F(MC_BACKGROUND_EVACUATE_UPDATE_POINTERS) \
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment