Revert "Add debug output to presubmit script for investigating tree check...

Revert "Add debug output to presubmit script for investigating tree check behavior." and "Add more temporary debugging output to PRESUBMIT.py".

This reverts commits r18538 and r18528, since the investigated problem was found.

BUG=
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/133993002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent d849dfa5
...@@ -61,15 +61,11 @@ def _CommonChecks(input_api, output_api): ...@@ -61,15 +61,11 @@ def _CommonChecks(input_api, output_api):
def _SkipTreeCheck(input_api, output_api): def _SkipTreeCheck(input_api, output_api):
"""Check the env var whether we want to skip tree check. """Check the env var whether we want to skip tree check.
Only skip if src/version.cc has been updated.""" Only skip if src/version.cc has been updated."""
print "skip tree check?", input_api.environ.get('PRESUBMIT_TREE_CHECK')
src_version = 'src/version.cc' src_version = 'src/version.cc'
def FilterFile(file): FilterFile = lambda file: file.LocalPath() == src_version
print "Changed file:", file.LocalPath() if not input_api.AffectedSourceFiles(
return file.LocalPath() == src_version lambda file: file.LocalPath() == src_version):
if not input_api.AffectedSourceFiles(FilterFile):
return False return False
if input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip':
print "Skip tree check requested via environment variable."
return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip' return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip'
...@@ -98,7 +94,6 @@ def CheckChangeOnCommit(input_api, output_api): ...@@ -98,7 +94,6 @@ def CheckChangeOnCommit(input_api, output_api):
results.extend(input_api.canned_checks.CheckChangeHasDescription( results.extend(input_api.canned_checks.CheckChangeHasDescription(
input_api, output_api)) input_api, output_api))
if not _SkipTreeCheck(input_api, output_api): if not _SkipTreeCheck(input_api, output_api):
print "Checking if tree is open."
results.extend(input_api.canned_checks.CheckTreeIsOpen( results.extend(input_api.canned_checks.CheckTreeIsOpen(
input_api, output_api, input_api, output_api,
json_url='http://v8-status.appspot.com/current?format=json')) json_url='http://v8-status.appspot.com/current?format=json'))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment