Commit fe674753 authored by Santiago Aboy Solanes's avatar Santiago Aboy Solanes Committed by Commit Bot

[CSA][cleanup] TNodify interpeter's comparisons

TNodify:
 * Equal
 * StrictEqual
 * RelationalComparison

Also TNodify some low hanging Node* in interpreter generator

Bug: v8:6949, v8:9396
Change-Id: I8d6ef775abd10db79cae740e4e26446d7117af25
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801842Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63753}
parent eae0e516
This diff is collapsed.
......@@ -3393,10 +3393,10 @@ class V8_EXPORT_PRIVATE CodeStubAssembler
TNode<IntPtrT> start_offset,
TNode<IntPtrT> end_offset, RootIndex root);
Node* RelationalComparison(Operation op, SloppyTNode<Object> left,
SloppyTNode<Object> right,
TNode<Oddball> RelationalComparison(
Operation op, SloppyTNode<Object> left, SloppyTNode<Object> right,
SloppyTNode<Context> context,
Variable* var_type_feedback = nullptr);
TVariable<Smi>* var_type_feedback = nullptr);
void BranchIfNumberRelationalComparison(Operation op,
SloppyTNode<Number> left,
......@@ -3446,12 +3446,12 @@ class V8_EXPORT_PRIVATE CodeStubAssembler
void GotoIfNumberGreaterThanOrEqual(Node* left, Node* right, Label* if_false);
Node* Equal(SloppyTNode<Object> lhs, SloppyTNode<Object> rhs,
TNode<Oddball> Equal(SloppyTNode<Object> lhs, SloppyTNode<Object> rhs,
SloppyTNode<Context> context,
Variable* var_type_feedback = nullptr);
TVariable<Smi>* var_type_feedback = nullptr);
TNode<Oddball> StrictEqual(SloppyTNode<Object> lhs, SloppyTNode<Object> rhs,
Variable* var_type_feedback = nullptr);
TVariable<Smi>* var_type_feedback = nullptr);
// ECMA#sec-samevalue
// Similar to StrictEqual except that NaNs are treated as equal and minus zero
......
......@@ -1701,7 +1701,8 @@ IGNITION_HANDLER(InvokeIntrinsic, InterpreterAssembler) {
TNode<Uint32T> function_id = BytecodeOperandIntrinsicId(0);
RegListNodePair args = GetRegisterListAtOperandIndex(1);
TNode<Context> context = GetContext();
Node* result = GenerateInvokeIntrinsic(this, function_id, context, args);
TNode<Object> result =
GenerateInvokeIntrinsic(this, function_id, context, args);
SetAccumulator(result);
Dispatch();
}
......@@ -1811,7 +1812,7 @@ class InterpreterCompareOpAssembler : public InterpreterAssembler {
TNode<Context> context = GetContext();
TVARIABLE(Smi, var_type_feedback);
Node* result;
TNode<Oddball> result;
switch (compare_op) {
case Operation::kEqual:
result = Equal(lhs, rhs, context, &var_type_feedback);
......@@ -2587,8 +2588,8 @@ IGNITION_HANDLER(CreateObjectLiteral, InterpreterAssembler) {
BIND(&if_not_fast_clone);
{
// If we can't do a fast clone, call into the runtime.
Node* object_boilerplate_description =
LoadConstantPoolEntryAtOperandIndex(0);
TNode<ObjectBoilerplateDescription> object_boilerplate_description =
CAST(LoadConstantPoolEntryAtOperandIndex(0));
TNode<Context> context = GetContext();
TNode<WordT> flags_raw =
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment