Commit fdc556b4 authored by Michael Starzinger's avatar Michael Starzinger Committed by Commit Bot

[wasm] Remove dead {num_imported_functions} field.

R=clemensh@chromium.org
BUG=v8:7509

Change-Id: Ia423e60f67d3ffa8d8c2250dc9d4cdff89b91076
Reviewed-on: https://chromium-review.googlesource.com/948487
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51732}
parent 88062a2c
...@@ -1460,7 +1460,6 @@ void WasmCompiledModule::WasmCompiledModuleVerify() { ...@@ -1460,7 +1460,6 @@ void WasmCompiledModule::WasmCompiledModuleVerify() {
VerifyObjectField(knative_moduleOffset); VerifyObjectField(knative_moduleOffset);
VerifyObjectField(klazy_compile_dataOffset); VerifyObjectField(klazy_compile_dataOffset);
VerifyObjectField(kuse_trap_handlerOffset); VerifyObjectField(kuse_trap_handlerOffset);
VerifyObjectField(knum_imported_functionsOffset);
VerifyObjectField(kcode_tableOffset); VerifyObjectField(kcode_tableOffset);
VerifyObjectField(kfunction_tablesOffset); VerifyObjectField(kfunction_tablesOffset);
VerifyObjectField(kempty_function_tablesOffset); VerifyObjectField(kempty_function_tablesOffset);
......
...@@ -1363,12 +1363,6 @@ Handle<WasmCompiledModule> WasmCompiledModule::New( ...@@ -1363,12 +1363,6 @@ Handle<WasmCompiledModule> WasmCompiledModule::New(
compiled_module->InitId(); compiled_module->InitId();
compiled_module->set_code_table(*code_table); compiled_module->set_code_table(*code_table);
compiled_module->set_export_wrappers(*export_wrappers); compiled_module->set_export_wrappers(*export_wrappers);
// TODO(mtrofin): we copy these because the order of finalization isn't
// reliable, and we need these at Reset (which is called at
// finalization). If the order were reliable, and top-down, we could instead
// just get them from shared().
compiled_module->set_num_imported_functions(module->num_imported_functions);
int num_function_tables = static_cast<int>(function_tables.size()); int num_function_tables = static_cast<int>(function_tables.size());
if (num_function_tables > 0) { if (num_function_tables > 0) {
Handle<FixedArray> ft = Handle<FixedArray> ft =
...@@ -1439,9 +1433,6 @@ Handle<WasmCompiledModule> WasmCompiledModule::Clone( ...@@ -1439,9 +1433,6 @@ Handle<WasmCompiledModule> WasmCompiledModule::Clone(
ret->set_lazy_compile_data(module->lazy_compile_data()); ret->set_lazy_compile_data(module->lazy_compile_data());
} }
ret->set_use_trap_handler(module->use_trap_handler()); ret->set_use_trap_handler(module->use_trap_handler());
if (!FLAG_wasm_jit_to_native) {
ret->set_num_imported_functions(module->num_imported_functions());
}
ret->set_code_table(module->code_table()); ret->set_code_table(module->code_table());
if (module->has_function_tables()) { if (module->has_function_tables()) {
ret->set_function_tables(module->function_tables()); ret->set_function_tables(module->function_tables());
......
...@@ -443,7 +443,6 @@ class WasmCompiledModule : public Struct { ...@@ -443,7 +443,6 @@ class WasmCompiledModule : public Struct {
V(knative_moduleOffset, kPointerSize) \ V(knative_moduleOffset, kPointerSize) \
V(klazy_compile_dataOffset, kPointerSize) \ V(klazy_compile_dataOffset, kPointerSize) \
V(kuse_trap_handlerOffset, kPointerSize) \ V(kuse_trap_handlerOffset, kPointerSize) \
V(knum_imported_functionsOffset, kPointerSize) \
V(kcode_tableOffset, kPointerSize) \ V(kcode_tableOffset, kPointerSize) \
V(kfunction_tablesOffset, kPointerSize) \ V(kfunction_tablesOffset, kPointerSize) \
V(kempty_function_tablesOffset, kPointerSize) \ V(kempty_function_tablesOffset, kPointerSize) \
...@@ -500,7 +499,6 @@ class WasmCompiledModule : public Struct { ...@@ -500,7 +499,6 @@ class WasmCompiledModule : public Struct {
MACRO(OBJECT, FixedArray, lazy_compile_data) \ MACRO(OBJECT, FixedArray, lazy_compile_data) \
/* TODO(mstarzinger): Make {use_trap_handler} smaller. */ \ /* TODO(mstarzinger): Make {use_trap_handler} smaller. */ \
MACRO(SMALL_CONST_NUMBER, bool, use_trap_handler) \ MACRO(SMALL_CONST_NUMBER, bool, use_trap_handler) \
MACRO(SMALL_CONST_NUMBER, uint32_t, num_imported_functions) \
MACRO(CONST_OBJECT, FixedArray, code_table) \ MACRO(CONST_OBJECT, FixedArray, code_table) \
MACRO(OBJECT, FixedArray, function_tables) \ MACRO(OBJECT, FixedArray, function_tables) \
MACRO(CONST_OBJECT, FixedArray, empty_function_tables) MACRO(CONST_OBJECT, FixedArray, empty_function_tables)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment