Skip to content

V
V8
Commit fd40ebb1 authored by vogelheim's avatar vogelheim Committed by Commit bot
Browse files
Options

Return kBadChar for longest subpart of incomplete utf-8 character. 

This brings the two utf-8 decoders (bulk + incremental) in line.
Technically, either behaviour was correct, since the utf-8 spec
demands incomplete utf-8 be handled, but does not specify how.
Unicode recommends that "the maximal subpart at that offset
should be replaced by a single U+FFFD," and with this change we
consistently do that. More details + spec references in the bug.

BUG=chromium:662822

Review-Url: https://codereview.chromium.org/2493143003
Cr-Commit-Position: refs/heads/master@{#41025}
parent 0188c3fb
Show whitespace changes
Inline Side-by-side
Showing with 270 additions and 300 deletions
src/unicode.cc
View file @ fd40ebb1
...@@ -228,80 +228,56 @@ static inline bool IsContinuationCharacter(byte chr) { ...@@ -228,80 +228,56 @@ static inline bool IsContinuationCharacter(byte chr) {
// This method decodes an UTF-8 value according to RFC 3629. // This method decodes an UTF-8 value according to RFC 3629.
uchar Utf8::CalculateValue(const byte* str, size_t max_length, size_t* cursor) { uchar Utf8::CalculateValue(const byte* str, size_t max_length, size_t* cursor) {
size_t length = NonASCIISequenceLength(str[0]); size_t length = NonASCIISequenceLength(str[0]);
if (length == 0 || max_length < length) {
*cursor += 1; // Check continuation characters.
return kBadChar; size_t max_count = std::min(length, max_length);
} size_t count = 1;
if (length == 2) { while (count < max_count && IsContinuationCharacter(str[count])) {
if (!IsContinuationCharacter(str[1])) { count++;
*cursor += 1;
return kBadChar;
}
*cursor += 2;
return ((str[0] << 6) + str[1]) - 0x00003080;
} }
// Check overly long sequences & other conditions. Use length as error
// indicator.
if (length == 3) { if (length == 3) {
switch (str[0]) { if (str[0] == 0xE0 && (str[1] < 0xA0 || str[1] > 0xBF)) {
case 0xE0: // Overlong three-byte sequence?
// Overlong three-byte sequence. length = 0;
if (str[1] < 0xA0 || str[1] > 0xBF) { } else if (str[0] == 0xED && (str[1] < 0x80 || str[1] > 0x9F)) {
*cursor += 1; // High and low surrogate halves?
return kBadChar; length = 0;
}
break;
case 0xED:
// High and low surrogate halves.
if (str[1] < 0x80 || str[1] > 0x9F) {
*cursor += 1;
return kBadChar;
} }
break; } else if (length == 4) {
default: if (str[0] == 0xF0 && (str[1] < 0x90 || str[1] > 0xBF)) {
if (!IsContinuationCharacter(str[1])) {
*cursor += 1;
return kBadChar;
}
}
if (!IsContinuationCharacter(str[2])) {
*cursor += 1;
return kBadChar;
}
*cursor += 3;
return ((str[0] << 12) + (str[1] << 6) + str[2]) - 0x000E2080;
}
DCHECK(length == 4);
switch (str[0]) {
case 0xF0:
// Overlong four-byte sequence. // Overlong four-byte sequence.
if (str[1] < 0x90 || str[1] > 0xBF) { length = 0;
*cursor += 1; } else if (str[0] == 0xF4 && (str[1] < 0x80 || str[1] > 0x8F)) {
return kBadChar;
}
break;
case 0xF4:
// Code points outside of the unicode range. // Code points outside of the unicode range.
if (str[1] < 0x80 || str[1] > 0x8F) { length = 0;
*cursor += 1;
return kBadChar;
}
break;
default:
if (!IsContinuationCharacter(str[1])) {
*cursor += 1;
return kBadChar;
} }
} }
if (!IsContinuationCharacter(str[2])) {
*cursor += 1; if (count != length) {
return kBadChar; // All invalid encodings should land here.
} *cursor += count;
if (!IsContinuationCharacter(str[3])) {
*cursor += 1;
return kBadChar; return kBadChar;
} }
*cursor += 4;
// All errors have been handled, so we only have to assemble the result.
*cursor += length;
switch (length) {
case 1:
return str[0];
case 2:
return ((str[0] << 6) + str[1]) - 0x00003080;
case 3:
return ((str[0] << 12) + (str[1] << 6) + str[2]) - 0x000E2080;
case 4:
return ((str[0] << 18) + (str[1] << 12) + (str[2] << 6) + str[3]) - return ((str[0] << 18) + (str[1] << 12) + (str[2] << 6) + str[3]) -
0x03C82080; 0x03C82080;
}
UNREACHABLE();
return kBadChar;
} }
uchar Utf8::ValueOfIncremental(byte next, Utf8IncrementalBuffer* buffer) { uchar Utf8::ValueOfIncremental(byte next, Utf8IncrementalBuffer* buffer) {
...@@ -323,9 +299,10 @@ uchar Utf8::ValueOfIncremental(byte next, Utf8IncrementalBuffer* buffer) { ...@@ -323,9 +299,10 @@ uchar Utf8::ValueOfIncremental(byte next, Utf8IncrementalBuffer* buffer) {
// with one shift. // with one shift.
uint8_t mask = 0x7f >> kind; uint8_t mask = 0x7f >> kind;
// Store the kind - 1 (i.e., remaining bytes) in the top byte, value // Store the kind in the top nibble, and kind - 1 (i.e., remaining bytes)
// in the bottom three. // in 2nd nibble, and the value in the bottom three. The 2nd nibble is
*buffer = (kind - 1) << 24 | (next & mask); // intended as a counter about how many bytes are still needed.
*buffer = kind << 28 | (kind - 1) << 24 | (next & mask);
return kIncomplete; return kIncomplete;
} else { } else {
// No buffer, and not the start of a 1-byte char (handled at the // No buffer, and not the start of a 1-byte char (handled at the
...@@ -354,15 +331,19 @@ uchar Utf8::ValueOfIncremental(byte next, Utf8IncrementalBuffer* buffer) { ...@@ -354,15 +331,19 @@ uchar Utf8::ValueOfIncremental(byte next, Utf8IncrementalBuffer* buffer) {
// We're inside of a character, as described by buffer. // We're inside of a character, as described by buffer.
// How many bytes (excluding this one) do we still expect? // How many bytes (excluding this one) do we still expect?
uint8_t count = (*buffer >> 24) - 1; uint8_t bytes_expected = *buffer >> 28;
uint8_t bytes_left = (*buffer >> 24) & 0x0f;
bytes_left--;
// Update the value. // Update the value.
uint32_t value = ((*buffer & 0xffffff) << 6) | (next & 0x3F); uint32_t value = ((*buffer & 0xffffff) << 6) | (next & 0x3F);
if (count) { if (bytes_left) {
*buffer = count << 24 | value; *buffer = (bytes_expected << 28 | bytes_left << 24 | value);
return kIncomplete; return kIncomplete;
} else { } else {
*buffer = 0; *buffer = 0;
return value; bool sequence_was_too_long = (bytes_expected == 2 && value < 0x80) ||
(bytes_expected == 3 && value < 0x800);
return sequence_was_too_long ? kBadChar : value;
} }
} else { } else {
// Within a character, but not a continuation character? Then the // Within a character, but not a continuation character? Then the
......
test/cctest/test-parsing.cc
View file @ fd40ebb1
...@@ -700,74 +700,26 @@ TEST(RegExpScanning) { ...@@ -700,74 +700,26 @@ TEST(RegExpScanning) {
TestScanRegExp("/=?/", "=?"); TestScanRegExp("/=?/", "=?");
} }
static int Ucs2CharLength(unibrow::uchar c) {
static int Utf8LengthHelper(const char* s) { if (c == unibrow::Utf8::kIncomplete || c == unibrow::Utf8::kBufferEmpty) {
int len = i::StrLength(s); return 0;
int character_length = len; } else if (c < 0xffff) {
for (int i = 0; i < len; i++) { return 1;
unsigned char c = s[i];
int input_offset = 0;
int output_adjust = 0;
if (c > 0x7f) {
if (c < 0xc0) continue;
if (c >= 0xf0) {
if (c >= 0xf8) {
// 5 and 6 byte UTF-8 sequences turn into a kBadChar for each UTF-8
// byte.
continue; // Handle first UTF-8 byte.
}
if ((c & 7) == 0 && ((s[i + 1] & 0x30) == 0)) {
// This 4 byte sequence could have been coded as a 3 byte sequence.
// Record a single kBadChar for the first byte and continue.
continue;
}
input_offset = 3;
// 4 bytes of UTF-8 turn into 2 UTF-16 code units.
character_length -= 2;
} else if (c >= 0xe0) {
if ((c & 0xf) == 0 && ((s[i + 1] & 0x20) == 0)) {
// This 3 byte sequence could have been coded as a 2 byte sequence.
// Record a single kBadChar for the first byte and continue.
continue;
}
if (c == 0xed) {
unsigned char d = s[i + 1];
if ((d < 0x80) || (d > 0x9f)) {
// This 3 byte sequence is part of a surrogate pair which is not
// supported by UTF-8. Record a single kBadChar for the first byte
// and continue.
continue;
}
}
input_offset = 2;
// 3 bytes of UTF-8 turn into 1 UTF-16 code unit.
output_adjust = 2;
} else { } else {
if ((c & 0x1e) == 0) { return 2;
// This 2 byte sequence could have been coded as a 1 byte sequence.
// Record a single kBadChar for the first byte and continue.
continue;
}
input_offset = 1;
// 2 bytes of UTF-8 turn into 1 UTF-16 code unit.
output_adjust = 1;
}
bool bad = false;
for (int j = 1; j <= input_offset; j++) {
if ((s[i + j] & 0xc0) != 0x80) {
// Bad UTF-8 sequence turns the first in the sequence into kBadChar,
// which is a single UTF-16 code unit.
bad = true;
break;
}
}
if (!bad) {
i += input_offset;
character_length -= output_adjust;
}
} }
}
static int Utf8LengthHelper(const char* s) {
unibrow::Utf8::Utf8IncrementalBuffer buffer(unibrow::Utf8::kBufferEmpty);
int length = 0;
for (; *s != '\0'; s++) {
unibrow::uchar tmp = unibrow::Utf8::ValueOfIncremental(*s, &buffer);
length += Ucs2CharLength(tmp);
} }
return character_length; unibrow::uchar tmp = unibrow::Utf8::ValueOfIncrementalFinish(&buffer);
length += Ucs2CharLength(tmp);
return length;
} }
...@@ -994,169 +946,206 @@ TEST(ScopePositions) { ...@@ -994,169 +946,206 @@ TEST(ScopePositions) {
}; };
const SourceData source_data[] = { const SourceData source_data[] = {
{ " with ({}) ", "{ block; }", " more;", i::WITH_SCOPE, i::SLOPPY }, {" with ({}) ", "{ block; }", " more;", i::WITH_SCOPE, i::SLOPPY},
{ " with ({}) ", "{ block; }", "; more;", i::WITH_SCOPE, i::SLOPPY }, {" with ({}) ", "{ block; }", "; more;", i::WITH_SCOPE, i::SLOPPY},
{ " with ({}) ", "{\n" {" with ({}) ",
"{\n"
" block;\n" " block;\n"
" }", "\n" " }",
" more;", i::WITH_SCOPE, i::SLOPPY }, "\n"
{ " with ({}) ", "statement;", " more;", i::WITH_SCOPE, i::SLOPPY }, " more;",
{ " with ({}) ", "statement", "\n" i::WITH_SCOPE, i::SLOPPY},
" more;", i::WITH_SCOPE, i::SLOPPY }, {" with ({}) ", "statement;", " more;", i::WITH_SCOPE, i::SLOPPY},
{ " with ({})\n" {" with ({}) ", "statement",
" ", "statement;", "\n" "\n"
" more;", i::WITH_SCOPE, i::SLOPPY }, " more;",
{ " try {} catch ", "(e) { block; }", " more;", i::WITH_SCOPE, i::SLOPPY},
i::CATCH_SCOPE, i::SLOPPY }, {" with ({})\n"
{ " try {} catch ", "(e) { block; }", "; more;", " ",
i::CATCH_SCOPE, i::SLOPPY }, "statement;",
{ " try {} catch ", "(e) {\n" "\n"
" more;",
i::WITH_SCOPE, i::SLOPPY},
{" try {} catch ", "(e) { block; }", " more;", i::CATCH_SCOPE,
i::SLOPPY},
{" try {} catch ", "(e) { block; }", "; more;", i::CATCH_SCOPE,
i::SLOPPY},
{" try {} catch ",
"(e) {\n"
" block;\n" " block;\n"
" }", "\n" " }",
" more;", i::CATCH_SCOPE, i::SLOPPY }, "\n"
{ " try {} catch ", "(e) { block; }", " finally { block; } more;", " more;",
i::CATCH_SCOPE, i::SLOPPY }, i::CATCH_SCOPE, i::SLOPPY},
{ " start;\n" {" try {} catch ", "(e) { block; }", " finally { block; } more;",
" ", "{ let block; }", " more;", i::BLOCK_SCOPE, i::STRICT }, i::CATCH_SCOPE, i::SLOPPY},
{ " start;\n" {" start;\n"
" ", "{ let block; }", "; more;", i::BLOCK_SCOPE, i::STRICT }, " ",
{ " start;\n" "{ let block; }", " more;", i::BLOCK_SCOPE, i::STRICT},
" ", "{\n" {" start;\n"
" ",
"{ let block; }", "; more;", i::BLOCK_SCOPE, i::STRICT},
{" start;\n"
" ",
"{\n"
" let block;\n" " let block;\n"
" }", "\n" " }",
" more;", i::BLOCK_SCOPE, i::STRICT }, "\n"
{ " start;\n" " more;",
" function fun", "(a,b) { infunction; }", " more;", i::BLOCK_SCOPE, i::STRICT},
i::FUNCTION_SCOPE, i::SLOPPY }, {" start;\n"
{ " start;\n" " function fun",
" function fun", "(a,b) {\n" "(a,b) { infunction; }", " more;", i::FUNCTION_SCOPE, i::SLOPPY},
{" start;\n"
" function fun",
"(a,b) {\n"
" infunction;\n" " infunction;\n"
" }", "\n" " }",
" more;", i::FUNCTION_SCOPE, i::SLOPPY }, "\n"
{ " start;\n", "(a,b) => a + b", "; more;", " more;",
i::FUNCTION_SCOPE, i::SLOPPY }, i::FUNCTION_SCOPE, i::SLOPPY},
{ " start;\n", "(a,b) => { return a+b; }", "\nmore;", {" start;\n", "(a,b) => a + b", "; more;", i::FUNCTION_SCOPE, i::SLOPPY},
i::FUNCTION_SCOPE, i::SLOPPY }, {" start;\n", "(a,b) => { return a+b; }", "\nmore;", i::FUNCTION_SCOPE,
{ " start;\n" i::SLOPPY},
" (function fun", "(a,b) { infunction; }", ")();", {" start;\n"
i::FUNCTION_SCOPE, i::SLOPPY }, " (function fun",
{ " for ", "(let x = 1 ; x < 10; ++ x) { block; }", " more;", "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
i::BLOCK_SCOPE, i::STRICT }, {" for ", "(let x = 1 ; x < 10; ++ x) { block; }", " more;",
{ " for ", "(let x = 1 ; x < 10; ++ x) { block; }", "; more;", i::BLOCK_SCOPE, i::STRICT},
i::BLOCK_SCOPE, i::STRICT }, {" for ", "(let x = 1 ; x < 10; ++ x) { block; }", "; more;",
{ " for ", "(let x = 1 ; x < 10; ++ x) {\n" i::BLOCK_SCOPE, i::STRICT},
{" for ",
"(let x = 1 ; x < 10; ++ x) {\n"
" block;\n" " block;\n"
" }", "\n" " }",
" more;", i::BLOCK_SCOPE, i::STRICT }, "\n"
{ " for ", "(let x = 1 ; x < 10; ++ x) statement;", " more;", " more;",
i::BLOCK_SCOPE, i::STRICT }, i::BLOCK_SCOPE, i::STRICT},
{ " for ", "(let x = 1 ; x < 10; ++ x) statement", "\n" {" for ", "(let x = 1 ; x < 10; ++ x) statement;", " more;",
" more;", i::BLOCK_SCOPE, i::STRICT }, i::BLOCK_SCOPE, i::STRICT},
{ " for ", "(let x = 1 ; x < 10; ++ x)\n" {" for ", "(let x = 1 ; x < 10; ++ x) statement",
" statement;", "\n" "\n"
" more;", i::BLOCK_SCOPE, i::STRICT }, " more;",
{ " for ", "(let x in {}) { block; }", " more;", i::BLOCK_SCOPE, i::STRICT},
i::BLOCK_SCOPE, i::STRICT }, {" for ",
{ " for ", "(let x in {}) { block; }", "; more;", "(let x = 1 ; x < 10; ++ x)\n"
i::BLOCK_SCOPE, i::STRICT }, " statement;",
{ " for ", "(let x in {}) {\n" "\n"
" more;",
i::BLOCK_SCOPE, i::STRICT},
{" for ", "(let x in {}) { block; }", " more;", i::BLOCK_SCOPE,
i::STRICT},
{" for ", "(let x in {}) { block; }", "; more;", i::BLOCK_SCOPE,
i::STRICT},
{" for ",
"(let x in {}) {\n"
" block;\n" " block;\n"
" }", "\n" " }",
" more;", i::BLOCK_SCOPE, i::STRICT }, "\n"
{ " for ", "(let x in {}) statement;", " more;", " more;",
i::BLOCK_SCOPE, i::STRICT }, i::BLOCK_SCOPE, i::STRICT},
{ " for ", "(let x in {}) statement", "\n" {" for ", "(let x in {}) statement;", " more;", i::BLOCK_SCOPE,
" more;", i::BLOCK_SCOPE, i::STRICT }, i::STRICT},
{ " for ", "(let x in {})\n" {" for ", "(let x in {}) statement",
" statement;", "\n" "\n"
" more;", i::BLOCK_SCOPE, i::STRICT }, " more;",
i::BLOCK_SCOPE, i::STRICT},
{" for ",
"(let x in {})\n"
" statement;",
"\n"
" more;",
i::BLOCK_SCOPE, i::STRICT},
// Check that 6-byte and 4-byte encodings of UTF-8 strings do not throw // Check that 6-byte and 4-byte encodings of UTF-8 strings do not throw
// the preparser off in terms of byte offsets. // the preparser off in terms of byte offsets.
// 6 byte encoding. // 2 surrogates, encode a character that doesn't need a surrogate.
{ " 'foo\355\240\201\355\260\211';\n" {" 'foo\355\240\201\355\260\211';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// 4 byte encoding. // 4 byte encoding.
{ " 'foo\360\220\220\212';\n" {" 'foo\360\220\220\212';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// 3 byte encoding of \u0fff. // 3 byte encoding of \u0fff.
{ " 'foo\340\277\277';\n" {" 'foo\340\277\277';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Broken 6 byte encoding with missing last byte. // 3 byte surrogate, followed by broken 2-byte surrogate w/ impossible 2nd
{ " 'foo\355\240\201\355\211';\n" // byte and last byte missing.
" (function fun", "(a,b) { infunction; }", ")();", {" 'foo\355\240\201\355\211';\n"
i::FUNCTION_SCOPE, i::SLOPPY }, " (function fun",
"(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Broken 3 byte encoding of \u0fff with missing last byte. // Broken 3 byte encoding of \u0fff with missing last byte.
{ " 'foo\340\277';\n" {" 'foo\340\277';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Broken 3 byte encoding of \u0fff with missing 2 last bytes. // Broken 3 byte encoding of \u0fff with missing 2 last bytes.
{ " 'foo\340';\n" {" 'foo\340';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Broken 3 byte encoding of \u00ff should be a 2 byte encoding. // Broken 3 byte encoding of \u00ff should be a 2 byte encoding.
{ " 'foo\340\203\277';\n" {" 'foo\340\203\277';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Broken 3 byte encoding of \u007f should be a 2 byte encoding. // Broken 3 byte encoding of \u007f should be a 2 byte encoding.
{ " 'foo\340\201\277';\n" {" 'foo\340\201\277';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Unpaired lead surrogate. // Unpaired lead surrogate.
{ " 'foo\355\240\201';\n" {" 'foo\355\240\201';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Unpaired lead surrogate where following code point is a 3 byte sequence. // Unpaired lead surrogate where following code point is a 3 byte
{ " 'foo\355\240\201\340\277\277';\n" // sequence.
" (function fun", "(a,b) { infunction; }", ")();", {" 'foo\355\240\201\340\277\277';\n"
i::FUNCTION_SCOPE, i::SLOPPY }, " (function fun",
"(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Unpaired lead surrogate where following code point is a 4 byte encoding // Unpaired lead surrogate where following code point is a 4 byte encoding
// of a trail surrogate. // of a trail surrogate.
{ " 'foo\355\240\201\360\215\260\211';\n" {" 'foo\355\240\201\360\215\260\211';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Unpaired trail surrogate. // Unpaired trail surrogate.
{ " 'foo\355\260\211';\n" {" 'foo\355\260\211';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// 2 byte encoding of \u00ff. // 2 byte encoding of \u00ff.
{ " 'foo\303\277';\n" {" 'foo\303\277';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Broken 2 byte encoding of \u00ff with missing last byte. // Broken 2 byte encoding of \u00ff with missing last byte.
{ " 'foo\303';\n" {" 'foo\303';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Broken 2 byte encoding of \u007f should be a 1 byte encoding. // Broken 2 byte encoding of \u007f should be a 1 byte encoding.
{ " 'foo\301\277';\n" {" 'foo\301\277';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Illegal 5 byte encoding. // Illegal 5 byte encoding.
{ " 'foo\370\277\277\277\277';\n" {" 'foo\370\277\277\277\277';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Illegal 6 byte encoding. // Illegal 6 byte encoding.
{ " 'foo\374\277\277\277\277\277';\n" {" 'foo\374\277\277\277\277\277';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Illegal 0xfe byte // Illegal 0xfe byte
{ " 'foo\376\277\277\277\277\277\277';\n" {" 'foo\376\277\277\277\277\277\277';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
// Illegal 0xff byte // Illegal 0xff byte
{ " 'foo\377\277\277\277\277\277\277\277';\n" {" 'foo\377\277\277\277\277\277\277\277';\n"
" (function fun", "(a,b) { infunction; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { infunction; }", ")();", i::FUNCTION_SCOPE, i::SLOPPY},
{ " 'foo';\n" {" 'foo';\n"
" (function fun", "(a,b) { 'bar\355\240\201\355\260\213'; }", ")();", " (function fun",
i::FUNCTION_SCOPE, i::SLOPPY }, "(a,b) { 'bar\355\240\201\355\260\213'; }", ")();", i::FUNCTION_SCOPE,
{ " 'foo';\n" i::SLOPPY},
" (function fun", "(a,b) { 'bar\360\220\220\214'; }", ")();", {" 'foo';\n"
i::FUNCTION_SCOPE, i::SLOPPY }, " (function fun",
{ NULL, NULL, NULL, i::EVAL_SCOPE, i::SLOPPY } "(a,b) { 'bar\360\220\220\214'; }", ")();", i::FUNCTION_SCOPE,
}; i::SLOPPY},
{NULL, NULL, NULL, i::EVAL_SCOPE, i::SLOPPY}};
i::Isolate* isolate = CcTest::i_isolate(); i::Isolate* isolate = CcTest::i_isolate();
i::Factory* factory = isolate->factory(); i::Factory* factory = isolate->factory();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment