Commit fcdcff56 authored by mstarzinger's avatar mstarzinger Committed by Commit bot

[interpreter] Add test for OSR from within generators.

R=neis@chromium.org
TEST=mjsunit/ignition/osr-from-generator
BUG=v8:4764

Review-Url: https://codereview.chromium.org/2188723005
Cr-Commit-Position: refs/heads/master@{#38125}
parent 286e2b14
......@@ -722,7 +722,6 @@ void BytecodeGenerator::VisitIterationHeader(IterationStatement* stmt,
// on-stack replacement when armed for the given loop nesting depth.
if (FLAG_ignition_osr) {
// TODO(4764): Merge this with another bytecode (e.g. {Jump} back edge).
// TODO(4764): Investigate interaction with generators.
int level = Min(loop_depth_, AbstractCode::kMaxLoopNestingMarker - 1);
builder()->OsrPoll(level);
}
......
// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax
(function TestGeneratorOSRSimple() {
function* gen1() {
for (var i = 0; i < 3; ++i) {
if (i == 1) %OptimizeOsr();
}
return 23;
}
var g = gen1();
assertEquals({ value:23, done:true }, g.next());
})();
(function TestGeneratorOSRYield() {
function* gen2() {
for (var i = 0; i < 3; ++i) {
if (i == 1) %OptimizeOsr();
yield i;
}
return 23;
}
var g = gen2();
assertEquals({ value:0, done:false }, g.next());
assertEquals({ value:1, done:false }, g.next());
assertEquals({ value:2, done:false }, g.next());
assertEquals({ value:23, done:true }, g.next());
})();
(function TestGeneratorOSRNested() {
function* gen3() {
for (var i = 0; i < 3; ++i) {
for (var j = 0; j < 3; ++j) {
for (var k = 0; k < 10; ++k) {
if (k == 5) %OptimizeOsr();
}
}
yield i;
}
return 23;
}
var g = gen3();
assertEquals({ value:0, done:false }, g.next());
assertEquals({ value:1, done:false }, g.next());
assertEquals({ value:2, done:false }, g.next());
assertEquals({ value:23, done:true }, g.next());
})();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment