Re-enable embedded builtins

Enabling once again post-branch point. This CL is expected to come
with major memory improvements and slight performance regressions.

Recent work on performance improvements has focused on x64, hence only
enabling there for now.

Bug: v8:6666
Change-Id: I29dc55eb4e592465073559647e280f74253b73e1
Reviewed-on: https://chromium-review.googlesource.com/1076247
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53544}

BUILD.gn

@@ -74,8 +74,9 @@ declare_args() {
 
   # Enable embedded builtins.
   # TODO(jgruber,v8:6666): Support ia32 and maybe MSVC.
-  # TODO(jgruber,v8:6666): Re-enable.
-  v8_enable_embedded_builtins = false
+  # TODO(jgruber,v8:6666): Enable for remaining architectures once performance
+  #                        regressions are addressed.
+  v8_enable_embedded_builtins = v8_current_cpu == "x64" && (!is_win || is_clang)
 
   # Enable code-generation-time checking of types in the CodeStubAssembler.
   v8_enable_verify_csa = false

infra/mb/mb_config.pyl

@@ -417,8 +417,7 @@
     'release_x64_gcc_coverage': [
       'release_bot', 'x64', 'coverage', 'gcc', 'no_custom_libcxx', 'no_sysroot'],
     'release_x64_internal': [
-      'release_bot', 'x64', 'v8_enable_embedded_builtins',
-      'v8_snapshot_internal'],
+      'release_bot', 'x64', 'v8_snapshot_internal'],
     'release_x64_jumbo': [
       'release_bot', 'x64', 'jumbo'],
     'release_x64_jumbo_trybot': [
@@ -452,7 +451,7 @@
       'release_bot', 'x64', 'ubsan_vptr', 'minimal_symbols'],
     'release_x64_verify_csa': [
       'release_bot', 'x64', 'dcheck_always_on',
-      'v8_enable_slow_dchecks', 'v8_enable_embedded_builtins', 'v8_verify_csa'],
+      'v8_enable_slow_dchecks', 'v8_verify_csa'],
 
     # Debug configs for x64.
     'debug_x64': [
@@ -763,10 +762,6 @@
       'gn_args': 'v8_correctness_fuzzer=true v8_multi_arch_build=true',
     },
 
-    'v8_enable_embedded_builtins': {
-      'gn_args': 'v8_enable_embedded_builtins=true',
-    },
-
     'v8_enable_slow_dchecks': {
       'gn_args': 'v8_enable_slow_dchecks=true',
     },

test/mkgrokdump/mkgrokdump.cc

@@ -28,8 +28,7 @@ static const char* kHeader =
 // Non-snapshot builds allocate objects to different places.
 // Debug builds emit debug code, affecting code object sizes.
 // Embedded builtins cause objects to be allocated in different locations.
-#if !defined(V8_EMBEDDED_BUILTINS) && defined(V8_USE_SNAPSHOT) && \
-    !defined(DEBUG)
+#if defined(V8_EMBEDDED_BUILTINS) && defined(V8_USE_SNAPSHOT) && !defined(DEBUG)
 static const char* kBuild = "shipping";
 #else
 static const char* kBuild = "non-shipping";

tools/v8heapconst.py

@@ -266,33 +266,33 @@ KNOWN_MAPS = {
   ("RO_SPACE", 0x05019): (172, "Tuple2Map"),
   ("RO_SPACE", 0x05211): (170, "ScriptMap"),
   ("RO_SPACE", 0x053d9): (162, "InterceptorInfoMap"),
-  ("RO_SPACE", 0x07c09): (154, "AccessorInfoMap"),
-  ("RO_SPACE", 0x07e19): (153, "AccessCheckInfoMap"),
-  ("RO_SPACE", 0x07e81): (155, "AccessorPairMap"),
-  ("RO_SPACE", 0x07ee9): (156, "AliasedArgumentsEntryMap"),
-  ("RO_SPACE", 0x07f51): (157, "AllocationMementoMap"),
-  ("RO_SPACE", 0x07fb9): (158, "AllocationSiteMap"),
-  ("RO_SPACE", 0x08021): (159, "AsyncGeneratorRequestMap"),
-  ("RO_SPACE", 0x08089): (160, "DebugInfoMap"),
-  ("RO_SPACE", 0x080f1): (161, "FunctionTemplateInfoMap"),
-  ("RO_SPACE", 0x08159): (163, "InterpreterDataMap"),
-  ("RO_SPACE", 0x081c1): (164, "ModuleInfoEntryMap"),
-  ("RO_SPACE", 0x08229): (165, "ModuleMap"),
-  ("RO_SPACE", 0x08291): (166, "ObjectTemplateInfoMap"),
-  ("RO_SPACE", 0x082f9): (167, "PromiseCapabilityMap"),
-  ("RO_SPACE", 0x08361): (168, "PromiseReactionMap"),
-  ("RO_SPACE", 0x083c9): (169, "PrototypeInfoMap"),
-  ("RO_SPACE", 0x08431): (171, "StackFrameInfoMap"),
-  ("RO_SPACE", 0x08499): (173, "Tuple3Map"),
-  ("RO_SPACE", 0x08501): (174, "WasmCompiledModuleMap"),
-  ("RO_SPACE", 0x08569): (175, "WasmDebugInfoMap"),
-  ("RO_SPACE", 0x085d1): (176, "WasmExportedFunctionDataMap"),
-  ("RO_SPACE", 0x08639): (177, "WasmSharedModuleDataMap"),
-  ("RO_SPACE", 0x086a1): (178, "CallableTaskMap"),
-  ("RO_SPACE", 0x08709): (179, "CallbackTaskMap"),
-  ("RO_SPACE", 0x08771): (180, "PromiseFulfillReactionJobTaskMap"),
-  ("RO_SPACE", 0x087d9): (181, "PromiseRejectReactionJobTaskMap"),
-  ("RO_SPACE", 0x08841): (182, "PromiseResolveThenableJobTaskMap"),
+  ("RO_SPACE", 0x09cb9): (154, "AccessorInfoMap"),
+  ("RO_SPACE", 0x09ec9): (153, "AccessCheckInfoMap"),
+  ("RO_SPACE", 0x09f31): (155, "AccessorPairMap"),
+  ("RO_SPACE", 0x09f99): (156, "AliasedArgumentsEntryMap"),
+  ("RO_SPACE", 0x0a001): (157, "AllocationMementoMap"),
+  ("RO_SPACE", 0x0a069): (158, "AllocationSiteMap"),
+  ("RO_SPACE", 0x0a0d1): (159, "AsyncGeneratorRequestMap"),
+  ("RO_SPACE", 0x0a139): (160, "DebugInfoMap"),
+  ("RO_SPACE", 0x0a1a1): (161, "FunctionTemplateInfoMap"),
+  ("RO_SPACE", 0x0a209): (163, "InterpreterDataMap"),
+  ("RO_SPACE", 0x0a271): (164, "ModuleInfoEntryMap"),
+  ("RO_SPACE", 0x0a2d9): (165, "ModuleMap"),
+  ("RO_SPACE", 0x0a341): (166, "ObjectTemplateInfoMap"),
+  ("RO_SPACE", 0x0a3a9): (167, "PromiseCapabilityMap"),
+  ("RO_SPACE", 0x0a411): (168, "PromiseReactionMap"),
+  ("RO_SPACE", 0x0a479): (169, "PrototypeInfoMap"),
+  ("RO_SPACE", 0x0a4e1): (171, "StackFrameInfoMap"),
+  ("RO_SPACE", 0x0a549): (173, "Tuple3Map"),
+  ("RO_SPACE", 0x0a5b1): (174, "WasmCompiledModuleMap"),
+  ("RO_SPACE", 0x0a619): (175, "WasmDebugInfoMap"),
+  ("RO_SPACE", 0x0a681): (176, "WasmExportedFunctionDataMap"),
+  ("RO_SPACE", 0x0a6e9): (177, "WasmSharedModuleDataMap"),
+  ("RO_SPACE", 0x0a751): (178, "CallableTaskMap"),
+  ("RO_SPACE", 0x0a7b9): (179, "CallbackTaskMap"),
+  ("RO_SPACE", 0x0a821): (180, "PromiseFulfillReactionJobTaskMap"),
+  ("RO_SPACE", 0x0a889): (181, "PromiseRejectReactionJobTaskMap"),
+  ("RO_SPACE", 0x0a8f1): (182, "PromiseResolveThenableJobTaskMap"),
   ("MAP_SPACE", 0x02201): (1057, "ExternalMap"),
   ("MAP_SPACE", 0x02259): (1072, "JSMessageObjectMap"),
 }