[heap] Simplify PageParallelJob

Remove FinalizePageSequentially as it had only a single use case that
was tied to the full collector.

Bug: chromium:651354
Change-Id: I03299ddbd439ea273e02dd33f12c005371694130
Reviewed-on: https://chromium-review.googlesource.com/504508Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45280}

src/heap/mark-compact.h

@@ -322,8 +322,7 @@ class MarkCompactCollectorBase {
   void CreateAndExecuteEvacuationTasks(
       Collector* collector, PageParallelJob<EvacuationJobTraits>* job,
       RecordMigratedSlotVisitor* record_visitor,
-      MigrationObserver* migration_observer, const intptr_t live_bytes,
-      const int& abandoned_pages);
+      MigrationObserver* migration_observer, const intptr_t live_bytes);
 
   // Returns whether this page should be moved according to heuristics.
   bool ShouldMovePage(Page* p, intptr_t live_bytes);
@@ -695,6 +694,7 @@ class MarkCompactCollector final : public MarkCompactCollectorBase {
   void UpdatePointersAfterEvacuation() override;
 
   void ReleaseEvacuationCandidates();
+  void PostProcessEvacuationCandidates();
 
   base::Semaphore page_parallel_job_semaphore_;
 

src/heap/page-parallel-job.h

@@ -20,16 +20,10 @@ class Isolate;
 // The JobTraits class needs to define:
 // - PerPageData type - state associated with each page.
 // - PerTaskData type - state associated with each task.
-// - static bool ProcessPageInParallel(Heap* heap,
+// - static void ProcessPageInParallel(Heap* heap,
 //                                     PerTaskData task_data,
 //                                     MemoryChunk* page,
 //                                     PerPageData page_data)
-//   The function should return true iff processing succeeded.
-// - static const bool NeedSequentialFinalization
-// - static void FinalizePageSequentially(Heap* heap,
-//                                        bool processing_succeeded,
-//                                        MemoryChunk* page,
-//                                        PerPageData page_data)
 template <typename JobTraits>
 class PageParallelJob {
  public:
@@ -108,21 +102,12 @@ class PageParallelJob {
         pending_tasks_->Wait();
       }
     }
-    if (JobTraits::NeedSequentialFinalization) {
-      Item* item = items_;
-      while (item != nullptr) {
-        bool success = (item->state.Value() == kFinished);
-        JobTraits::FinalizePageSequentially(heap_, item->chunk, success,
-                                            item->data);
-        item = item->next;
-      }
-    }
   }
 
  private:
   static const int kMaxNumberOfTasks = 32;
 
-  enum ProcessingState { kAvailable, kProcessing, kFinished, kFailed };
+  enum ProcessingState { kAvailable, kProcessing, kFinished };
 
   struct Item : public Malloced {
     Item(MemoryChunk* chunk, typename JobTraits::PerPageData data, Item* next)
@@ -158,9 +143,9 @@ class PageParallelJob {
       }
       for (int i = 0; i < num_items_; i++) {
         if (current->state.TrySetValue(kAvailable, kProcessing)) {
-          bool success = JobTraits::ProcessPageInParallel(
-              heap_, data_, current->chunk, current->data);
-          current->state.SetValue(success ? kFinished : kFailed);
+          JobTraits::ProcessPageInParallel(heap_, data_, current->chunk,
+                                           current->data);
+          current->state.SetValue(kFinished);
         }
         current = current->next;
         // Wrap around if needed.