Commit fc45d0f4 authored by Stephan Herhut's avatar Stephan Herhut Committed by Commit Bot

Make V8DebuggerScript parameters const again.

This reverts a previous accidential edit.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib6a2e31f600de242e960171dd921387e897e3bc9
Reviewed-on: https://chromium-review.googlesource.com/951305Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Stephan Herhut <herhut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51831}
parent c242f27e
...@@ -156,8 +156,9 @@ String16 breakpointHint(const V8DebuggerScript& script, int lineNumber, ...@@ -156,8 +156,9 @@ String16 breakpointHint(const V8DebuggerScript& script, int lineNumber,
return hint; return hint;
} }
void adjustBreakpointLocation(V8DebuggerScript& script, const String16& hint, void adjustBreakpointLocation(const V8DebuggerScript& script,
int* lineNumber, int* columnNumber) { const String16& hint, int* lineNumber,
int* columnNumber) {
if (*lineNumber < script.startLine() || *lineNumber > script.endLine()) if (*lineNumber < script.startLine() || *lineNumber > script.endLine())
return; return;
if (hint.isEmpty()) return; if (hint.isEmpty()) return;
...@@ -466,7 +467,7 @@ Response V8DebuggerAgentImpl::setSkipAllPauses(bool skip) { ...@@ -466,7 +467,7 @@ Response V8DebuggerAgentImpl::setSkipAllPauses(bool skip) {
return Response::OK(); return Response::OK();
} }
static bool matches(V8InspectorImpl* inspector, V8DebuggerScript& script, static bool matches(V8InspectorImpl* inspector, const V8DebuggerScript& script,
BreakpointType type, const String16& selector) { BreakpointType type, const String16& selector) {
switch (type) { switch (type) {
case BreakpointType::kByUrl: case BreakpointType::kByUrl:
......
...@@ -240,7 +240,7 @@ class ActualScript : public V8DebuggerScript { ...@@ -240,7 +240,7 @@ class ActualScript : public V8DebuggerScript {
id); id);
} }
const String16& hash() override { const String16& hash() const override {
if (m_hash.isEmpty()) m_hash = calculateHash(source()); if (m_hash.isEmpty()) m_hash = calculateHash(source());
DCHECK(!m_hash.isEmpty()); DCHECK(!m_hash.isEmpty());
return m_hash; return m_hash;
...@@ -364,7 +364,7 @@ class WasmVirtualScript : public V8DebuggerScript { ...@@ -364,7 +364,7 @@ class WasmVirtualScript : public V8DebuggerScript {
return true; return true;
} }
const String16& hash() override { const String16& hash() const override {
if (m_hash.isEmpty()) { if (m_hash.isEmpty()) {
m_hash = m_wasmTranslation->GetHash(m_id, m_functionIndex); m_hash = m_wasmTranslation->GetHash(m_id, m_functionIndex);
} }
......
...@@ -60,7 +60,7 @@ class V8DebuggerScript { ...@@ -60,7 +60,7 @@ class V8DebuggerScript {
const String16& sourceURL() const; const String16& sourceURL() const;
virtual const String16& sourceMappingURL() const = 0; virtual const String16& sourceMappingURL() const = 0;
virtual const String16& source() const = 0; virtual const String16& source() const = 0;
virtual const String16& hash() = 0; virtual const String16& hash() const = 0;
virtual int startLine() const = 0; virtual int startLine() const = 0;
virtual int startColumn() const = 0; virtual int startColumn() const = 0;
virtual int endLine() const = 0; virtual int endLine() const = 0;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment