Commit fc3ecad4 authored by bmeurer's avatar bmeurer Committed by Commit bot

[turbofan] Properly connect potentially throwing ToNumber to control chain.

In JSTypedLowering we insert JSToNumber nodes for implicit type
conversions, which can potentially throw (i.e. the input not statically
known to be a plain primitive).

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/1900383002

Cr-Commit-Position: refs/heads/master@{#35639}
parent 61e97fea
......@@ -233,6 +233,8 @@ class JSBinopReduction final {
DCHECK(!NodeProperties::GetType(node)->Is(Type::PlainPrimitive()));
Node* const n = graph()->NewNode(javascript()->ToNumber(), node, context(),
frame_state, effect(), control());
Node* const if_success = graph()->NewNode(common()->IfSuccess(), n);
NodeProperties::ReplaceControlInput(node_, if_success);
NodeProperties::ReplaceUses(node_, node_, node_, n, n);
update_effect(n);
return n;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment