Commit fbc7f3ed authored by Zhi An Ng's avatar Zhi An Ng Committed by V8 LUCI CQ

Revert "Reland "[baseline] Enable concurrent sparkplug on future""

This reverts commit 72e01a06.

Reason for revert: Failing on Linux 64, local bisect to this change, run with --random-seed-stress-count=1000

Original change's description:
> Reland "[baseline] Enable concurrent sparkplug on future"
>
> This is a reland of 0e4554b4
>
> Original change's description:
> > [baseline] Enable concurrent sparkplug on future
> >
> > Bug: v8:12054
> > Change-Id: I9d5040c806232ecbe71c26b7d65acbc8005bbd00
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3233139
> > Commit-Queue: Victor Gomes <victorgomes@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#77842}
>
> Bug: v8:12054
> Change-Id: I60849c6c9c7c7e6687422669e5636b2a283cc6ff
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3275560
> Commit-Queue: Victor Gomes <victorgomes@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#77850}

TBR=leszeks@chromium.org,v8-scoped@luci-project-accounts.iam.gserviceaccount.com,victorgomes@chromium.org

Change-Id: I26b75edb26bd81128a2a266461e7a917dff3b176
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:12054
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3276912Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77858}
parent 6e9f5de2
...@@ -714,7 +714,6 @@ DEFINE_BOOL_READONLY(concurrent_sparkplug, false, ...@@ -714,7 +714,6 @@ DEFINE_BOOL_READONLY(concurrent_sparkplug, false,
#else #else
DEFINE_BOOL(concurrent_sparkplug, false, DEFINE_BOOL(concurrent_sparkplug, false,
"compile Sparkplug code in a background thread") "compile Sparkplug code in a background thread")
DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug)
#endif #endif
#else #else
DEFINE_BOOL(baseline_batch_compilation, false, "batch compile Sparkplug code") DEFINE_BOOL(baseline_batch_compilation, false, "batch compile Sparkplug code")
......
...@@ -1373,10 +1373,6 @@ static const char* call_function_test_source = ...@@ -1373,10 +1373,6 @@ static const char* call_function_test_source =
// 1 1 bar [-1] #7 // 1 1 bar [-1] #7
// 19 19 (program) [-1] #2 // 19 19 (program) [-1] #2
TEST(FunctionCallSample) { TEST(FunctionCallSample) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (i::FLAG_concurrent_sparkplug) return;
i::FLAG_allow_natives_syntax = true; i::FLAG_allow_natives_syntax = true;
LocalContext env; LocalContext env;
v8::HandleScope scope(env->GetIsolate()); v8::HandleScope scope(env->GetIsolate());
...@@ -1434,10 +1430,6 @@ static const char* function_apply_test_source = ...@@ -1434,10 +1430,6 @@ static const char* function_apply_test_source =
// 2 2 bar [-1] #16 6 // 2 2 bar [-1] #16 6
// 10 10 (program) [-1] #0 2 // 10 10 (program) [-1] #0 2
TEST(FunctionApplySample) { TEST(FunctionApplySample) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (i::FLAG_concurrent_sparkplug) return;
i::FLAG_allow_natives_syntax = true; i::FLAG_allow_natives_syntax = true;
LocalContext env; LocalContext env;
v8::HandleScope scope(env->GetIsolate()); v8::HandleScope scope(env->GetIsolate());
...@@ -1917,10 +1909,6 @@ static const char* inlining_test_source2 = R"( ...@@ -1917,10 +1909,6 @@ static const char* inlining_test_source2 = R"(
// bailed out due to 'Optimization is always disabled' // bailed out due to 'Optimization is always disabled'
// 2 (program):0 0 #2 // 2 (program):0 0 #2
TEST(Inlining2) { TEST(Inlining2) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (FLAG_concurrent_sparkplug) return;
FLAG_allow_natives_syntax = true; FLAG_allow_natives_syntax = true;
v8::Isolate* isolate = CcTest::isolate(); v8::Isolate* isolate = CcTest::isolate();
LocalContext env; LocalContext env;
...@@ -2009,10 +1997,6 @@ static const char* cross_script_source_b = R"( ...@@ -2009,10 +1997,6 @@ static const char* cross_script_source_b = R"(
)"; )";
TEST(CrossScriptInliningCallerLineNumbers) { TEST(CrossScriptInliningCallerLineNumbers) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (i::FLAG_concurrent_sparkplug) return;
i::FLAG_allow_natives_syntax = true; i::FLAG_allow_natives_syntax = true;
v8::Isolate* isolate = CcTest::isolate(); v8::Isolate* isolate = CcTest::isolate();
LocalContext env; LocalContext env;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment