Commit fb62b8c3 authored by Ross McIlroy's avatar Ross McIlroy Committed by Commit Bot

Remove over-zelous DCHECK in IdentityMap.

During scavanges multiple different ThinStrings can end up pointing to the
same internalized string. This means that the same key/value pair can be
re-inserted during rehash operations, so the values_[index] might not
be null when inserting the value.

BUG=chromium:695029

Change-Id: I5f693586bb60d5a2bbe89f05cb5b7f5fe26a23b2
Reviewed-on: https://chromium-review.googlesource.com/446380Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43379}
parent e800933e
......@@ -248,7 +248,6 @@ void IdentityMapBase::Rehash() {
for (auto pair : reinsert) {
int index = InsertKey(pair.first);
DCHECK_GE(index, 0);
DCHECK_NULL(values_[index]);
values_[index] = pair.second;
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment