Commit f95db891 authored by Igor Sheludko's avatar Igor Sheludko Committed by Commit Bot

[const-tracking] Fix incorrect DCHECK in MapUpdater

Bug: chromium:1185463, v8:9233
Change-Id: I87ad8e1ddbbf106ae5221264b53d53aded2c4c51
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739633Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73259}
parent 5ba47eed
......@@ -145,8 +145,12 @@ Handle<Map> MapUpdater::ReconfigureToDataField(InternalIndex descriptor,
PropertyConstness::kMutable,
old_details.representation(), field_type);
// The old_map_'s property must become mutable.
DCHECK_EQ(PropertyConstness::kMutable,
old_descriptors_->GetDetails(modified_descriptor_).constness());
// Note, that the {old_map_} and {old_descriptors_} are not expected to be
// updated by the generalization if the map is already deprecated.
DCHECK_IMPLIES(
!old_map_->is_deprecated(),
PropertyConstness::kMutable ==
old_descriptors_->GetDetails(modified_descriptor_).constness());
// Although the property in the old map is marked as mutable we still
// treat it as constant when merging with the new path in transition tree.
// This is fine because up until this reconfiguration the field was
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment