[wasm-simd] [liftoff] Implement bitselect on x64 and ia32

Bug: v8:9909
Change-Id: Ic6c26558c58630f0600ddf82e973d97f5414792b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2166959Reviewed-by: Zhi An Ng <zhin@chromium.org>
Commit-Queue: Fanchen Kong <fanchen.kong@intel.com>
Cr-Commit-Position: refs/heads/master@{#67414}

src/wasm/baseline/arm/liftoff-assembler-arm.h

@@ -2555,6 +2555,13 @@ void LiftoffAssembler::emit_s128_xor(LiftoffRegister dst, LiftoffRegister lhs,
        liftoff::GetSimd128Register(rhs));
 }
 
+void LiftoffAssembler::emit_s128_select(LiftoffRegister dst,
+                                        LiftoffRegister src1,
+                                        LiftoffRegister src2,
+                                        LiftoffRegister src3) {
+  bailout(kSimd, "s128select");
+}
+
 void LiftoffAssembler::emit_i8x16_sconvert_i16x8(LiftoffRegister dst,
                                                  LiftoffRegister lhs,
                                                  LiftoffRegister rhs) {

src/wasm/baseline/arm64/liftoff-assembler-arm64.h

@@ -1653,6 +1653,13 @@ void LiftoffAssembler::emit_s128_xor(LiftoffRegister dst, LiftoffRegister lhs,
   Eor(dst.fp().V16B(), lhs.fp().V16B(), rhs.fp().V16B());
 }
 
+void LiftoffAssembler::emit_s128_select(LiftoffRegister dst,
+                                        LiftoffRegister src1,
+                                        LiftoffRegister src2,
+                                        LiftoffRegister src3) {
+  bailout(kSimd, "s128select");
+}
+
 void LiftoffAssembler::emit_i8x16_sconvert_i16x8(LiftoffRegister dst,
                                                  LiftoffRegister lhs,
                                                  LiftoffRegister rhs) {

src/wasm/baseline/ia32/liftoff-assembler-ia32.h

@@ -2213,6 +2213,24 @@ void LiftoffAssembler::emit_s128_xor(LiftoffRegister dst, LiftoffRegister lhs,
       this, dst, lhs, rhs);
 }
 
+void LiftoffAssembler::emit_s128_select(LiftoffRegister dst,
+                                        LiftoffRegister src1,
+                                        LiftoffRegister src2,
+                                        LiftoffRegister src3) {
+  if (CpuFeatures::IsSupported(AVX)) {
+    CpuFeatureScope scope(this, AVX);
+    vxorps(liftoff::kScratchDoubleReg, src1.fp(), src2.fp());
+    vandps(liftoff::kScratchDoubleReg, liftoff::kScratchDoubleReg, src3.fp());
+    vxorps(dst.fp(), liftoff::kScratchDoubleReg, src2.fp());
+  } else {
+    movaps(liftoff::kScratchDoubleReg, src1.fp());
+    xorps(liftoff::kScratchDoubleReg, src2.fp());
+    andps(liftoff::kScratchDoubleReg, src3.fp());
+    if (dst.fp() != src2.fp()) movaps(dst.fp(), src2.fp());
+    xorps(dst.fp(), liftoff::kScratchDoubleReg);
+  }
+}
+
 void LiftoffAssembler::emit_i8x16_neg(LiftoffRegister dst,
                                       LiftoffRegister src) {
   if (dst.fp() == src.fp()) {

src/wasm/baseline/liftoff-assembler.h

@@ -776,6 +776,8 @@ class LiftoffAssembler : public TurboAssembler {
                            LiftoffRegister rhs);
   inline void emit_s128_xor(LiftoffRegister dst, LiftoffRegister lhs,
                             LiftoffRegister rhs);
+  inline void emit_s128_select(LiftoffRegister dst, LiftoffRegister src1,
+                               LiftoffRegister src2, LiftoffRegister src3);
   inline void emit_i8x16_neg(LiftoffRegister dst, LiftoffRegister src);
   inline void emit_i8x16_add(LiftoffRegister dst, LiftoffRegister lhs,
                              LiftoffRegister rhs);

src/wasm/baseline/liftoff-compiler.cc

@@ -2327,6 +2327,23 @@ class LiftoffCompiler {
     unsupported(decoder, kTailCall, "return_call_indirect");
   }
 
+  template <ValueType::Kind src_type, ValueType::Kind result_type,
+            typename EmitFn>
+  void EmitTerOp(EmitFn fn) {
+    static constexpr RegClass src_rc = reg_class_for(src_type);
+    static constexpr RegClass result_rc = reg_class_for(result_type);
+    LiftoffRegister src3 = __ PopToRegister();
+    LiftoffRegister src2 = __ PopToRegister(LiftoffRegList::ForRegs(src3));
+    LiftoffRegister src1 =
+        __ PopToRegister(LiftoffRegList::ForRegs(src3, src2));
+    LiftoffRegister dst =
+        src_rc == result_rc
+            ? __ GetUnusedRegister(result_rc, {src1, src2, src3})
+            : __ GetUnusedRegister(result_rc);
+    CallEmitFn(fn, dst, src1, src2, src3);
+    __ PushRegister(ValueType(result_type), dst);
+  }
+
   void SimdOp(FullDecoder* decoder, WasmOpcode opcode, Vector<Value> args,
               Value* result) {
     if (!CpuFeatures::SupportsWasmSimd128()) {
@@ -2401,6 +2418,8 @@ class LiftoffCompiler {
         return EmitBinOp<kS128, kS128>(&LiftoffAssembler::emit_s128_or);
       case wasm::kExprS128Xor:
         return EmitBinOp<kS128, kS128>(&LiftoffAssembler::emit_s128_xor);
+      case wasm::kExprS128Select:
+        return EmitTerOp<kS128, kS128>(&LiftoffAssembler::emit_s128_select);
       case wasm::kExprI8x16Neg:
         return EmitUnOp<kS128, kS128>(&LiftoffAssembler::emit_i8x16_neg);
       case wasm::kExprI8x16Add:

src/wasm/baseline/x64/liftoff-assembler-x64.h

@@ -2176,6 +2176,24 @@ void LiftoffAssembler::emit_s128_xor(LiftoffRegister dst, LiftoffRegister lhs,
       this, dst, lhs, rhs);
 }
 
+void LiftoffAssembler::emit_s128_select(LiftoffRegister dst,
+                                        LiftoffRegister src1,
+                                        LiftoffRegister src2,
+                                        LiftoffRegister src3) {
+  if (CpuFeatures::IsSupported(AVX)) {
+    CpuFeatureScope scope(this, AVX);
+    vxorps(kScratchDoubleReg, src1.fp(), src2.fp());
+    vandps(kScratchDoubleReg, kScratchDoubleReg, src3.fp());
+    vxorps(dst.fp(), kScratchDoubleReg, src2.fp());
+  } else {
+    movaps(kScratchDoubleReg, src1.fp());
+    xorps(kScratchDoubleReg, src2.fp());
+    andps(kScratchDoubleReg, src3.fp());
+    if (dst.fp() != src2.fp()) movaps(dst.fp(), src2.fp());
+    xorps(dst.fp(), kScratchDoubleReg);
+  }
+}
+
 void LiftoffAssembler::emit_i8x16_neg(LiftoffRegister dst,
                                       LiftoffRegister src) {
   if (dst.fp() == src.fp()) {