[cleanup] Mark inspector methods in subclasses with override.

Fixing clang-tidy warning.

Bug: v8:8015
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I82a169545724fca7757b2fce6b64b56d1b6264ba
Reviewed-on: https://chromium-review.googlesource.com/1225794Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Florian Sattler <sattlerf@google.com>
Cr-Commit-Position: refs/heads/master@{#55980}

src/inspector/injected-script.h

@@ -153,7 +153,7 @@ class InjectedScript final {
   class ContextScope : public Scope {
    public:
     ContextScope(V8InspectorSessionImpl*, int executionContextId);
-    ~ContextScope();
+    ~ContextScope() override;
 
    private:
     Response findInjectedScript(V8InspectorSessionImpl*) override;
@@ -165,7 +165,7 @@ class InjectedScript final {
   class ObjectScope : public Scope {
    public:
     ObjectScope(V8InspectorSessionImpl*, const String16& remoteObjectId);
-    ~ObjectScope();
+    ~ObjectScope() override;
     const String16& objectGroupName() const { return m_objectGroupName; }
     v8::Local<v8::Value> object() const { return m_object; }
 
@@ -181,7 +181,7 @@ class InjectedScript final {
   class CallFrameScope : public Scope {
    public:
     CallFrameScope(V8InspectorSessionImpl*, const String16& remoteCallFrameId);
-    ~CallFrameScope();
+    ~CallFrameScope() override;
     size_t frameOrdinal() const { return m_frameOrdinal; }
 
    private:

src/inspector/v8-debugger.h

@@ -40,7 +40,7 @@ class V8Debugger : public v8::debug::DebugDelegate,
                    public v8::debug::AsyncEventDelegate {
  public:
   V8Debugger(v8::Isolate*, V8InspectorImpl*);
-  ~V8Debugger();
+  ~V8Debugger() override;
 
   bool enabled() const;
   v8::Isolate* isolate() const { return m_isolate; }

src/inspector/v8-inspector-impl.cc

@@ -415,7 +415,7 @@ class V8InspectorImpl::EvaluateScope::TerminateTask : public v8::Task {
   TerminateTask(v8::Isolate* isolate, std::shared_ptr<CancelToken> token)
       : m_isolate(isolate), m_token(std::move(token)) {}
 
-  void Run() {
+  void Run() override {
     // CancelToken contains m_canceled bool which may be changed from main
     // thread, so lock mutex first.
     v8::base::LockGuard<v8::base::Mutex> lock(&m_token->m_mutex);

src/inspector/v8-inspector-session-impl.h

@@ -34,7 +34,7 @@ class V8InspectorSessionImpl : public V8InspectorSession,
   static std::unique_ptr<V8InspectorSessionImpl> create(
       V8InspectorImpl*, int contextGroupId, int sessionId,
       V8Inspector::Channel*, const StringView& state);
-  ~V8InspectorSessionImpl();
+  ~V8InspectorSessionImpl() override;
 
   V8InspectorImpl* inspector() const { return m_inspector; }
   V8ConsoleAgentImpl* consoleAgent() { return m_consoleAgent.get(); }

test/cctest/test-inspector.cc

@@ -20,7 +20,7 @@ namespace {
 
 class NoopChannel : public V8Inspector::Channel {
  public:
-  virtual ~NoopChannel() {}
+  ~NoopChannel() override {}
   void sendResponse(int callId,
                     std::unique_ptr<StringBuffer> message) override {}
   void sendNotification(std::unique_ptr<StringBuffer> message) override {}

test/inspector/inspector-test.cc

@@ -86,7 +86,7 @@ class FrontendChannelImpl : public v8_inspector::V8Inspector::Channel {
       : task_runner_(task_runner),
         context_group_id_(context_group_id),
         function_(isolate, function) {}
-  virtual ~FrontendChannelImpl() = default;
+  ~FrontendChannelImpl() override = default;
 
   void set_session_id(int session_id) { session_id_ = session_id; }
 
@@ -109,7 +109,7 @@ class FrontendChannelImpl : public v8_inspector::V8Inspector::Channel {
     SendMessageTask(FrontendChannelImpl* channel,
                     const std::vector<uint16_t>& message)
         : channel_(channel), message_(message) {}
-    virtual ~SendMessageTask() {}
+    ~SendMessageTask() override {}
     bool is_priority_task() final { return false; }
 
    private:
@@ -142,7 +142,7 @@ void RunSyncTask(TaskRunner* task_runner, T callback) {
    public:
     SyncTask(v8::base::Semaphore* ready_semaphore, T callback)
         : ready_semaphore_(ready_semaphore), callback_(callback) {}
-    virtual ~SyncTask() = default;
+    ~SyncTask() override = default;
     bool is_priority_task() final { return true; }
 
    private:
@@ -182,7 +182,7 @@ void RunAsyncTask(TaskRunner* task_runner,
   class AsyncTask : public TaskRunner::Task {
    public:
     explicit AsyncTask(TaskRunner::Task* inner) : inner_(inner) {}
-    virtual ~AsyncTask() = default;
+    ~AsyncTask() override = default;
     bool is_priority_task() override { return inner_->is_priority_task(); }
     void Run(IsolateData* data) override {
       data->AsyncTaskStarted(inner_.get());
@@ -216,8 +216,7 @@ class ExecuteStringTask : public TaskRunner::Task {
   ExecuteStringTask(const std::string& expression, int context_group_id)
       : expression_utf8_(expression), context_group_id_(context_group_id) {}
 
-  virtual ~ExecuteStringTask() {
-  }
+  ~ExecuteStringTask() override {}
   bool is_priority_task() override { return false; }
   void Run(IsolateData* data) override {
     v8::MicrotasksScope microtasks_scope(data->isolate(),
@@ -595,7 +594,7 @@ class SetTimeoutTask : public TaskRunner::Task {
   SetTimeoutTask(int context_group_id, v8::Isolate* isolate,
                  v8::Local<v8::Function> function)
       : function_(isolate, function), context_group_id_(context_group_id) {}
-  virtual ~SetTimeoutTask() {}
+  ~SetTimeoutTask() override {}
   bool is_priority_task() final { return false; }
 
  private:

test/inspector/task-runner.h

@@ -28,7 +28,7 @@ class TaskRunner : public v8::base::Thread {
   TaskRunner(IsolateData::SetupGlobalTasks setup_global_tasks,
              bool catch_exceptions, v8::base::Semaphore* ready_semaphore,
              v8::StartupData* startup_data, bool with_inspector);
-  virtual ~TaskRunner();
+  ~TaskRunner() override;
   IsolateData* data() const { return data_.get(); }
 
   // Thread implementation.