Commit f7f24659 authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[api] Advance many methods to V8_DEPRECATED

Marks following previously annotated V8_DEPRECATE_SOON methods as
V8_DEPRECATED:
  Value::ToBoolean
  Value::ToNumber
  Value::ToString
  Value::ToObject
  Value::ToInteger
  Value::ToInt32
  String::NewFromTwoByte
  String::NewExternal
  Date::DateTimeConfigurationChangeNotification

Bug: v8:7279, v8:7281
Change-Id: I54778ac42bd43afd2fa4f08ffc9f55e71fa43775
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552788Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60678}
parent f086b072
...@@ -2520,9 +2520,9 @@ class V8_EXPORT Value : public Data { ...@@ -2520,9 +2520,9 @@ class V8_EXPORT Value : public Data {
V8_WARN_UNUSED_RESULT MaybeLocal<BigInt> ToBigInt( V8_WARN_UNUSED_RESULT MaybeLocal<BigInt> ToBigInt(
Local<Context> context) const; Local<Context> context) const;
V8_DEPRECATE_SOON("ToBoolean can never throw. Use Local version.", V8_DEPRECATED("ToBoolean can never throw. Use Local version.",
V8_WARN_UNUSED_RESULT MaybeLocal<Boolean> ToBoolean( V8_WARN_UNUSED_RESULT MaybeLocal<Boolean> ToBoolean(
Local<Context> context) const); Local<Context> context) const);
V8_WARN_UNUSED_RESULT MaybeLocal<Number> ToNumber( V8_WARN_UNUSED_RESULT MaybeLocal<Number> ToNumber(
Local<Context> context) const; Local<Context> context) const;
V8_WARN_UNUSED_RESULT MaybeLocal<String> ToString( V8_WARN_UNUSED_RESULT MaybeLocal<String> ToString(
...@@ -2538,16 +2538,16 @@ class V8_EXPORT Value : public Data { ...@@ -2538,16 +2538,16 @@ class V8_EXPORT Value : public Data {
V8_WARN_UNUSED_RESULT MaybeLocal<Int32> ToInt32(Local<Context> context) const; V8_WARN_UNUSED_RESULT MaybeLocal<Int32> ToInt32(Local<Context> context) const;
Local<Boolean> ToBoolean(Isolate* isolate) const; Local<Boolean> ToBoolean(Isolate* isolate) const;
V8_DEPRECATE_SOON("Use maybe version", V8_DEPRECATED("Use maybe version",
Local<Number> ToNumber(Isolate* isolate) const); Local<Number> ToNumber(Isolate* isolate) const);
V8_DEPRECATE_SOON("Use maybe version", V8_DEPRECATED("Use maybe version",
Local<String> ToString(Isolate* isolate) const); Local<String> ToString(Isolate* isolate) const);
V8_DEPRECATE_SOON("Use maybe version", V8_DEPRECATED("Use maybe version",
Local<Object> ToObject(Isolate* isolate) const); Local<Object> ToObject(Isolate* isolate) const);
V8_DEPRECATE_SOON("Use maybe version", V8_DEPRECATED("Use maybe version",
Local<Integer> ToInteger(Isolate* isolate) const); Local<Integer> ToInteger(Isolate* isolate) const);
V8_DEPRECATE_SOON("Use maybe version", V8_DEPRECATED("Use maybe version",
Local<Int32> ToInt32(Isolate* isolate) const); Local<Int32> ToInt32(Isolate* isolate) const);
/** /**
* Attempts to convert a string to an array index. * Attempts to convert a string to an array index.
...@@ -2906,7 +2906,7 @@ class V8_EXPORT String : public Name { ...@@ -2906,7 +2906,7 @@ class V8_EXPORT String : public Name {
int length = -1); int length = -1);
/** Allocates a new string from UTF-16 data.*/ /** Allocates a new string from UTF-16 data.*/
static V8_DEPRECATE_SOON( static V8_DEPRECATED(
"Use maybe version", "Use maybe version",
Local<String> NewFromTwoByte(Isolate* isolate, const uint16_t* data, Local<String> NewFromTwoByte(Isolate* isolate, const uint16_t* data,
NewStringType type = kNormalString, NewStringType type = kNormalString,
...@@ -2955,7 +2955,7 @@ class V8_EXPORT String : public Name { ...@@ -2955,7 +2955,7 @@ class V8_EXPORT String : public Name {
* should the underlying buffer be deallocated or modified except through the * should the underlying buffer be deallocated or modified except through the
* destructor of the external string resource. * destructor of the external string resource.
*/ */
static V8_DEPRECATE_SOON( static V8_DEPRECATED(
"Use maybe version", "Use maybe version",
Local<String> NewExternal(Isolate* isolate, Local<String> NewExternal(Isolate* isolate,
ExternalOneByteStringResource* resource)); ExternalOneByteStringResource* resource));
...@@ -5314,11 +5314,10 @@ class V8_EXPORT Date : public Object { ...@@ -5314,11 +5314,10 @@ class V8_EXPORT Date : public Object {
* This API should not be called more than needed as it will * This API should not be called more than needed as it will
* negatively impact the performance of date operations. * negatively impact the performance of date operations.
*/ */
V8_DEPRECATE_SOON( V8_DEPRECATED("Use Isolate::DateTimeConfigurationChangeNotification",
"Use Isolate::DateTimeConfigurationChangeNotification", static void DateTimeConfigurationChangeNotification(
static void DateTimeConfigurationChangeNotification( Isolate* isolate, TimeZoneDetection time_zone_detection =
Isolate* isolate, TimeZoneDetection::kSkip));
TimeZoneDetection time_zone_detection = TimeZoneDetection::kSkip));
private: private:
static void CheckCast(Value* obj); static void CheckCast(Value* obj);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment