Commit f77d110d authored by Jakob Gruber's avatar Jakob Gruber Committed by Commit Bot

Revert "[prof] Attribute ticks in embedded builtins correctly"

This reverts commit 384a51da.

This hack is both broken (builtins now have individual symbols and no
longer resolve to v8_Default_embedded_blob_) and useless (profview
seems to detect builtins just fine without it).

Bug: v8:6666
Change-Id: I264b4de31124f1657f4dc570590eb73e53aa08d2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627344Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61842}
parent be352f7c
......@@ -178,15 +178,6 @@ CodeMap.prototype.findInTree_ = function(tree, addr) {
return node && this.isAddressBelongsTo_(addr, node) ? node : null;
};
/**
* Embedded builtins are located in the shared library but should be attributed
* according to the dynamically generated code-create events.
*
* @private
*/
CodeMap.prototype.isIsolateIndependentBuiltin_ = function(entry) {
return entry.type == "CPP" && /v8_\w*embedded_blob_/.test(entry.name);
};
/**
* Finds a code entry that contains the specified address. Both static and
......@@ -205,10 +196,7 @@ CodeMap.prototype.findAddress = function(addr) {
result = this.findInTree_(this.libraries_, addr);
if (!result) return null;
}
if (!this.isIsolateIndependentBuiltin_(result.value)) {
// Embedded builtins are handled in the following dynamic section.
return { entry : result.value, offset : addr - result.key };
}
return { entry : result.value, offset : addr - result.key };
}
var min = this.dynamics_.findMin();
var max = this.dynamics_.findMax();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment