Skip to content

V
V8
Commit f74ea020 authored by Kim-Anh Tran's avatar Kim-Anh Tran Committed by V8 LUCI CQ
Browse files
Options

[bytecode-generator] Move source code position for classes 

Move the source code position for classes to the point where the block
context has already been created. Previously, there would be a mismatch
between the context and the scope when using the ScopeIterator.

We paused at a point where, according to the source position, we already
are in a class scope, but according to the bytecode (context), we would
not yet have created the block context for the class.


Also-by: leszeks@chromium.org, jarin@chromium.org
Fixed: chromium:1259878
Change-Id: I58b84f4dcfa8c4f51e16812c7a8caa21da99f262
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3284887Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
Reviewed-by: 's avatarPatrick Thier <pthier@chromium.org>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77940}
parent 83c3489d
Hide whitespace changes
Inline Side-by-side
Showing with 107 additions and 80 deletions
src/interpreter/bytecode-array-builder.h
View file @ f74ea020
...@@ -501,6 +501,17 @@ class V8_EXPORT_PRIVATE BytecodeArrayBuilder final { ...@@ -501,6 +501,17 @@ class V8_EXPORT_PRIVATE BytecodeArrayBuilder final {
SetStatementPosition(stmt->position()); SetStatementPosition(stmt->position());
} }
BytecodeSourceInfo PopSourcePosition() {
BytecodeSourceInfo source_info = latest_source_info_;
latest_source_info_.set_invalid();
return source_info;
}
void PushSourcePosition(BytecodeSourceInfo source_info) {
DCHECK(!latest_source_info_.is_valid());
latest_source_info_ = source_info;
}
void SetStatementPosition(int position) { void SetStatementPosition(int position) {
if (position == kNoSourcePosition) return; if (position == kNoSourcePosition) return;
latest_source_info_.MakeStatementPosition(position); latest_source_info_.MakeStatementPosition(position);
......
src/interpreter/bytecode-generator.cc
View file @ f74ea020
...@@ -2776,8 +2776,14 @@ void BytecodeGenerator::VisitClassLiteral(ClassLiteral* expr, Register name) { ...@@ -2776,8 +2776,14 @@ void BytecodeGenerator::VisitClassLiteral(ClassLiteral* expr, Register name) {
CurrentScope current_scope(this, expr->scope()); CurrentScope current_scope(this, expr->scope());
DCHECK_NOT_NULL(expr->scope()); DCHECK_NOT_NULL(expr->scope());
if (expr->scope()->NeedsContext()) { if (expr->scope()->NeedsContext()) {
// Make sure to associate the source position for the class
// after the block context is created. Otherwise we have a mismatch
// between the scope and the context, where we already are in a
// block context for the class, but not yet in the class scope.
BytecodeSourceInfo source_info = builder()->PopSourcePosition();
BuildNewLocalBlockContext(expr->scope()); BuildNewLocalBlockContext(expr->scope());
ContextScope scope(this, expr->scope()); ContextScope scope(this, expr->scope());
builder()->PushSourcePosition(source_info);
BuildClassLiteral(expr, name); BuildClassLiteral(expr, name);
} else { } else {
BuildClassLiteral(expr, name); BuildClassLiteral(expr, name);
......
test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden
View file @ f74ea020
...@@ -16,11 +16,11 @@ frame size: 7 ...@@ -16,11 +16,11 @@ frame size: 7
parameter count: 1 parameter count: 1
bytecode array length: 35 bytecode array length: 35
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaTheHole), B(LdaTheHole),
B(Star5), B(Star5),
B(CreateClosure), U8(2), U8(0), U8(2), /* 30 E> */ B(CreateClosure), U8(2), U8(0), U8(2),
B(Star2), B(Star2),
B(LdaConstant), U8(1), B(LdaConstant), U8(1),
B(Star3), B(Star3),
...@@ -54,11 +54,11 @@ frame size: 7 ...@@ -54,11 +54,11 @@ frame size: 7
parameter count: 1 parameter count: 1
bytecode array length: 35 bytecode array length: 35
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaTheHole), B(LdaTheHole),
B(Star5), B(Star5),
B(CreateClosure), U8(2), U8(0), U8(2), /* 30 E> */ B(CreateClosure), U8(2), U8(0), U8(2),
B(Star2), B(Star2),
B(LdaConstant), U8(1), B(LdaConstant), U8(1),
B(Star3), B(Star3),
...@@ -191,9 +191,9 @@ frame size: 7 ...@@ -191,9 +191,9 @@ frame size: 7
parameter count: 1 parameter count: 1
bytecode array length: 60 bytecode array length: 60
bytecodes: [ bytecodes: [
/* 34 S> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaTheHole), /* 34 S> */ B(LdaTheHole),
B(Star5), B(Star5),
B(CreateClosure), U8(2), U8(0), U8(2), B(CreateClosure), U8(2), U8(0), U8(2),
B(Star2), B(Star2),
......
test/cctest/interpreter/bytecode_expectations/NewAndSpread.golden
View file @ f74ea020
...@@ -14,11 +14,11 @@ frame size: 6 ...@@ -14,11 +14,11 @@ frame size: 6
parameter count: 1 parameter count: 1
bytecode array length: 42 bytecode array length: 42
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaTheHole), B(LdaTheHole),
B(Star5), B(Star5),
B(CreateClosure), U8(2), U8(0), U8(2), /* 30 E> */ B(CreateClosure), U8(2), U8(0), U8(2),
B(Star2), B(Star2),
B(LdaConstant), U8(1), B(LdaConstant), U8(1),
B(Star3), B(Star3),
...@@ -52,11 +52,11 @@ frame size: 6 ...@@ -52,11 +52,11 @@ frame size: 6
parameter count: 1 parameter count: 1
bytecode array length: 44 bytecode array length: 44
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaTheHole), B(LdaTheHole),
B(Star5), B(Star5),
B(CreateClosure), U8(2), U8(0), U8(2), /* 30 E> */ B(CreateClosure), U8(2), U8(0), U8(2),
B(Star2), B(Star2),
B(LdaConstant), U8(1), B(LdaConstant), U8(1),
B(Star3), B(Star3),
...@@ -92,11 +92,11 @@ frame size: 7 ...@@ -92,11 +92,11 @@ frame size: 7
parameter count: 1 parameter count: 1
bytecode array length: 117 bytecode array length: 117
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaTheHole), B(LdaTheHole),
B(Star5), B(Star5),
B(CreateClosure), U8(2), U8(0), U8(2), /* 30 E> */ B(CreateClosure), U8(2), U8(0), U8(2),
B(Star2), B(Star2),
B(LdaConstant), U8(1), B(LdaConstant), U8(1),
B(Star3), B(Star3),
......
test/cctest/interpreter/bytecode_expectations/PrivateAccessorDeclaration.golden
View file @ f74ea020
...@@ -18,11 +18,11 @@ frame size: 7 ...@@ -18,11 +18,11 @@ frame size: 7
parameter count: 1 parameter count: 1
bytecode array length: 57 bytecode array length: 57
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star3), B(Star3),
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(3), U8(1), /* 30 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(3), U8(1),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
B(LdaTheHole), B(LdaTheHole),
B(Star6), B(Star6),
...@@ -67,11 +67,11 @@ frame size: 7 ...@@ -67,11 +67,11 @@ frame size: 7
parameter count: 1 parameter count: 1
bytecode array length: 54 bytecode array length: 54
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star3), B(Star3),
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(3), U8(1), /* 30 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(3), U8(1),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
B(LdaTheHole), B(LdaTheHole),
B(Star6), B(Star6),
...@@ -115,11 +115,11 @@ frame size: 7 ...@@ -115,11 +115,11 @@ frame size: 7
parameter count: 1 parameter count: 1
bytecode array length: 54 bytecode array length: 54
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star3), B(Star3),
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(3), U8(1), /* 30 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(3), U8(1),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
B(LdaTheHole), B(LdaTheHole),
B(Star6), B(Star6),
...@@ -169,11 +169,11 @@ frame size: 8 ...@@ -169,11 +169,11 @@ frame size: 8
parameter count: 1 parameter count: 1
bytecode array length: 113 bytecode array length: 113
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star4), B(Star4),
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1), /* 30 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
B(LdaTheHole), B(LdaTheHole),
B(Star7), B(Star7),
...@@ -192,11 +192,11 @@ bytecodes: [ ...@@ -192,11 +192,11 @@ bytecodes: [
B(StaCurrentContextSlot), U8(2), B(StaCurrentContextSlot), U8(2),
B(PopContext), R(2), B(PopContext), R(2),
B(Mov), R(3), R(0), B(Mov), R(3), R(0),
/* 38 E> */ B(CreateBlockContext), U8(6), B(CreateBlockContext), U8(6),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaConstant), U8(8), B(LdaConstant), U8(8),
B(Star4), B(Star4),
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1), /* 38 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
/* 118 E> */ B(CreateClosure), U8(9), U8(3), U8(2), /* 118 E> */ B(CreateClosure), U8(9), U8(3), U8(2),
B(Star3), B(Star3),
...@@ -248,11 +248,11 @@ frame size: 8 ...@@ -248,11 +248,11 @@ frame size: 8
parameter count: 1 parameter count: 1
bytecode array length: 101 bytecode array length: 101
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaTheHole), B(LdaTheHole),
B(Star6), B(Star6),
B(CreateClosure), U8(2), U8(0), U8(2), /* 30 E> */ B(CreateClosure), U8(2), U8(0), U8(2),
B(Star3), B(Star3),
B(LdaConstant), U8(1), B(LdaConstant), U8(1),
B(Star4), B(Star4),
...@@ -263,11 +263,11 @@ bytecodes: [ ...@@ -263,11 +263,11 @@ bytecodes: [
B(Star4), B(Star4),
B(PopContext), R(2), B(PopContext), R(2),
B(Mov), R(5), R(0), B(Mov), R(5), R(0),
/* 38 E> */ B(CreateBlockContext), U8(4), B(CreateBlockContext), U8(4),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaConstant), U8(6), B(LdaConstant), U8(6),
B(Star4), B(Star4),
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1), /* 38 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
/* 77 E> */ B(CreateClosure), U8(7), U8(2), U8(2), /* 77 E> */ B(CreateClosure), U8(7), U8(2), U8(2),
B(Star3), B(Star3),
...@@ -321,11 +321,11 @@ frame size: 8 ...@@ -321,11 +321,11 @@ frame size: 8
parameter count: 1 parameter count: 1
bytecode array length: 101 bytecode array length: 101
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaTheHole), B(LdaTheHole),
B(Star6), B(Star6),
B(CreateClosure), U8(2), U8(0), U8(2), /* 30 E> */ B(CreateClosure), U8(2), U8(0), U8(2),
B(Star3), B(Star3),
B(LdaConstant), U8(1), B(LdaConstant), U8(1),
B(Star4), B(Star4),
...@@ -336,11 +336,11 @@ bytecodes: [ ...@@ -336,11 +336,11 @@ bytecodes: [
B(Star4), B(Star4),
B(PopContext), R(2), B(PopContext), R(2),
B(Mov), R(5), R(0), B(Mov), R(5), R(0),
/* 38 E> */ B(CreateBlockContext), U8(4), B(CreateBlockContext), U8(4),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaConstant), U8(6), B(LdaConstant), U8(6),
B(Star4), B(Star4),
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1), /* 38 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
/* 80 E> */ B(CreateClosure), U8(7), U8(2), U8(2), /* 80 E> */ B(CreateClosure), U8(7), U8(2), U8(2),
B(Star3), B(Star3),
......
test/cctest/interpreter/bytecode_expectations/PrivateClassFields.golden
View file @ f74ea020
...@@ -26,13 +26,13 @@ frame size: 7 ...@@ -26,13 +26,13 @@ frame size: 7
parameter count: 1 parameter count: 1
bytecode array length: 116 bytecode array length: 116
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star4), B(Star4),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star4), B(Star4),
B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(4), U8(1), /* 30 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(4), U8(1),
B(StaCurrentContextSlot), U8(2), B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(Star6), B(Star6),
...@@ -48,13 +48,13 @@ bytecodes: [ ...@@ -48,13 +48,13 @@ bytecodes: [
B(StaNamedProperty), R(3), U8(5), U8(0), B(StaNamedProperty), R(3), U8(5), U8(0),
B(PopContext), R(2), B(PopContext), R(2),
B(Mov), R(3), R(0), B(Mov), R(3), R(0),
/* 38 E> */ B(CreateBlockContext), U8(6), B(CreateBlockContext), U8(6),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star4), B(Star4),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star4), B(Star4),
B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(4), U8(1), /* 38 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(4), U8(1),
B(StaCurrentContextSlot), U8(2), B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(Star6), B(Star6),
...@@ -131,13 +131,13 @@ frame size: 12 ...@@ -131,13 +131,13 @@ frame size: 12
parameter count: 1 parameter count: 1
bytecode array length: 237 bytecode array length: 237
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(3), B(PushContext), R(3),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star5), B(Star5),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star5), B(Star5),
B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(5), U8(1), /* 30 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(5), U8(1),
B(StaCurrentContextSlot), U8(2), B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(Star11), B(Star11),
...@@ -161,13 +161,13 @@ bytecodes: [ ...@@ -161,13 +161,13 @@ bytecodes: [
B(StaNamedProperty), R(4), U8(7), U8(0), B(StaNamedProperty), R(4), U8(7), U8(0),
B(PopContext), R(3), B(PopContext), R(3),
B(Mov), R(4), R(0), B(Mov), R(4), R(0),
/* 38 E> */ B(CreateBlockContext), U8(8), B(CreateBlockContext), U8(8),
B(PushContext), R(3), B(PushContext), R(3),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star5), B(Star5),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star5), B(Star5),
B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(5), U8(1), /* 38 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(5), U8(1),
B(StaCurrentContextSlot), U8(2), B(StaCurrentContextSlot), U8(2),
B(LdaConstant), U8(10), B(LdaConstant), U8(10),
B(Star5), B(Star5),
...@@ -201,13 +201,13 @@ bytecodes: [ ...@@ -201,13 +201,13 @@ bytecodes: [
B(StaNamedProperty), R(4), U8(7), U8(2), B(StaNamedProperty), R(4), U8(7), U8(2),
B(PopContext), R(3), B(PopContext), R(3),
B(Mov), R(4), R(1), B(Mov), R(4), R(1),
/* 140 E> */ B(CreateBlockContext), U8(17), B(CreateBlockContext), U8(17),
B(PushContext), R(3), B(PushContext), R(3),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star5), B(Star5),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star5), B(Star5),
B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(5), U8(1), /* 140 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateNameSymbol), R(5), U8(1),
B(StaCurrentContextSlot), U8(2), B(StaCurrentContextSlot), U8(2),
/* 356 E> */ B(CreateClosure), U8(19), U8(8), U8(2), /* 356 E> */ B(CreateClosure), U8(19), U8(8), U8(2),
B(Star4), B(Star4),
......
test/cctest/interpreter/bytecode_expectations/PrivateMethodDeclaration.golden
View file @ f74ea020
...@@ -17,11 +17,11 @@ frame size: 7 ...@@ -17,11 +17,11 @@ frame size: 7
parameter count: 1 parameter count: 1
bytecode array length: 46 bytecode array length: 46
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star3), B(Star3),
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(3), U8(1), /* 30 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(3), U8(1),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
B(CreateClosure), U8(3), U8(0), U8(2), B(CreateClosure), U8(3), U8(0), U8(2),
B(StaCurrentContextSlot), U8(2), B(StaCurrentContextSlot), U8(2),
...@@ -64,11 +64,11 @@ frame size: 8 ...@@ -64,11 +64,11 @@ frame size: 8
parameter count: 1 parameter count: 1
bytecode array length: 91 bytecode array length: 91
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star4), B(Star4),
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1), /* 30 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
B(CreateClosure), U8(3), U8(0), U8(2), B(CreateClosure), U8(3), U8(0), U8(2),
B(StaCurrentContextSlot), U8(2), B(StaCurrentContextSlot), U8(2),
...@@ -83,11 +83,11 @@ bytecodes: [ ...@@ -83,11 +83,11 @@ bytecodes: [
B(Star5), B(Star5),
B(PopContext), R(2), B(PopContext), R(2),
B(Mov), R(6), R(0), B(Mov), R(6), R(0),
/* 38 E> */ B(CreateBlockContext), U8(5), B(CreateBlockContext), U8(5),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaConstant), U8(7), B(LdaConstant), U8(7),
B(Star4), B(Star4),
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1), /* 38 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
B(CreateClosure), U8(8), U8(2), U8(2), B(CreateClosure), U8(8), U8(2), U8(2),
B(StaCurrentContextSlot), U8(2), B(StaCurrentContextSlot), U8(2),
...@@ -132,11 +132,11 @@ frame size: 8 ...@@ -132,11 +132,11 @@ frame size: 8
parameter count: 1 parameter count: 1
bytecode array length: 84 bytecode array length: 84
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaTheHole), B(LdaTheHole),
B(Star6), B(Star6),
B(CreateClosure), U8(2), U8(0), U8(2), /* 30 E> */ B(CreateClosure), U8(2), U8(0), U8(2),
B(Star3), B(Star3),
B(LdaConstant), U8(1), B(LdaConstant), U8(1),
B(Star4), B(Star4),
...@@ -147,11 +147,11 @@ bytecodes: [ ...@@ -147,11 +147,11 @@ bytecodes: [
B(Star4), B(Star4),
B(PopContext), R(2), B(PopContext), R(2),
B(Mov), R(5), R(0), B(Mov), R(5), R(0),
/* 38 E> */ B(CreateBlockContext), U8(4), B(CreateBlockContext), U8(4),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaConstant), U8(6), B(LdaConstant), U8(6),
B(Star4), B(Star4),
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1), /* 38 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
B(CreateClosure), U8(7), U8(2), U8(2), B(CreateClosure), U8(7), U8(2), U8(2),
B(StaCurrentContextSlot), U8(2), B(StaCurrentContextSlot), U8(2),
......
test/cctest/interpreter/bytecode_expectations/PublicClassFields.golden
View file @ f74ea020
...@@ -25,10 +25,10 @@ frame size: 8 ...@@ -25,10 +25,10 @@ frame size: 8
parameter count: 1 parameter count: 1
bytecode array length: 106 bytecode array length: 106
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(2), /* 30 E> */ B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(Star6), B(Star6),
B(CreateClosure), U8(2), U8(0), U8(2), B(CreateClosure), U8(2), U8(0), U8(2),
...@@ -46,10 +46,10 @@ bytecodes: [ ...@@ -46,10 +46,10 @@ bytecodes: [
B(StaNamedProperty), R(3), U8(5), U8(0), B(StaNamedProperty), R(3), U8(5), U8(0),
B(PopContext), R(2), B(PopContext), R(2),
B(Mov), R(3), R(0), B(Mov), R(3), R(0),
/* 38 E> */ B(CreateBlockContext), U8(6), B(CreateBlockContext), U8(6),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(2), /* 38 E> */ B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(Star6), B(Star6),
B(CreateClosure), U8(8), U8(2), U8(2), B(CreateClosure), U8(8), U8(2), U8(2),
...@@ -123,10 +123,10 @@ frame size: 12 ...@@ -123,10 +123,10 @@ frame size: 12
parameter count: 1 parameter count: 1
bytecode array length: 204 bytecode array length: 204
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(3), B(PushContext), R(3),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(2), /* 30 E> */ B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(Star11), B(Star11),
B(CreateClosure), U8(3), U8(0), U8(2), B(CreateClosure), U8(3), U8(0), U8(2),
...@@ -152,10 +152,10 @@ bytecodes: [ ...@@ -152,10 +152,10 @@ bytecodes: [
B(StaNamedProperty), R(4), U8(7), U8(0), B(StaNamedProperty), R(4), U8(7), U8(0),
B(PopContext), R(3), B(PopContext), R(3),
B(Mov), R(4), R(0), B(Mov), R(4), R(0),
/* 38 E> */ B(CreateBlockContext), U8(8), B(CreateBlockContext), U8(8),
B(PushContext), R(3), B(PushContext), R(3),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(2), /* 38 E> */ B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(Star11), B(Star11),
B(CreateClosure), U8(11), U8(3), U8(2), B(CreateClosure), U8(11), U8(3), U8(2),
...@@ -183,10 +183,10 @@ bytecodes: [ ...@@ -183,10 +183,10 @@ bytecodes: [
B(StaNamedProperty), R(4), U8(7), U8(2), B(StaNamedProperty), R(4), U8(7), U8(2),
B(PopContext), R(3), B(PopContext), R(3),
B(Mov), R(4), R(1), B(Mov), R(4), R(1),
/* 90 E> */ B(CreateBlockContext), U8(15), B(CreateBlockContext), U8(15),
B(PushContext), R(3), B(PushContext), R(3),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(2), /* 90 E> */ B(StaCurrentContextSlot), U8(2),
/* 236 E> */ B(CreateClosure), U8(17), U8(7), U8(2), /* 236 E> */ B(CreateClosure), U8(17), U8(7), U8(2),
B(Star4), B(Star4),
B(LdaConstant), U8(16), B(LdaConstant), U8(16),
......
test/cctest/interpreter/bytecode_expectations/StaticClassFields.golden
View file @ f74ea020
...@@ -29,10 +29,10 @@ frame size: 9 ...@@ -29,10 +29,10 @@ frame size: 9
parameter count: 1 parameter count: 1
bytecode array length: 168 bytecode array length: 168
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(2), /* 30 E> */ B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
B(LdaTheHole), B(LdaTheHole),
...@@ -63,10 +63,10 @@ bytecodes: [ ...@@ -63,10 +63,10 @@ bytecodes: [
B(CallProperty0), R(7), R(3), U8(3), B(CallProperty0), R(7), R(3), U8(3),
B(PopContext), R(2), B(PopContext), R(2),
B(Mov), R(3), R(0), B(Mov), R(3), R(0),
/* 38 E> */ B(CreateBlockContext), U8(9), B(CreateBlockContext), U8(9),
B(PushContext), R(2), B(PushContext), R(2),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(2), /* 38 E> */ B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
B(LdaTheHole), B(LdaTheHole),
...@@ -163,10 +163,10 @@ frame size: 12 ...@@ -163,10 +163,10 @@ frame size: 12
parameter count: 1 parameter count: 1
bytecode array length: 303 bytecode array length: 303
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(3), B(PushContext), R(3),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(2), /* 30 E> */ B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
B(LdaTheHole), B(LdaTheHole),
...@@ -205,10 +205,10 @@ bytecodes: [ ...@@ -205,10 +205,10 @@ bytecodes: [
B(CallProperty0), R(8), R(4), U8(3), B(CallProperty0), R(8), R(4), U8(3),
B(PopContext), R(3), B(PopContext), R(3),
B(Mov), R(4), R(0), B(Mov), R(4), R(0),
/* 38 E> */ B(CreateBlockContext), U8(11), B(CreateBlockContext), U8(11),
B(PushContext), R(3), B(PushContext), R(3),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(2), /* 38 E> */ B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
B(LdaTheHole), B(LdaTheHole),
...@@ -249,10 +249,10 @@ bytecodes: [ ...@@ -249,10 +249,10 @@ bytecodes: [
B(CallProperty0), R(8), R(4), U8(7), B(CallProperty0), R(8), R(4), U8(7),
B(PopContext), R(3), B(PopContext), R(3),
B(Mov), R(4), R(1), B(Mov), R(4), R(1),
/* 122 E> */ B(CreateBlockContext), U8(19), B(CreateBlockContext), U8(19),
B(PushContext), R(3), B(PushContext), R(3),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(2), /* 122 E> */ B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(StaCurrentContextSlot), U8(3), B(StaCurrentContextSlot), U8(3),
/* 313 E> */ B(CreateClosure), U8(21), U8(9), U8(2), /* 313 E> */ B(CreateClosure), U8(21), U8(9), U8(2),
......
test/cctest/interpreter/bytecode_expectations/StaticPrivateMethodDeclaration.golden
View file @ f74ea020
...@@ -17,9 +17,9 @@ frame size: 6 ...@@ -17,9 +17,9 @@ frame size: 6
parameter count: 1 parameter count: 1
bytecode array length: 36 bytecode array length: 36
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(CreateClosure), U8(2), U8(0), U8(2), /* 30 E> */ B(CreateClosure), U8(2), U8(0), U8(2),
B(StaCurrentContextSlot), U8(2), B(StaCurrentContextSlot), U8(2),
B(LdaTheHole), B(LdaTheHole),
B(Star5), B(Star5),
...@@ -56,11 +56,11 @@ frame size: 6 ...@@ -56,11 +56,11 @@ frame size: 6
parameter count: 1 parameter count: 1
bytecode array length: 44 bytecode array length: 44
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaTheHole), B(LdaTheHole),
B(Star5), B(Star5),
B(CreateClosure), U8(2), U8(0), U8(2), /* 30 E> */ B(CreateClosure), U8(2), U8(0), U8(2),
B(Star2), B(Star2),
B(LdaConstant), U8(1), B(LdaConstant), U8(1),
B(Star3), B(Star3),
...@@ -99,11 +99,11 @@ frame size: 6 ...@@ -99,11 +99,11 @@ frame size: 6
parameter count: 1 parameter count: 1
bytecode array length: 44 bytecode array length: 44
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaTheHole), B(LdaTheHole),
B(Star5), B(Star5),
B(CreateClosure), U8(2), U8(0), U8(2), /* 30 E> */ B(CreateClosure), U8(2), U8(0), U8(2),
B(Star2), B(Star2),
B(LdaConstant), U8(1), B(LdaConstant), U8(1),
B(Star3), B(Star3),
...@@ -143,11 +143,11 @@ frame size: 6 ...@@ -143,11 +143,11 @@ frame size: 6
parameter count: 1 parameter count: 1
bytecode array length: 47 bytecode array length: 47
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaTheHole), B(LdaTheHole),
B(Star5), B(Star5),
B(CreateClosure), U8(2), U8(0), U8(2), /* 30 E> */ B(CreateClosure), U8(2), U8(0), U8(2),
B(Star2), B(Star2),
B(LdaConstant), U8(1), B(LdaConstant), U8(1),
B(Star3), B(Star3),
...@@ -188,11 +188,11 @@ frame size: 7 ...@@ -188,11 +188,11 @@ frame size: 7
parameter count: 1 parameter count: 1
bytecode array length: 52 bytecode array length: 52
bytecodes: [ bytecodes: [
/* 30 E> */ B(CreateBlockContext), U8(0), B(CreateBlockContext), U8(0),
B(PushContext), R(1), B(PushContext), R(1),
B(LdaConstant), U8(2), B(LdaConstant), U8(2),
B(Star3), B(Star3),
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(3), U8(1), /* 30 E> */ B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(3), U8(1),
B(StaCurrentContextSlot), U8(4), B(StaCurrentContextSlot), U8(4),
B(CreateClosure), U8(3), U8(0), U8(2), B(CreateClosure), U8(3), U8(0), U8(2),
B(StaCurrentContextSlot), U8(2), B(StaCurrentContextSlot), U8(2),
......
test/debugger/regress/regress-crbug-1259878.js 0 → 100644
View file @ f74ea020
// Copyright 2021 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --enable-inspector --allow-natives-syntax
debug.Debug.setBreakPoint(f, 1);
function f() {
var C = class {};
}
f();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment