Commit f6d8ec4f authored by machenbach's avatar machenbach Committed by Commit bot

Revert of Turn on icu_case_mapping by default (patchset #3 id:40001 of...

Revert of Turn on icu_case_mapping by default (patchset #3 id:40001 of https://codereview.chromium.org/2588963002/ )

Reason for revert:
Causes gc stress failures:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/9920

Original issue's description:
> Turn on icu_case_mapping by default
>
> BUG=v8:4477, v8:4476
> TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*,
>      mjsunit/string-case, intl/general/case*
>
> Review-Url: https://codereview.chromium.org/2588963002
> Cr-Commit-Position: refs/heads/master@{#41834}
> Committed: https://chromium.googlesource.com/v8/v8/+/7c79e23c34ea971947eedc6e42d8a882617c0e47

TBR=littledan@chromium.org,yangguo@chromium.org,jshin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4477, v8:4476

Review-Url: https://codereview.chromium.org/2593543002
Cr-Commit-Position: refs/heads/master@{#41835}
parent 7c79e23c
...@@ -216,21 +216,14 @@ DEFINE_IMPLICATION(es_staging, move_object_start) ...@@ -216,21 +216,14 @@ DEFINE_IMPLICATION(es_staging, move_object_start)
#ifdef V8_I18N_SUPPORT #ifdef V8_I18N_SUPPORT
#define HARMONY_STAGED(V) \ #define HARMONY_STAGED(V) \
HARMONY_STAGED_BASE(V) \ HARMONY_STAGED_BASE(V) \
V(datetime_format_to_parts, "Intl.DateTimeFormat.formatToParts") V(datetime_format_to_parts, "Intl.DateTimeFormat.formatToParts") \
V(icu_case_mapping, "case mapping with ICU rather than Unibrow")
#else #else
#define HARMONY_STAGED(V) HARMONY_STAGED_BASE(V) #define HARMONY_STAGED(V) HARMONY_STAGED_BASE(V)
#endif #endif
// Features that are shipping (turned on by default, but internal flag remains). // Features that are shipping (turned on by default, but internal flag remains).
#define HARMONY_SHIPPING_BASE(V) V(harmony_async_await, "harmony async-await") #define HARMONY_SHIPPING(V) V(harmony_async_await, "harmony async-await")
#ifdef V8_I18N_SUPPORT
#define HARMONY_SHIPPING(V) \
HARMONY_SHIPPING_BASE(V) \
V(icu_case_mapping, "case mapping with ICU rather than Unibrow")
#else
#define HARMONY_SHIPPING(V) HARMONY_SHIPPING_BASE(V)
#endif
// Once a shipping feature has proved stable in the wild, it will be dropped // Once a shipping feature has proved stable in the wild, it will be dropped
// from HARMONY_SHIPPING, all occurrences of the FLAG_ variable are removed, // from HARMONY_SHIPPING, all occurrences of the FLAG_ variable are removed,
......
...@@ -26,8 +26,8 @@ This test checks that toLowerCase and toUpperCase handle certain non-trivial cas ...@@ -26,8 +26,8 @@ This test checks that toLowerCase and toUpperCase handle certain non-trivial cas
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS String("A𐐀").toLowerCase() is "a𐐨" FAIL String("A𐐀").toLowerCase() should be a𐐨. Was a𐐀.
PASS String("a𐐨").toUpperCase() is "A𐐀" FAIL String("a𐐨").toUpperCase() should be A𐐀. Was A𐐨.
PASS String("ΚΟΣΜΟΣ ΚΟΣΜΟΣ").toLowerCase() is "κοσμος κοσμος" PASS String("ΚΟΣΜΟΣ ΚΟΣΜΟΣ").toLowerCase() is "κοσμος κοσμος"
PASS String("ß").toUpperCase() is "SS" PASS String("ß").toUpperCase() is "SS"
PASS String("ʼn").toUpperCase() is "ʼN" PASS String("ʼn").toUpperCase() is "ʼN"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment