Commit f6d54b7c authored by Toon Verwaest's avatar Toon Verwaest Committed by Commit Bot

[sparkplug] Reenable write_protect_code_memory for sparkplug

By using RWX memory to write we've likely managed to avoid the largest
part of the cost on Intel CPUs.

Bug: v8:11420
Change-Id: Ibf571abc136fc97b3e6429fe42ebf4cfc423b458
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2824443
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Auto-Submit: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73947}
parent 2bbc2eab
......@@ -624,10 +624,6 @@ DEFINE_IMPLICATION(always_sparkplug, sparkplug)
#endif
DEFINE_STRING(sparkplug_filter, "*", "filter for Sparkplug baseline compiler")
DEFINE_BOOL(trace_baseline, false, "trace baseline compilation")
#if !defined(V8_OS_MACOSX) || !defined(V8_HOST_ARCH_ARM64)
// Don't disable --write-protect-code-memory on Apple Silicon.
DEFINE_WEAK_VALUE_IMPLICATION(sparkplug, write_protect_code_memory, false)
#endif
#undef FLAG
#define FLAG FLAG_FULL
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment