Commit f5e8645f authored by Michael Lippautz's avatar Michael Lippautz Committed by Commit Bot

ManualGCScope: Disable ineffective GC detection

The manual scope is usually used to test corner cases of GC behavior so
disable the ineffective GC detecton there.

Bug: v8:7859
Change-Id: I92a1e43db739846ff0db20a60cc2ace79496e5fe
Reviewed-on: https://chromium-review.googlesource.com/1135140Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54418}
parent 53c7798c
...@@ -640,18 +640,23 @@ class ManualGCScope { ...@@ -640,18 +640,23 @@ class ManualGCScope {
: flag_concurrent_marking_(i::FLAG_concurrent_marking), : flag_concurrent_marking_(i::FLAG_concurrent_marking),
flag_concurrent_sweeping_(i::FLAG_concurrent_sweeping), flag_concurrent_sweeping_(i::FLAG_concurrent_sweeping),
flag_stress_incremental_marking_(i::FLAG_stress_incremental_marking), flag_stress_incremental_marking_(i::FLAG_stress_incremental_marking),
flag_parallel_marking_(i::FLAG_parallel_marking) { flag_parallel_marking_(i::FLAG_parallel_marking),
flag_detect_ineffective_gcs_near_heap_limit_(
i::FLAG_detect_ineffective_gcs_near_heap_limit) {
i::FLAG_concurrent_marking = false; i::FLAG_concurrent_marking = false;
i::FLAG_concurrent_sweeping = false; i::FLAG_concurrent_sweeping = false;
i::FLAG_stress_incremental_marking = false; i::FLAG_stress_incremental_marking = false;
// Parallel marking has a dependency on concurrent marking. // Parallel marking has a dependency on concurrent marking.
i::FLAG_parallel_marking = false; i::FLAG_parallel_marking = false;
i::FLAG_detect_ineffective_gcs_near_heap_limit = false;
} }
~ManualGCScope() { ~ManualGCScope() {
i::FLAG_concurrent_marking = flag_concurrent_marking_; i::FLAG_concurrent_marking = flag_concurrent_marking_;
i::FLAG_concurrent_sweeping = flag_concurrent_sweeping_; i::FLAG_concurrent_sweeping = flag_concurrent_sweeping_;
i::FLAG_stress_incremental_marking = flag_stress_incremental_marking_; i::FLAG_stress_incremental_marking = flag_stress_incremental_marking_;
i::FLAG_parallel_marking = flag_parallel_marking_; i::FLAG_parallel_marking = flag_parallel_marking_;
i::FLAG_detect_ineffective_gcs_near_heap_limit =
flag_detect_ineffective_gcs_near_heap_limit_;
} }
private: private:
...@@ -659,6 +664,7 @@ class ManualGCScope { ...@@ -659,6 +664,7 @@ class ManualGCScope {
bool flag_concurrent_sweeping_; bool flag_concurrent_sweeping_;
bool flag_stress_incremental_marking_; bool flag_stress_incremental_marking_;
bool flag_parallel_marking_; bool flag_parallel_marking_;
bool flag_detect_ineffective_gcs_near_heap_limit_;
}; };
// This is an abstract base class that can be overridden to implement a test // This is an abstract base class that can be overridden to implement a test
......
...@@ -125,9 +125,6 @@ ...@@ -125,9 +125,6 @@
'test-serialize/SnapshotCreatorNoExternalReferencesCustomFail1': [FAIL], 'test-serialize/SnapshotCreatorNoExternalReferencesCustomFail1': [FAIL],
'test-serialize/SnapshotCreatorNoExternalReferencesCustomFail2': [FAIL], 'test-serialize/SnapshotCreatorNoExternalReferencesCustomFail2': [FAIL],
# https://crbug.com/v8/7859
'test-heap/Regress538257': [SKIP],
############################################################################ ############################################################################
# Slow tests. # Slow tests.
'test-debug/CallFunctionInDebugger': [PASS, ['mode == debug', SLOW]], 'test-debug/CallFunctionInDebugger': [PASS, ['mode == debug', SLOW]],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment