Skip to content

V
V8
Commit f5d42fc4 authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot
Browse files
Options

Revert "[coverage] Ship block coverage" 

This reverts commit 7bb6cd63.

Reason for revert: layout tests

Original change's description:
> [coverage] Ship block coverage
> 
> Enables block coverage by default.
> 
> Design doc: http://goo.gl/hSJhXn
> Tracking bug: http://crbug.com/v8/6000
> 
> Bug: v8:6000
> Change-Id: I8c56474473b60e4707b75dc601b3e88455861a27
> Reviewed-on: https://chromium-review.googlesource.com/583093
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#46898}

NOTRY=true
TBR=yangguo@chromium.org,jgruber@chromium.org

Change-Id: I51d6f13d3ad0d2d2262bdd8d67135931cbc27032
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:6000
Reviewed-on: https://chromium-review.googlesource.com/588789Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46923}
parent 337f38e0
Hide whitespace changes
Inline Side-by-side
Showing with 22 additions and 92 deletions
src/flag-definitions.h
View file @ f5d42fc4
......@@ -289,7 +289,7 @@ DEFINE_BOOL(track_field_types, true, "track field types")
DEFINE_IMPLICATION(track_field_types, track_fields)
DEFINE_IMPLICATION(track_field_types, track_heap_object_fields)
DEFINE_BOOL(type_profile, false, "collect type information")
DEFINE_BOOL(block_coverage, true, "enable block code coverage")
DEFINE_BOOL(block_coverage, false, "collect block coverage information")
DEFINE_BOOL(trace_block_coverage, false,
"trace collected block coverage information")
DEFINE_IMPLICATION(trace_block_coverage, block_coverage)
......
test/inspector/cpu-profiler/coverage-expected.txt
View file @ f5d42fc4
......@@ -52,7 +52,7 @@ Running test: testPreciseCountCoverage
functions : [
[0] : {
functionName :
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
......@@ -63,28 +63,13 @@ Running test: testPreciseCountCoverage
}
[1] : {
functionName : fib
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 15
endOffset : 73
startOffset : 1
}
[1] : {
count : 8
endOffset : 41
startOffset : 32
}
[2] : {
count : 7
endOffset : 71
startOffset : 41
}
[3] : {
count : 0
endOffset : 73
startOffset : 71
}
]
}
[2] : {
......@@ -100,18 +85,13 @@ Running test: testPreciseCountCoverage
}
[3] : {
functionName : iife
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
endOffset : 208
startOffset : 177
}
[1] : {
count : 0
endOffset : 208
startOffset : 206
}
]
}
]
......@@ -122,7 +102,7 @@ Running test: testPreciseCountCoverage
functions : [
[0] : {
functionName :
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
......@@ -578,7 +558,7 @@ Running test: testEnablePreciseCountCoverageAtPause
functions : [
[0] : {
functionName :
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
......@@ -614,7 +594,7 @@ Running test: testPreciseBinaryCoverage
functions : [
[0] : {
functionName :
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
......@@ -625,28 +605,13 @@ Running test: testPreciseBinaryCoverage
}
[1] : {
functionName : fib
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
endOffset : 73
startOffset : 1
}
[1] : {
count : 1
endOffset : 41
startOffset : 32
}
[2] : {
count : 1
endOffset : 71
startOffset : 41
}
[3] : {
count : 0
endOffset : 73
startOffset : 71
}
]
}
[2] : {
......@@ -662,18 +627,13 @@ Running test: testPreciseBinaryCoverage
}
[3] : {
functionName : iife
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
endOffset : 208
startOffset : 177
}
[1] : {
count : 0
endOffset : 208
startOffset : 206
}
]
}
]
......@@ -719,18 +679,13 @@ Running test: testPreciseBinaryCoverage
functions : [
[0] : {
functionName : is_optimized
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
endOffset : 175
startOffset : 74
}
[1] : {
count : 0
endOffset : 175
startOffset : 173
}
]
}
]
......@@ -741,7 +696,7 @@ Running test: testPreciseBinaryCoverage
functions : [
[0] : {
functionName :
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
......@@ -758,7 +713,7 @@ Running test: testPreciseBinaryCoverage
functions : [
[0] : {
functionName :
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
......@@ -801,7 +756,7 @@ Running test: testPreciseCountCoveragePartial
functions : [
[0] : {
functionName :
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
......@@ -812,71 +767,51 @@ Running test: testPreciseCountCoveragePartial
}
[1] : {
functionName : outer
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
endOffset : 224
startOffset : 10
}
[1] : {
count : 0
endOffset : 224
startOffset : 222
}
]
}
[2] : {
functionName : nested_0
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
endOffset : 176
startOffset : 31
}
[1] : {
count : 0
endOffset : 176
startOffset : 172
}
]
}
[3] : {
functionName : nested_1
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
endOffset : 172
startOffset : 64
}
[1] : {
count : 0
endOffset : 172
startOffset : 166
}
]
}
[4] : {
functionName : nested_2
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
endOffset : 166
startOffset : 99
}
[1] : {
count : 0
endOffset : 166
startOffset : 158
}
]
}
[5] : {
functionName : nested_3
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
......@@ -911,23 +846,18 @@ Running test: testPreciseCountCoveragePartial
functions : [
[0] : {
functionName : nested_1
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
endOffset : 172
startOffset : 64
}
[1] : {
count : 0
endOffset : 172
startOffset : 166
}
]
}
[1] : {
functionName : nested_2
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 0
......@@ -944,7 +874,7 @@ Running test: testPreciseCountCoveragePartial
functions : [
[0] : {
functionName :
isBlockCoverage : true
isBlockCoverage : false
ranges : [
[0] : {
count : 1
......
test/inspector/cpu-profiler/coverage.js
View file @ f5d42fc4
......@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --no-always-opt --opt --no-stress-fullcodegen
// Flags: --allow-natives-syntax --no-always-opt --opt
var source =
`
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment