[compiler] Optimize Instruction::IsTailCall

Moves the TailCall instruction codes to the start of the enum, and
changes the test for IsTailCall from 4 equality tests to a single
inequality.

Bug: v8:10051
Change-Id: I679d6377161bd4f9a05f6202763d52c0a67b7900
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1964075Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65440}

src/compiler/backend/instruction-codes.h

@@ -64,18 +64,21 @@ inline RecordWriteMode WriteBarrierKindToRecordWriteMode(
 // Target-specific opcodes that specify which assembly sequence to emit.
 // Most opcodes specify a single instruction.
 #define COMMON_ARCH_OPCODE_LIST(V)                                     \
-  V(ArchCallCodeObject)                   \
+  /* Tail call opcodes are grouped together to make IsTailCall fast */ \
   V(ArchTailCallCodeObjectFromJSFunction)                              \
   V(ArchTailCallCodeObject)                                            \
-  V(ArchCallJSFunction)                   \
   V(ArchTailCallAddress)                                               \
+  V(ArchTailCallWasm)                                                  \
+  /* Update IsTailCall if further TailCall opcodes are added */        \
+                                                                       \
+  V(ArchCallCodeObject)                                                \
+  V(ArchCallJSFunction)                                                \
   V(ArchPrepareCallCFunction)                                          \
   V(ArchSaveCallerRegisters)                                           \
   V(ArchRestoreCallerRegisters)                                        \
   V(ArchCallCFunction)                                                 \
   V(ArchPrepareTailCall)                                               \
   V(ArchCallWasmFunction)                                              \
-  V(ArchTailCallWasm)                     \
   V(ArchCallBuiltinPointer)                                            \
   V(ArchJmp)                                                           \
   V(ArchBinarySearchSwitch)                                            \

src/compiler/backend/instruction.h

@@ -861,10 +861,7 @@ class V8_EXPORT_PRIVATE Instruction final {
   bool IsJump() const { return arch_opcode() == ArchOpcode::kArchJmp; }
   bool IsRet() const { return arch_opcode() == ArchOpcode::kArchRet; }
   bool IsTailCall() const {
-    return arch_opcode() == ArchOpcode::kArchTailCallCodeObject ||
-           arch_opcode() == ArchOpcode::kArchTailCallCodeObjectFromJSFunction ||
-           arch_opcode() == ArchOpcode::kArchTailCallAddress ||
-           arch_opcode() == ArchOpcode::kArchTailCallWasm;
+    return arch_opcode() <= ArchOpcode::kArchTailCallWasm;
   }
   bool IsThrow() const {
     return arch_opcode() == ArchOpcode::kArchThrowTerminator;