Commit f2c0e06e authored by yurys@chromium.org's avatar yurys@chromium.org

Remove unused method and add line breaks after each serialized edge

Review URL: https://chromiumcodereview.appspot.com/10874063

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12381 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 2aad64d9
...@@ -2578,20 +2578,6 @@ void V8HeapExplorer::SetPropertyReference(HeapObject* parent_obj, ...@@ -2578,20 +2578,6 @@ void V8HeapExplorer::SetPropertyReference(HeapObject* parent_obj,
} }
void V8HeapExplorer::SetPropertyShortcutReference(HeapObject* parent_obj,
int parent_entry,
String* reference_name,
Object* child_obj) {
HeapEntry* child_entry = GetEntry(child_obj);
if (child_entry != NULL) {
filler_->SetNamedReference(HeapGraphEdge::kShortcut,
parent_entry,
collection_->names()->GetName(reference_name),
child_entry);
}
}
void V8HeapExplorer::SetRootGcRootsReference() { void V8HeapExplorer::SetRootGcRootsReference() {
filler_->SetIndexedAutoIndexReference( filler_->SetIndexedAutoIndexReference(
HeapGraphEdge::kElement, HeapGraphEdge::kElement,
...@@ -3363,9 +3349,9 @@ static int utoa(unsigned value, const Vector<char>& buffer, int buffer_pos) { ...@@ -3363,9 +3349,9 @@ static int utoa(unsigned value, const Vector<char>& buffer, int buffer_pos) {
void HeapSnapshotJSONSerializer::SerializeEdge(HeapGraphEdge* edge, void HeapSnapshotJSONSerializer::SerializeEdge(HeapGraphEdge* edge,
bool first_edge) { bool first_edge) {
// The buffer needs space for 3 unsigned ints, 3 commas and \0 // The buffer needs space for 3 unsigned ints, 3 commas, \n and \0
static const int kBufferSize = static const int kBufferSize =
MaxDecimalDigitsIn<sizeof(unsigned)>::kUnsigned * 3 + 3 + 1; // NOLINT MaxDecimalDigitsIn<sizeof(unsigned)>::kUnsigned * 3 + 3 + 2; // NOLINT
EmbeddedVector<char, kBufferSize> buffer; EmbeddedVector<char, kBufferSize> buffer;
int edge_name_or_index = edge->type() == HeapGraphEdge::kElement int edge_name_or_index = edge->type() == HeapGraphEdge::kElement
|| edge->type() == HeapGraphEdge::kHidden || edge->type() == HeapGraphEdge::kHidden
...@@ -3380,6 +3366,7 @@ void HeapSnapshotJSONSerializer::SerializeEdge(HeapGraphEdge* edge, ...@@ -3380,6 +3366,7 @@ void HeapSnapshotJSONSerializer::SerializeEdge(HeapGraphEdge* edge,
buffer_pos = utoa(edge_name_or_index, buffer, buffer_pos); buffer_pos = utoa(edge_name_or_index, buffer, buffer_pos);
buffer[buffer_pos++] = ','; buffer[buffer_pos++] = ',';
buffer_pos = utoa(entry_index(edge->to()), buffer, buffer_pos); buffer_pos = utoa(entry_index(edge->to()), buffer, buffer_pos);
buffer[buffer_pos++] = '\n';
buffer[buffer_pos++] = '\0'; buffer[buffer_pos++] = '\0';
writer_->AddString(buffer.start()); writer_->AddString(buffer.start());
} }
......
...@@ -925,10 +925,6 @@ class V8HeapExplorer : public HeapEntriesAllocator { ...@@ -925,10 +925,6 @@ class V8HeapExplorer : public HeapEntriesAllocator {
Object* child, Object* child,
const char* name_format_string = NULL, const char* name_format_string = NULL,
int field_offset = -1); int field_offset = -1);
void SetPropertyShortcutReference(HeapObject* parent_obj,
int parent,
String* reference_name,
Object* child);
void SetUserGlobalReference(Object* user_global); void SetUserGlobalReference(Object* user_global);
void SetRootGcRootsReference(); void SetRootGcRootsReference();
void SetGcRootsReference(VisitorSynchronization::SyncTag tag); void SetGcRootsReference(VisitorSynchronization::SyncTag tag);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment