Commit f2ad990f authored by Michael Starzinger's avatar Michael Starzinger Committed by Commit Bot

Fix bogus implication from --turbo to --crankshaft.

Now that the --turbo flag is on by default, this implication makes it
impossible to disable the runtime profiler to prevent functions from
being considered hot. Essentially the --nocrankshaft flag was borked.

R=machenbach@chromium.org

Change-Id: I698008b4b69038e8bfab6d8ec3ccf57e2fd71701
Reviewed-on: https://chromium-review.googlesource.com/452619Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43720}
parent 146c9e54
......@@ -515,8 +515,6 @@ DEFINE_BOOL(turbo_store_elimination, true,
"enable store-store elimination in TurboFan")
DEFINE_BOOL(turbo_experimental, false,
"enable crashing features, for testing purposes only")
// TODO(turbofan): Rename --crankshaft to --optimize eventually.
DEFINE_IMPLICATION(turbo, crankshaft)
// Flags to help platform porters
DEFINE_BOOL(minimal, false,
......
......@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --turbo
// Flags: --allow-natives-syntax --turbo --crankshaft
function CompareNegate(a,b) {
a = a|0;
......
......@@ -3,7 +3,7 @@
// found in the LICENSE file.
// MODULE
// Flags: --allow-natives-syntax --turbo
// Flags: --allow-natives-syntax --turbo --crankshaft
export let x = 0;
function foo() { x++ };
......
......@@ -3,7 +3,7 @@
// found in the LICENSE file.
//
// Flags: --mark-shared-functions-for-tier-up --allow-natives-syntax
// Flags: --ignition-staging --turbo --no-always-opt
// Flags: --ignition-staging --turbo --crankshaft --no-always-opt
// If we are always or never optimizing it is useless.
assertFalse(isAlwaysOptimize());
......
......@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --expose-gc --turbo
// Flags: --allow-natives-syntax --expose-gc --turbo --crankshaft
// Make sure literals are strongly rooted and safe from weak-code deopts.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment