Commit f28f16c9 authored by mstarzinger's avatar mstarzinger Committed by Commit bot

[turbofan] Remove obsolete 'incomplete' flag from GraphDecorator.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/1187263003

Cr-Commit-Position: refs/heads/master@{#29088}
parent ddac0066
...@@ -22,9 +22,9 @@ Graph::Graph(Zone* zone) ...@@ -22,9 +22,9 @@ Graph::Graph(Zone* zone)
decorators_(zone) {} decorators_(zone) {}
void Graph::Decorate(Node* node, bool incomplete) { void Graph::Decorate(Node* node) {
for (auto const decorator : decorators_) { for (auto const decorator : decorators_) {
decorator->Decorate(node, incomplete); decorator->Decorate(node);
} }
} }
...@@ -46,7 +46,7 @@ Node* Graph::NewNode(const Operator* op, int input_count, Node** inputs, ...@@ -46,7 +46,7 @@ Node* Graph::NewNode(const Operator* op, int input_count, Node** inputs,
DCHECK_LE(op->ValueInputCount(), input_count); DCHECK_LE(op->ValueInputCount(), input_count);
Node* const node = Node* const node =
Node::New(zone(), NextNodeId(), op, input_count, inputs, incomplete); Node::New(zone(), NextNodeId(), op, input_count, inputs, incomplete);
Decorate(node, incomplete); Decorate(node);
return node; return node;
} }
......
...@@ -92,7 +92,7 @@ class Graph : public ZoneObject { ...@@ -92,7 +92,7 @@ class Graph : public ZoneObject {
size_t NodeCount() const { return next_node_id_; } size_t NodeCount() const { return next_node_id_; }
void Decorate(Node* node, bool incomplete); void Decorate(Node* node);
void AddDecorator(GraphDecorator* decorator); void AddDecorator(GraphDecorator* decorator);
void RemoveDecorator(GraphDecorator* decorator); void RemoveDecorator(GraphDecorator* decorator);
...@@ -117,7 +117,7 @@ class Graph : public ZoneObject { ...@@ -117,7 +117,7 @@ class Graph : public ZoneObject {
class GraphDecorator : public ZoneObject { class GraphDecorator : public ZoneObject {
public: public:
virtual ~GraphDecorator() {} virtual ~GraphDecorator() {}
virtual void Decorate(Node* node, bool incomplete) = 0; virtual void Decorate(Node* node) = 0;
}; };
} // namespace compiler } // namespace compiler
......
...@@ -15,7 +15,7 @@ class SourcePositionTable::Decorator final : public GraphDecorator { ...@@ -15,7 +15,7 @@ class SourcePositionTable::Decorator final : public GraphDecorator {
explicit Decorator(SourcePositionTable* source_positions) explicit Decorator(SourcePositionTable* source_positions)
: source_positions_(source_positions) {} : source_positions_(source_positions) {}
void Decorate(Node* node, bool incomplete) final { void Decorate(Node* node) final {
source_positions_->table_.Set(node, source_positions_->current_position_); source_positions_->table_.Set(node, source_positions_->current_position_);
} }
......
...@@ -157,7 +157,7 @@ class LazyTypeCache final : public ZoneObject { ...@@ -157,7 +157,7 @@ class LazyTypeCache final : public ZoneObject {
class Typer::Decorator final : public GraphDecorator { class Typer::Decorator final : public GraphDecorator {
public: public:
explicit Decorator(Typer* typer) : typer_(typer) {} explicit Decorator(Typer* typer) : typer_(typer) {}
void Decorate(Node* node, bool incomplete) final; void Decorate(Node* node) final;
private: private:
Typer* typer_; Typer* typer_;
...@@ -441,8 +441,7 @@ void Typer::Run(const NodeVector& roots) { ...@@ -441,8 +441,7 @@ void Typer::Run(const NodeVector& roots) {
} }
void Typer::Decorator::Decorate(Node* node, bool incomplete) { void Typer::Decorator::Decorate(Node* node) {
if (incomplete) return;
if (node->op()->ValueOutputCount() > 0) { if (node->op()->ValueOutputCount() > 0) {
// Only eagerly type-decorate nodes with known input types. // Only eagerly type-decorate nodes with known input types.
// Other cases will generally require a proper fixpoint iteration with Run. // Other cases will generally require a proper fixpoint iteration with Run.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment