Commit f24b38af authored by Clemens Backes's avatar Clemens Backes Committed by V8 LUCI CQ

[cleanup][wasm] Remove redundant NOLINT annotations

cpplint rules change over time, and we change the exact rules we enable
for v8. This CL removes NOLINT annotations which are not needed
according to the currently enabled rules.

R=jkummerow@chromium.org

Bug: v8:11717
Change-Id: I5e6261c9a4825f6b58068d57327601723edfa481
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859948Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74296}
parent e13a744a
...@@ -4299,7 +4299,6 @@ class LiftoffCompiler { ...@@ -4299,7 +4299,6 @@ class LiftoffCompiler {
std::initializer_list<LiftoffAssembler::VarState> params, std::initializer_list<LiftoffAssembler::VarState> params,
int position) { int position) {
DEBUG_CODE_COMMENT( DEBUG_CODE_COMMENT(
// NOLINTNEXTLINE(whitespace/braces)
(std::string{"call builtin: "} + GetRuntimeStubName(stub_id)).c_str()); (std::string{"call builtin: "} + GetRuntimeStubName(stub_id)).c_str());
auto interface_descriptor = Builtins::CallInterfaceDescriptorFor( auto interface_descriptor = Builtins::CallInterfaceDescriptorFor(
RuntimeStubIdToBuiltinName(stub_id)); RuntimeStubIdToBuiltinName(stub_id));
......
...@@ -455,8 +455,7 @@ struct FuncTypeImpl : ExternTypeImpl { ...@@ -455,8 +455,7 @@ struct FuncTypeImpl : ExternTypeImpl {
ownvec<ValType> params; ownvec<ValType> params;
ownvec<ValType> results; ownvec<ValType> results;
FuncTypeImpl(ownvec<ValType>& params, // NOLINT(runtime/references) FuncTypeImpl(ownvec<ValType>& params, ownvec<ValType>& results)
ownvec<ValType>& results) // NOLINT(runtime/references)
: ExternTypeImpl(EXTERN_FUNC), : ExternTypeImpl(EXTERN_FUNC),
params(std::move(params)), params(std::move(params)),
results(std::move(results)) {} results(std::move(results)) {}
...@@ -507,8 +506,7 @@ struct GlobalTypeImpl : ExternTypeImpl { ...@@ -507,8 +506,7 @@ struct GlobalTypeImpl : ExternTypeImpl {
own<ValType> content; own<ValType> content;
Mutability mutability; Mutability mutability;
GlobalTypeImpl(own<ValType>& content, // NOLINT(runtime/references) GlobalTypeImpl(own<ValType>& content, Mutability mutability)
Mutability mutability)
: ExternTypeImpl(EXTERN_GLOBAL), : ExternTypeImpl(EXTERN_GLOBAL),
content(std::move(content)), content(std::move(content)),
mutability(mutability) {} mutability(mutability) {}
...@@ -560,8 +558,7 @@ struct TableTypeImpl : ExternTypeImpl { ...@@ -560,8 +558,7 @@ struct TableTypeImpl : ExternTypeImpl {
own<ValType> element; own<ValType> element;
Limits limits; Limits limits;
TableTypeImpl(own<ValType>& element, // NOLINT(runtime/references) TableTypeImpl(own<ValType>& element, Limits limits)
Limits limits)
: ExternTypeImpl(EXTERN_TABLE), : ExternTypeImpl(EXTERN_TABLE),
element(std::move(element)), element(std::move(element)),
limits(limits) {} limits(limits) {}
...@@ -652,9 +649,7 @@ struct ImportTypeImpl { ...@@ -652,9 +649,7 @@ struct ImportTypeImpl {
Name name; Name name;
own<ExternType> type; own<ExternType> type;
ImportTypeImpl(Name& module, // NOLINT(runtime/references) ImportTypeImpl(Name& module, Name& name, own<ExternType>& type)
Name& name, // NOLINT(runtime/references)
own<ExternType>& type) // NOLINT(runtime/references)
: module(std::move(module)), : module(std::move(module)),
name(std::move(name)), name(std::move(name)),
type(std::move(type)) {} type(std::move(type)) {}
...@@ -695,8 +690,7 @@ struct ExportTypeImpl { ...@@ -695,8 +690,7 @@ struct ExportTypeImpl {
Name name; Name name;
own<ExternType> type; own<ExternType> type;
ExportTypeImpl(Name& name, // NOLINT(runtime/references) ExportTypeImpl(Name& name, own<ExternType>& type)
own<ExternType>& type) // NOLINT(runtime/references)
: name(std::move(name)), type(std::move(type)) {} : name(std::move(name)), type(std::move(type)) {}
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment