Commit f16da87d authored by Michael Achenbach's avatar Michael Achenbach Committed by V8 LUCI CQ

[foozzie] Drop incompatible flags

This adds the option to list disallowed flags for differential
fuzzing directly in the harness. Flags that can crash in smoke
tests shoule be added there.

No-Try: true
Bug: chromium:1240812
Change-Id: I57c772bedeac0ca6ba023c6b4929515b4b0e6cca
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3103314
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76369}
parent f9ddf2d2
...@@ -166,6 +166,15 @@ KNOWN_FAILURES = { ...@@ -166,6 +166,15 @@ KNOWN_FAILURES = {
'CrashTests/5694376231632896/1033966.js': 'flaky', 'CrashTests/5694376231632896/1033966.js': 'flaky',
} }
# Flags that are already crashy during smoke tests should not be used.
DISALLOWED_FLAGS = [
'--gdbjit',
]
def filter_flags(flags):
return [flag for flag in flags if flag not in DISALLOWED_FLAGS]
def infer_arch(d8): def infer_arch(d8):
"""Infer the V8 architecture from the build configuration next to the """Infer the V8 architecture from the build configuration next to the
...@@ -216,7 +225,7 @@ class ExecutionArgumentsConfig(object): ...@@ -216,7 +225,7 @@ class ExecutionArgumentsConfig(object):
d8 = os.path.join(BASE_PATH, d8) d8 = os.path.join(BASE_PATH, d8)
assert os.path.exists(d8) assert os.path.exists(d8)
flags = CONFIGS[config] + get('config_extra_flags') flags = CONFIGS[config] + filter_flags(get('config_extra_flags'))
RunOptions = namedtuple('RunOptions', ['arch', 'config', 'd8', 'flags']) RunOptions = namedtuple('RunOptions', ['arch', 'config', 'd8', 'flags'])
return RunOptions(infer_arch(d8), config, d8, flags) return RunOptions(infer_arch(d8), config, d8, flags)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment