Commit f16a7fe3 authored by bmeurer's avatar bmeurer Committed by Commit bot

[turbofan][x64] Try harder to use memory addressing modes.

When we don't have a base, and the displacement returned by the
BaseWithIndexAndDisplacement64Matcher cannot be encoded as immediate,
we can still try to utilize the scale factor matching by just using
the displacement as base. This happens when we do indexed memory
accesses to known addresses.

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2504123002
Cr-Commit-Position: refs/heads/master@{#41016}
parent 913da29e
...@@ -154,10 +154,18 @@ class X64OperandGenerator final : public OperandGenerator { ...@@ -154,10 +154,18 @@ class X64OperandGenerator final : public OperandGenerator {
} }
BaseWithIndexAndDisplacement64Matcher m(operand, AddressOption::kAllowAll); BaseWithIndexAndDisplacement64Matcher m(operand, AddressOption::kAllowAll);
DCHECK(m.matches()); DCHECK(m.matches());
if ((m.displacement() == nullptr || CanBeImmediate(m.displacement()))) { if (m.displacement() == nullptr || CanBeImmediate(m.displacement())) {
return GenerateMemoryOperandInputs( return GenerateMemoryOperandInputs(
m.index(), m.scale(), m.base(), m.displacement(), m.index(), m.scale(), m.base(), m.displacement(),
m.displacement_mode(), inputs, input_count); m.displacement_mode(), inputs, input_count);
} else if (m.base() == nullptr &&
m.displacement_mode() == kPositiveDisplacement) {
// The displacement cannot be an immediate, but we can use the
// displacement as base instead and still benefit from addressing
// modes for the scale.
return GenerateMemoryOperandInputs(m.index(), m.scale(), m.displacement(),
nullptr, m.displacement_mode(), inputs,
input_count);
} else { } else {
inputs[(*input_count)++] = UseRegister(operand->InputAt(0)); inputs[(*input_count)++] = UseRegister(operand->InputAt(0));
inputs[(*input_count)++] = UseRegister(operand->InputAt(1)); inputs[(*input_count)++] = UseRegister(operand->InputAt(1));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment