Commit f060eb32 authored by sgjesse@chromium.org's avatar sgjesse@chromium.org

Changed preemption related stuff in debugger entry.

Fixed an assertion which did not hold when the debugger was recursively entered.

Removed the clearing of the preemption flag in debugger entry as there was no need for it. The handling of preemption by the stack guard takes care of the in debugger situation anyway.
Review URL: http://codereview.chromium.org/48004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1520 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 21d97bca
......@@ -574,21 +574,11 @@ class EnterDebugger BASE_EMBEDDED {
EnterDebugger()
: prev_(Debug::debugger_entry()),
has_js_frames_(!it_.done()) {
ASSERT(!Debug::preemption_pending());
ASSERT(prev_ == NULL ? !Debug::preemption_pending() : true);
// Link recursive debugger entry.
Debug::set_debugger_entry(this);
// If a preemption is pending when first entering the debugger clear it as
// we don't want preemption happening while executing JavaScript in the
// debugger. When recursively entering the debugger the preemption flag
// cannot be set as this is disabled while in the debugger (see
// RuntimePreempt).
if (prev_ == NULL && StackGuard::IsPreempted()) {
StackGuard::Continue(PREEMPT);
}
ASSERT(!StackGuard::IsPreempted());
// Store the previous break id and frame id.
break_id_ = Debug::break_id();
break_frame_id_ = Debug::break_frame_id();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment