Commit efab0b74 authored by bmeurer's avatar bmeurer Committed by Commit bot

[turbofan] Fix invalid access to Parameter index.

A Parameter operator contains a ParameterInfo payload, not an int
payload, so the OpParameter<int> cast is invalid (and only worked by
coincidence currently).

BUG=chromium:515215
LOG=n
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/1266743002

Cr-Commit-Position: refs/heads/master@{#29919}
parent a67f31c4
......@@ -7,6 +7,7 @@
#include "src/base/flags.h"
#include "src/base/lazy-instance.h"
#include "src/bootstrapper.h"
#include "src/compiler/common-operator.h"
#include "src/compiler/graph-reducer.h"
#include "src/compiler/js-operator.h"
#include "src/compiler/node.h"
......@@ -571,11 +572,11 @@ Bounds Typer::Visitor::TypeIfException(Node* node) {
Bounds Typer::Visitor::TypeParameter(Node* node) {
int param = OpParameter<int>(node);
Type::FunctionType* function_type = typer_->function_type();
if (function_type != nullptr && param >= 0 &&
param < static_cast<int>(function_type->Arity())) {
return Bounds(Type::None(), function_type->Parameter(param));
if (Type::FunctionType* function_type = typer_->function_type()) {
int const index = ParameterIndexOf(node->op());
if (index >= 0 && index < function_type->Arity()) {
return Bounds(Type::None(), function_type->Parameter(index));
}
}
return Bounds::Unbounded(zone());
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment