Commit efaa34b5 authored by Jakob Kummerow's avatar Jakob Kummerow Committed by Commit Bot

Fix one more LookupIterator

Copying one object's named properties is always fine, even if one of
the names could be a large index on a TypedArray. Mark the LookupIterator
as OWN_SKIP_INTERCEPTOR to avoid the DCHECK.

Bug: chromium:1044909
Change-Id: I6918186a4b50df7865de3572cb674fd7d6eadb78
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2023558
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66027}
parent a35214a0
...@@ -244,9 +244,10 @@ V8_WARN_UNUSED_RESULT Maybe<bool> FastAssign( ...@@ -244,9 +244,10 @@ V8_WARN_UNUSED_RESULT Maybe<bool> FastAssign(
prop_value = JSObject::FastPropertyAt(from, representation, index); prop_value = JSObject::FastPropertyAt(from, representation, index);
} }
} else { } else {
LookupIterator it(isolate, from, next_key,
LookupIterator::OWN_SKIP_INTERCEPTOR);
ASSIGN_RETURN_ON_EXCEPTION_VALUE( ASSIGN_RETURN_ON_EXCEPTION_VALUE(
isolate, prop_value, isolate, prop_value, Object::GetProperty(&it), Nothing<bool>());
JSReceiver::GetProperty(isolate, from, next_key), Nothing<bool>());
stable = from->map() == *map; stable = from->map() == *map;
*descriptors.location() = map->instance_descriptors().ptr(); *descriptors.location() = map->instance_descriptors().ptr();
} }
......
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax
function main() {
const v2 = Object.prototype;
v2[4294967296] = {};
const v12 = {get: function() {}};
Object.defineProperty(v2, 4294967296, v12);
const v15 = {...v2};
}
%PrepareFunctionForOptimization(main);
main();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment