Commit ef29f4b9 authored by Georg Neis's avatar Georg Neis Committed by Commit Bot

[turbofan] Improve UpdateType debug output.

This is a partial reland of d3d13e4b, which
made an incorrect assumption about how the typer visits the graph.

Bug: chromium:906567
Change-Id: I55b70fdf7e655973e6ae33b64e127252c745517f
Reviewed-on: https://chromium-review.googlesource.com/c/1394549Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58526}
parent 4812f2af
...@@ -371,10 +371,11 @@ class Typer::Visitor : public Reducer { ...@@ -371,10 +371,11 @@ class Typer::Visitor : public Reducer {
if (V8_UNLIKELY(node->opcode() == IrOpcode::kNumberAdd)) { if (V8_UNLIKELY(node->opcode() == IrOpcode::kNumberAdd)) {
for (int i = 0; i < 2; ++i) { for (int i = 0; i < 2; ++i) {
Node* input = NodeProperties::GetValueInput(node, i); Node* input = NodeProperties::GetValueInput(node, i);
if (NodeProperties::IsTyped(input)) { remembered_types_[{node, i}] = NodeProperties::IsTyped(input)
remembered_types_[{node, i}] = NodeProperties::GetType(input); ? NodeProperties::GetType(input)
} : Type::Invalid();
} }
remembered_types_[{node, 2}] = current;
} }
NodeProperties::SetType(node, current); NodeProperties::SetType(node, current);
...@@ -387,9 +388,9 @@ class Typer::Visitor : public Reducer { ...@@ -387,9 +388,9 @@ class Typer::Visitor : public Reducer {
if (V8_UNLIKELY(node->opcode() == IrOpcode::kNumberAdd)) { if (V8_UNLIKELY(node->opcode() == IrOpcode::kNumberAdd)) {
for (int i = 0; i < 2; ++i) { for (int i = 0; i < 2; ++i) {
Node* input = NodeProperties::GetValueInput(node, i); Node* input = NodeProperties::GetValueInput(node, i);
if (NodeProperties::IsTyped(input)) { remembered_types_[{node, i}] = NodeProperties::IsTyped(input)
remembered_types_[{node, i}] = NodeProperties::GetType(input); ? NodeProperties::GetType(input)
} : Type::Invalid();
} }
remembered_types_[{node, 2}] = current; remembered_types_[{node, 2}] = current;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment