[cleanup] Remove parameters accessors from CommonFrame

Change-Id: Ic54046824d4f3c98caa8381d2ece46c9985a2b98
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2475734Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70565}

src/debug/debug-frames.cc

@@ -54,14 +54,10 @@ JavaScriptFrame* FrameInspector::javascript_frame() {
                                         : JavaScriptFrame::cast(frame_);
 }
 
-int FrameInspector::GetParametersCount() {
-  if (is_optimized_) return deoptimized_frame_->parameters_count();
-  return frame_->ComputeParametersCount();
-}
-
 Handle<Object> FrameInspector::GetParameter(int index) {
   if (is_optimized_) return deoptimized_frame_->GetParameter(index);
-  return handle(frame_->GetParameter(index), isolate_);
+  DCHECK(IsJavaScript());
+  return handle(javascript_frame()->GetParameter(index), isolate_);
 }
 
 Handle<Object> FrameInspector::GetExpression(int index) {

src/debug/debug-frames.h

@@ -25,7 +25,6 @@ class FrameInspector {
 
   ~FrameInspector();
 
-  int GetParametersCount();
   Handle<JSFunction> GetFunction() const { return function_; }
   Handle<Script> GetScript() { return script_; }
   Handle<Object> GetParameter(int index);

src/execution/frames.cc

@@ -879,13 +879,6 @@ int CommonFrame::ComputeExpressionsCount() const {
   return static_cast<int>((base - limit) / kSystemPointerSize);
 }
 
-Object CommonFrame::GetParameter(int index) const {
-  // CommonFrame does not define any parameters.
-  UNREACHABLE();
-}
-
-int CommonFrame::ComputeParametersCount() const { return 0; }
-
 void CommonFrame::ComputeCallerState(State* state) const {
   state->sp = caller_sp();
   state->fp = caller_fp();
@@ -897,8 +890,6 @@ void CommonFrame::ComputeCallerState(State* state) const {
       reinterpret_cast<Address*>(ComputeConstantPoolAddress(fp()));
 }
 
-bool CommonFrame::IsConstructor() const { return false; }
-
 void CommonFrame::Summarize(std::vector<FrameSummary>* functions) const {
   // This should only be called on frames which override this method.
   UNREACHABLE();

src/execution/frames.h

@@ -485,14 +485,6 @@ class CommonFrame : public StackFrame {
 
   Address GetCallerStackPointer() const override;
 
-  // Access the parameters.
-  virtual Object GetParameter(int index) const;
-  virtual int ComputeParametersCount() const;
-  Handle<FixedArray> GetParameters() const;
-
-  // Check if this frame is a constructor frame invoked through 'new'.
-  virtual bool IsConstructor() const;
-
   // Build a list with summaries for this frame including all inlined frames.
   // The functions are ordered bottom-to-top (i.e. summaries.last() is the
   // top-most activation; caller comes before callee).
@@ -569,8 +561,8 @@ class JavaScriptFrame : public CommonFrame {
 
   // Access the parameters.
   inline Address GetParameterSlot(int index) const;
-  Object GetParameter(int index) const override;
-  int ComputeParametersCount() const override;
+  Object GetParameter(int index) const;
+  virtual int ComputeParametersCount() const;
 #ifdef V8_NO_ARGUMENTS_ADAPTOR
   int GetActualArgumentCount() const;
 #endif
@@ -580,7 +572,7 @@ class JavaScriptFrame : public CommonFrame {
   void SetParameterValue(int index, Object value) const;
 
   // Check if this frame is a constructor frame invoked through 'new'.
-  bool IsConstructor() const override;
+  bool IsConstructor() const;
 
   // Determines whether this frame includes inlined activations. To get details
   // about the inlined frames use {GetFunctions} and {Summarize}.
@@ -755,7 +747,7 @@ class BuiltinExitFrame : public ExitFrame {
 
   JSFunction function() const;
   Object receiver() const;
-  bool IsConstructor() const override;
+  bool IsConstructor() const;
 
   void Print(StringStream* accumulator, PrintMode mode,
              int index) const override;
@@ -764,8 +756,8 @@ class BuiltinExitFrame : public ExitFrame {
   inline explicit BuiltinExitFrame(StackFrameIteratorBase* iterator);
 
  private:
-  Object GetParameter(int i) const override;
-  int ComputeParametersCount() const override;
+  Object GetParameter(int i) const;
+  int ComputeParametersCount() const;
 
   inline Object receiver_slot_object() const;
   inline Object argc_slot_object() const;
@@ -917,7 +909,7 @@ class BuiltinFrame final : public TypedFrame {
     DCHECK(frame->is_builtin());
     return static_cast<BuiltinFrame*>(frame);
   }
-  int ComputeParametersCount() const override;
+  int ComputeParametersCount() const;
 
  protected:
   inline explicit BuiltinFrame(StackFrameIteratorBase* iterator);