Commit ed636840 authored by Andreas Haas's avatar Andreas Haas Committed by V8 LUCI CQ

[wasm][debug] Fix GCMole issue in AddWasmTableObjectInternalProperties

An object got allocated as part of a parameter expression, which may
have caused GC issues.

Bug: chromium:1230041
Change-Id: I9a046fe36cd3b84e5df7b1400670b76e201ac026
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3035765Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75777}
parent 0b7466fd
......@@ -1142,10 +1142,9 @@ Handle<ArrayList> AddWasmTableObjectInternalProperties(
JSObject::SetPrototype(final_entries, isolate->factory()->null_value(), false,
kDontThrow)
.Check();
result = ArrayList::Add(
isolate, result,
isolate->factory()->NewStringFromStaticChars("[[Entries]]"),
final_entries);
Handle<String> entries_string =
isolate->factory()->NewStringFromStaticChars("[[Entries]]");
result = ArrayList::Add(isolate, result, entries_string, final_entries);
return result;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment