Commit ecfec3b0 authored by mstarzinger's avatar mstarzinger Committed by Commit bot

[turbofan] Respect pretenuring of heap numbers.

This extends pretenuring decisions based on allocation sites to heap
numbers that are allocated as part of object literals. It ensures memory
locality of a bigger enclosure of the deep copy of an object literal.

R=bmeurer@chromium.org
TEST=cctest/test-heap/OptimizedPretenuringMixedInObjectProperties

Review-Url: https://codereview.chromium.org/2135933002
Cr-Commit-Position: refs/heads/master@{#37645}
parent a9915587
...@@ -1087,7 +1087,7 @@ Node* JSCreateLowering::AllocateFastLiteral( ...@@ -1087,7 +1087,7 @@ Node* JSCreateLowering::AllocateFastLiteral(
effect = graph()->NewNode( effect = graph()->NewNode(
common()->BeginRegion(RegionObservability::kNotObservable), effect); common()->BeginRegion(RegionObservability::kNotObservable), effect);
value = effect = graph()->NewNode( value = effect = graph()->NewNode(
simplified()->Allocate(NOT_TENURED), simplified()->Allocate(pretenure),
jsgraph()->Constant(HeapNumber::kSize), effect, control); jsgraph()->Constant(HeapNumber::kSize), effect, control);
effect = graph()->NewNode( effect = graph()->NewNode(
simplified()->StoreField(AccessBuilder::ForMap()), value, simplified()->StoreField(AccessBuilder::ForMap()), value,
......
...@@ -102,9 +102,6 @@ ...@@ -102,9 +102,6 @@
# coverage). # coverage).
'test-heap/ObjectsInOptimizedCodeAreWeak': [PASS, NO_VARIANTS], 'test-heap/ObjectsInOptimizedCodeAreWeak': [PASS, NO_VARIANTS],
# TODO(mstarzinger): The pretenuring decision is different in TurboFan.
'test-heap/OptimizedPretenuringMixedInObjectProperties': [PASS, NO_VARIANTS],
# TurboFan cpu profiler result is different. # TurboFan cpu profiler result is different.
'test-cpu-profiler/CollectDeoptEvents': [PASS, NO_VARIANTS], 'test-cpu-profiler/CollectDeoptEvents': [PASS, NO_VARIANTS],
'test-cpu-profiler/DeoptAtFirstLevelInlinedSource': [PASS, NO_VARIANTS], 'test-cpu-profiler/DeoptAtFirstLevelInlinedSource': [PASS, NO_VARIANTS],
...@@ -170,6 +167,7 @@ ...@@ -170,6 +167,7 @@
'test-heap/OptimizedPretenuringAllocationFolding': [PASS, NO_IGNITION], 'test-heap/OptimizedPretenuringAllocationFolding': [PASS, NO_IGNITION],
'test-heap/OptimizedPretenuringdoubleArrayLiterals': [PASS, NO_IGNITION], 'test-heap/OptimizedPretenuringdoubleArrayLiterals': [PASS, NO_IGNITION],
'test-heap/OptimizedPretenuringDoubleArrayProperties': [PASS, NO_IGNITION], 'test-heap/OptimizedPretenuringDoubleArrayProperties': [PASS, NO_IGNITION],
'test-heap/OptimizedPretenuringMixedInObjectProperties': [PASS, NO_IGNITION],
'test-heap/OptimizedPretenuringNestedDoubleLiterals': [PASS, NO_IGNITION], 'test-heap/OptimizedPretenuringNestedDoubleLiterals': [PASS, NO_IGNITION],
'test-heap/OptimizedPretenuringNestedMixedArrayLiterals': [PASS, NO_IGNITION], 'test-heap/OptimizedPretenuringNestedMixedArrayLiterals': [PASS, NO_IGNITION],
'test-heap/OptimizedPretenuringNestedObjectLiterals': [PASS, NO_IGNITION], 'test-heap/OptimizedPretenuringNestedObjectLiterals': [PASS, NO_IGNITION],
...@@ -561,6 +559,7 @@ ...@@ -561,6 +559,7 @@
'test-heap/OptimizedPretenuringAllocationFolding': [FAIL], 'test-heap/OptimizedPretenuringAllocationFolding': [FAIL],
'test-heap/OptimizedPretenuringdoubleArrayLiterals': [FAIL], 'test-heap/OptimizedPretenuringdoubleArrayLiterals': [FAIL],
'test-heap/OptimizedPretenuringDoubleArrayProperties': [FAIL], 'test-heap/OptimizedPretenuringDoubleArrayProperties': [FAIL],
'test-heap/OptimizedPretenuringMixedInObjectProperties': [FAIL],
'test-heap/OptimizedPretenuringNestedDoubleLiterals': [FAIL], 'test-heap/OptimizedPretenuringNestedDoubleLiterals': [FAIL],
'test-heap/OptimizedPretenuringNestedMixedArrayLiterals': [FAIL], 'test-heap/OptimizedPretenuringNestedMixedArrayLiterals': [FAIL],
'test-heap/OptimizedPretenuringNestedObjectLiterals': [FAIL], 'test-heap/OptimizedPretenuringNestedObjectLiterals': [FAIL],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment