Commit ec850513 authored by Jakob Gruber's avatar Jakob Gruber Committed by V8 LUCI CQ

[compiler] Fix and re-enable tests requiring specific optimization timing

We now have %FinalizeOptimization() to block until all concurrent
compile jobs are done.

Bug: v8:7790,v8:12004
Change-Id: Ibb9955be06957b3f395b680e9be570c7c3ec0dcb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086478
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#76231}
parent bd3a354a
...@@ -16,4 +16,5 @@ function f() { ...@@ -16,4 +16,5 @@ function f() {
f(); f();
f(); f();
f(); f();
%FinalizeOptimization();
assertOptimized(f); assertOptimized(f);
...@@ -207,12 +207,6 @@ ...@@ -207,12 +207,6 @@
'regress/regress-crbug-941743': [PASS, HEAVY], 'regress/regress-crbug-941743': [PASS, HEAVY],
'regress/regress-crbug-1191886': [PASS, HEAVY], 'regress/regress-crbug-1191886': [PASS, HEAVY],
'wasm/externref-globals': [PASS, HEAVY], 'wasm/externref-globals': [PASS, HEAVY],
# Unpredictable results due to assertOptimized with concurrent optimization.
# TODO(v8:12004): Add a runtime function to flush the optimizing compile
# dispatcher *without* aborting existing jobs.
'interrupt-budget-override': [PASS,FAIL],
'never-optimize': [PASS,FAIL],
}], # ALWAYS }], # ALWAYS
############################################################################## ##############################################################################
......
...@@ -43,5 +43,6 @@ for (let i = 0; i < 1000; ++i) { ...@@ -43,5 +43,6 @@ for (let i = 0; i < 1000; ++i) {
u1(); u1();
u2(); u2();
} }
%FinalizeOptimization();
assertUnoptimized(u1); assertUnoptimized(u1);
assertOptimized(u2); assertOptimized(u2);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment