[torque] check runtime function signatures properly

The missing check that runtime function parameters have to be tagged
lead to a bug: https://chromium-review.googlesource.com/c/v8/v8/+/1604071

drive-by-fix: Remove obsolete verbose mode. It hasn't been maintained
since the very early Torque versions, and the remaining printf's are
rather useless.

Bug: v8:7793
Change-Id: I59adf4c6c5d92a8838cdc638afb2ab7a41550b55
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1609910
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61483}

src/torque/declaration-visitor.cc

@@ -132,27 +132,28 @@ Builtin* DeclarationVisitor::CreateBuiltin(BuiltinDeclaration* decl,
 void DeclarationVisitor::Visit(ExternalRuntimeDeclaration* decl,
                                const Signature& signature,
                                base::Optional<Statement*> body) {
-  if (GlobalContext::verbose()) {
-    std::cout << "found declaration of external runtime " << decl->name
-              << " with signature ";
-  }
-
   if (signature.parameter_types.types.size() == 0 ||
       !(signature.parameter_types.types[0] ==
         Declarations::LookupGlobalType(CONTEXT_TYPE_STRING))) {
-    std::stringstream stream;
-    stream << "first parameter to runtime " << decl->name
-           << " is not a context but should be";
-    ReportError(stream.str());
+    ReportError(
+        "first parameter to runtime functions has to be the context and have "
+        "type Context, but found type ",
+        signature.parameter_types.types[0]);
   }
-
-  if (signature.return_type->IsStructType()) {
-    std::stringstream stream;
-    stream << "runtime functions (in this case" << decl->name
-           << ") cannot return structs (in this case "
-           << static_cast<const StructType*>(signature.return_type)->name()
-           << ")";
-    ReportError(stream.str());
+  if (!(signature.return_type->IsSubtypeOf(TypeOracle::GetObjectType()) ||
+        signature.return_type == TypeOracle::GetVoidType() ||
+        signature.return_type == TypeOracle::GetNeverType())) {
+    ReportError(
+        "runtime functions can only return tagged values, but found type ",
+        signature.return_type);
+  }
+  for (const Type* parameter_type : signature.parameter_types.types) {
+    if (!parameter_type->IsSubtypeOf(TypeOracle::GetObjectType())) {
+      ReportError(
+          "runtime functions can only take tagged values as parameters, but "
+          "found type ",
+          *parameter_type);
+    }
   }
 
   Declarations::DeclareRuntimeFunction(decl->name, signature,
@@ -162,11 +163,6 @@ void DeclarationVisitor::Visit(ExternalRuntimeDeclaration* decl,
 void DeclarationVisitor::Visit(ExternalMacroDeclaration* decl,
                                const Signature& signature,
                                base::Optional<Statement*> body) {
-  if (GlobalContext::verbose()) {
-    std::cout << "found declaration of external macro " << decl->name
-              << " with signature ";
-  }
-
   Declarations::DeclareMacro(decl->name, decl->external_assembler_name,
                              signature, decl->transitioning, body, decl->op);
 }

src/torque/global-context.h

@@ -20,8 +20,7 @@ class GlobalContext : public ContextualClass<GlobalContext> {
   GlobalContext(GlobalContext&&) V8_NOEXCEPT = default;
   GlobalContext& operator=(GlobalContext&&) V8_NOEXCEPT = default;
   explicit GlobalContext(Ast ast)
-      : verbose_(false),
-        collect_language_server_data_(false),
+      : collect_language_server_data_(false),
         force_assert_statements_(false),
         ast_(std::move(ast)) {
     CurrentScope::Scope current_scope(nullptr);
@@ -67,8 +66,6 @@ class GlobalContext : public ContextualClass<GlobalContext> {
     return Get().cpp_includes_;
   }
 
-  static void SetVerbose() { Get().verbose_ = true; }
-  static bool verbose() { return Get().verbose_; }
   static void SetCollectLanguageServerData() {
     Get().collect_language_server_data_ = true;
   }
@@ -84,7 +81,6 @@ class GlobalContext : public ContextualClass<GlobalContext> {
   static Ast* ast() { return &Get().ast_; }
 
  private:
-  bool verbose_;
   bool collect_language_server_data_;
   bool force_assert_statements_;
   Namespace* default_namespace_;

src/torque/implementation-visitor.cc

@@ -1597,10 +1597,6 @@ void ImplementationVisitor::GenerateMacroFunctionDeclaration(
 void ImplementationVisitor::GenerateFunctionDeclaration(
     std::ostream& o, const std::string& macro_prefix, const std::string& name,
     const Signature& signature, const NameVector& parameter_names) {
-  if (GlobalContext::verbose()) {
-    std::cout << "generating source for declaration " << name << "\n";
-  }
-
   if (signature.return_type->IsVoidOrNever()) {
     o << "void";
   } else {
@@ -2235,11 +2231,6 @@ VisitResult ImplementationVisitor::GenerateCall(
                      &argument_range, &constexpr_arguments);
   }
 
-  if (GlobalContext::verbose()) {
-    std::cout << "generating code for call to " << callable->ReadableName()
-              << "\n";
-  }
-
   size_t label_count = callable->signature().labels.size();
   if (label_count != arguments.labels.size()) {
     std::stringstream s;

src/torque/ls/message-handler.cc

@@ -178,7 +178,6 @@ void RecompileTorque(MessageWriter writer) {
 
   TorqueCompilerOptions options;
   options.output_directory = "";
-  options.verbose = false;
   options.collect_language_server_data = true;
   options.force_assert_statements = true;
 

src/torque/torque-compiler.cc

@@ -47,7 +47,6 @@ void ReadAndParseTorqueFile(const std::string& path) {
 
 void CompileCurrentAst(TorqueCompilerOptions options) {
   GlobalContext::Scope global_context(std::move(CurrentAst::Get()));
-  if (options.verbose) GlobalContext::SetVerbose();
   if (options.collect_language_server_data) {
     GlobalContext::SetCollectLanguageServerData();
   }

src/torque/torque-compiler.h

@@ -17,7 +17,6 @@ namespace torque {
 
 struct TorqueCompilerOptions {
   std::string output_directory = "";
-  bool verbose = false;
   bool collect_language_server_data = false;
 
   // assert(...) are only generated for debug builds. The provide

src/torque/torque.cc

@@ -11,7 +11,6 @@ namespace torque {
 
 int WrappedMain(int argc, const char** argv) {
   std::string output_directory;
-  bool verbose = false;
   std::vector<std::string> files;
 
   for (int i = 1; i < argc; ++i) {
@@ -20,10 +19,6 @@ int WrappedMain(int argc, const char** argv) {
       output_directory = argv[++i];
       continue;
     }
-    if (!strcmp("-v", argv[i])) {
-      verbose = true;
-      continue;
-    }
 
     // Otherwise it's a .tq file. Remember it for compilation.
     files.emplace_back(argv[i]);
@@ -31,7 +26,6 @@ int WrappedMain(int argc, const char** argv) {
 
   TorqueCompilerOptions options;
   options.output_directory = output_directory;
-  options.verbose = verbose;
   options.collect_language_server_data = false;
   options.force_assert_statements = false;
 

test/unittests/torque/ls-server-data-unittest.cc

@@ -19,7 +19,6 @@ struct TestCompiler {
   void Compile(const std::string& source) {
     TorqueCompilerOptions options;
     options.output_directory = "";
-    options.verbose = false;
     options.collect_language_server_data = true;
     options.force_assert_statements = true;
 

test/unittests/torque/torque-unittest.cc

@@ -16,7 +16,6 @@ namespace {
 TorqueCompilerResult TestCompileTorque(const std::string& source) {
   TorqueCompilerOptions options;
   options.output_directory = "";
-  options.verbose = false;
   options.collect_language_server_data = false;
   options.force_assert_statements = false;